From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 088CEC433FE for ; Wed, 25 May 2022 09:07:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237258AbiEYJG4 (ORCPT ); Wed, 25 May 2022 05:06:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242890AbiEYJFs (ORCPT ); Wed, 25 May 2022 05:05:48 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19884A5001; Wed, 25 May 2022 02:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f149isEkjIfAHkC+kbuLgy37kQgwJtPXTfas0jr63Rc=; b=BWj14xMlVhzlgV8vM7pFcL7HEB j2YKII9yKoy9BoT+mo3FTOVL20gSISBCGw21FQ0sk9ZTnvsmre0CQOX1Ps/UAI7lyPRWqCVtrGlup bBc/gAafKdFc4egnMR42NpLeQA8T44Ko1/rwzB1eO40eCR/Ka7HaqF3pdGeH54TFx9ZGp+mOsLmai X3Sx+wWUtJfD6uM2Ba0d46C0pKz71i8szm4KqsUSIJ8W7/oY2YCNou2gBH+vnyZwgHo9sLgSMGuP/ 2vqpy9gN/RNy4+tGPCoLoeozqyMMRWPUwEjWZCFRWi1rIqS95/cF0rsyP9UKey2k0vz37XoTHidTH s2ALPSMQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntmvt-00AWFk-ED; Wed, 25 May 2022 09:03:57 +0000 Date: Wed, 25 May 2022 02:03:57 -0700 From: Christoph Hellwig To: Mario Limonciello Cc: Damien Le Moal , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , open list , hdegoede@redhat.com Subject: Re: [PATCH 2/3] ata: ahci: Rename module parameter for lpm policy Message-ID: References: <20220524170508.563-1-mario.limonciello@amd.com> <20220524170508.563-3-mario.limonciello@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220524170508.563-3-mario.limonciello@amd.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Tue, May 24, 2022 at 12:05:07PM -0500, Mario Limonciello wrote: > The LPM policy is applied to more chipsets than just mobile designs. > Update the module parameter to drop the word "mobile" to make this > clearer to users. > > Also, document this renamed parameter in the admin-guide for users > as it was missing previously. Even if the name is confusing I don't think we should rename it as that breaks existing setups. I think just updating the documentation is good enough, but if you feel strongly we can just add the new name while keeping the old one as an alias.