From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CF6C433EF for ; Wed, 25 May 2022 11:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241073AbiEYLlg (ORCPT ); Wed, 25 May 2022 07:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237970AbiEYLld (ORCPT ); Wed, 25 May 2022 07:41:33 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F2D4A2047 for ; Wed, 25 May 2022 04:41:32 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id a17so2263342plb.4 for ; Wed, 25 May 2022 04:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Di7XV4IGWF77tQvxoeiNfKzeIQMl+KEXZAhavQki9xI=; b=4PIrBTtSY7gdXmJ5owF/C1/ZrJroXty20T94JZS01Q1mZd4fgW+U09Ylg34REtQHwg VvHo688nCXJo+Q7+koX9lz+0tbnGoEkPPGZ2AgZ66FiiIBz/6J2zuZ2o6ahZyYplwi5a ZpYwEegz5Et296T5u2GHEruAMZ0J0oFI2MrnGS/px1P5ZBQ3T4Fw9BIIQZ7ilJbngsZX RuccrSfBxgHlo3I+FuYajmX7kRE146DU7yk3DvUqdzSiPKw6IAB1msE3q4MepqWL+Drr HByjp0hRrmK7RyClGTppcHZFzyvg58pywiCu6oaOmRd1JgAsrEtQimpdgiRstKiuADI5 INkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Di7XV4IGWF77tQvxoeiNfKzeIQMl+KEXZAhavQki9xI=; b=RzHsXvzQ1GylWk2ZE7nlipDMGu4ItJd5uUOiN7v87xi9k498zYtWF5GpjOTcMcaB2C ZWhghrzXEuq76yo+A9Ms2zS/mw1oVC5fK2HaRkGxShp3elUzBSql89goQHRJ5+ZLcV3q 8zEjGbjviz1kJQ7wGMgWOmGhs668PESYvKNAjOBtJumA7w14afdFc68VxDIA30CkfKyB SRwhAGEhHP40kDAI12Pbb/iBzdIX3wK0gbSUQ+oR+G2J+hMBbdYHfRJdTHFAEWoRr7DS XOd0YJP4sc35FdlTSBUVyny0ZFMYMGoAyW2F81gasdr3RkUDv97wWyFty2twhBdnL92L nTsw== X-Gm-Message-State: AOAM530QzFZNHW5wNSiZmjkgL6e8et1PrmQQ2wWpQedAhfFxBf/+2JFg +PCP7h+z1/Jo+b/io9XOrPkKrg== X-Google-Smtp-Source: ABdhPJz17xYLcQGQExhrQwEb4JqIELoJYEvW83JIvWk7UhoFB1UVcickRa/OeXecDgwrKutJKIJ8Fg== X-Received: by 2002:a17:902:ec85:b0:161:cff5:17c8 with SMTP id x5-20020a170902ec8500b00161cff517c8mr32385262plg.62.1653478891804; Wed, 25 May 2022 04:41:31 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:c40f:7b5:4fa8:df3f]) by smtp.gmail.com with ESMTPSA id i4-20020aa787c4000000b00518d06efbc8sm3393965pfo.98.2022.05.25.04.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 May 2022 04:41:31 -0700 (PDT) Date: Wed, 25 May 2022 19:41:26 +0800 From: Muchun Song To: Roman Gushchin Cc: hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v4 04/11] mm: vmscan: rework move_pages_to_lru() Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-5-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 24, 2022 at 07:43:03PM -0700, Roman Gushchin wrote: > On Tue, May 24, 2022 at 02:05:44PM +0800, Muchun Song wrote: > > In the later patch, we will reparent the LRU pages. The pages moved to > > appropriate LRU list can be reparented during the process of the > > move_pages_to_lru(). So holding a lruvec lock by the caller is wrong, we > > should use the more general interface of folio_lruvec_relock_irq() to > > acquire the correct lruvec lock. > > > > Signed-off-by: Muchun Song > > With changes asked by Johannes : > > Acked-by: Roman Gushchin > Thanks Roman. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Subject: Re: [PATCH v4 04/11] mm: vmscan: rework move_pages_to_lru() Date: Wed, 25 May 2022 19:41:26 +0800 Message-ID: References: <20220524060551.80037-1-songmuchun@bytedance.com> <20220524060551.80037-5-songmuchun@bytedance.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Di7XV4IGWF77tQvxoeiNfKzeIQMl+KEXZAhavQki9xI=; b=4PIrBTtSY7gdXmJ5owF/C1/ZrJroXty20T94JZS01Q1mZd4fgW+U09Ylg34REtQHwg VvHo688nCXJo+Q7+koX9lz+0tbnGoEkPPGZ2AgZ66FiiIBz/6J2zuZ2o6ahZyYplwi5a ZpYwEegz5Et296T5u2GHEruAMZ0J0oFI2MrnGS/px1P5ZBQ3T4Fw9BIIQZ7ilJbngsZX RuccrSfBxgHlo3I+FuYajmX7kRE146DU7yk3DvUqdzSiPKw6IAB1msE3q4MepqWL+Drr HByjp0hRrmK7RyClGTppcHZFzyvg58pywiCu6oaOmRd1JgAsrEtQimpdgiRstKiuADI5 INkw== Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Roman Gushchin Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, duanxiongchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org, longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org On Tue, May 24, 2022 at 07:43:03PM -0700, Roman Gushchin wrote: > On Tue, May 24, 2022 at 02:05:44PM +0800, Muchun Song wrote: > > In the later patch, we will reparent the LRU pages. The pages moved to > > appropriate LRU list can be reparented during the process of the > > move_pages_to_lru(). So holding a lruvec lock by the caller is wrong, we > > should use the more general interface of folio_lruvec_relock_irq() to > > acquire the correct lruvec lock. > > > > Signed-off-by: Muchun Song > > With changes asked by Johannes : > > Acked-by: Roman Gushchin > Thanks Roman.