From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 121B7C43217 for ; Wed, 25 May 2022 13:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244511AbiEYNp3 (ORCPT ); Wed, 25 May 2022 09:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232257AbiEYNpY (ORCPT ); Wed, 25 May 2022 09:45:24 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 38A156D395; Wed, 25 May 2022 06:45:23 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D24C91042; Wed, 25 May 2022 06:45:22 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.0.228]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E24743F66F; Wed, 25 May 2022 06:45:14 -0700 (PDT) Date: Wed, 25 May 2022 14:45:11 +0100 From: Mark Rutland To: Xu Kuohai Cc: bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, hpa@zytor.com, Shuah Khan , Jakub Kicinski , Jesper Dangaard Brouer , Pasha Tatashin , Ard Biesheuvel , Daniel Kiss , Steven Price , Sudeep Holla , Marc Zyngier , Peter Collingbourne , Mark Brown , Delyan Kratunov , Kumar Kartikeya Dwivedi Subject: Re: [PATCH bpf-next v5 3/6] bpf: Remove is_valid_bpf_tramp_flags() Message-ID: References: <20220518131638.3401509-1-xukuohai@huawei.com> <20220518131638.3401509-4-xukuohai@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518131638.3401509-4-xukuohai@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 09:16:35AM -0400, Xu Kuohai wrote: > BPF_TRAM_F_XXX flags are not used by user code and are almost constant > at compile time, so run time validation is a bit overkill. Remove > is_valid_bpf_tramp_flags() and add some usage comments. > > Signed-off-by: Xu Kuohai > Acked-by: Song Liu Am I right in thinking this is independent of the arm64-specific bits, and could be taken on its own now? Mark. > --- > arch/x86/net/bpf_jit_comp.c | 20 -------------------- > kernel/bpf/bpf_struct_ops.c | 3 +++ > kernel/bpf/trampoline.c | 3 +++ > 3 files changed, 6 insertions(+), 20 deletions(-) > > diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c > index a2b6d197c226..7698ef3b4821 100644 > --- a/arch/x86/net/bpf_jit_comp.c > +++ b/arch/x86/net/bpf_jit_comp.c > @@ -1922,23 +1922,6 @@ static int invoke_bpf_mod_ret(const struct btf_func_model *m, u8 **pprog, > return 0; > } > > -static bool is_valid_bpf_tramp_flags(unsigned int flags) > -{ > - if ((flags & BPF_TRAMP_F_RESTORE_REGS) && > - (flags & BPF_TRAMP_F_SKIP_FRAME)) > - return false; > - > - /* > - * BPF_TRAMP_F_RET_FENTRY_RET is only used by bpf_struct_ops, > - * and it must be used alone. > - */ > - if ((flags & BPF_TRAMP_F_RET_FENTRY_RET) && > - (flags & ~BPF_TRAMP_F_RET_FENTRY_RET)) > - return false; > - > - return true; > -} > - > /* Example: > * __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev); > * its 'struct btf_func_model' will be nr_args=2 > @@ -2017,9 +2000,6 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *i > if (nr_args > 6) > return -ENOTSUPP; > > - if (!is_valid_bpf_tramp_flags(flags)) > - return -EINVAL; > - > /* Generated trampoline stack layout: > * > * RBP + 8 [ return address ] > diff --git a/kernel/bpf/bpf_struct_ops.c b/kernel/bpf/bpf_struct_ops.c > index d9a3c9207240..0572cc5aeb28 100644 > --- a/kernel/bpf/bpf_struct_ops.c > +++ b/kernel/bpf/bpf_struct_ops.c > @@ -341,6 +341,9 @@ int bpf_struct_ops_prepare_trampoline(struct bpf_tramp_links *tlinks, > > tlinks[BPF_TRAMP_FENTRY].links[0] = link; > tlinks[BPF_TRAMP_FENTRY].nr_links = 1; > + /* BPF_TRAMP_F_RET_FENTRY_RET is only used by bpf_struct_ops, > + * and it must be used alone. > + */ > flags = model->ret_size > 0 ? BPF_TRAMP_F_RET_FENTRY_RET : 0; > return arch_prepare_bpf_trampoline(NULL, image, image_end, > model, flags, tlinks, NULL); > diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c > index 93c7675f0c9e..bd3f2e673874 100644 > --- a/kernel/bpf/trampoline.c > +++ b/kernel/bpf/trampoline.c > @@ -358,6 +358,9 @@ static int bpf_trampoline_update(struct bpf_trampoline *tr) > > if (tlinks[BPF_TRAMP_FEXIT].nr_links || > tlinks[BPF_TRAMP_MODIFY_RETURN].nr_links) > + /* NOTE: BPF_TRAMP_F_RESTORE_REGS and BPF_TRAMP_F_SKIP_FRAME > + * should not be set together. > + */ > flags = BPF_TRAMP_F_CALL_ORIG | BPF_TRAMP_F_SKIP_FRAME; > > if (ip_arg) > -- > 2.30.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21374C433EF for ; Wed, 25 May 2022 13:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9ianGc+Ug46hVN36WWcN7LZmI+u0wT2RuUBVWjYwNY4=; b=OQ2TjHQR/TQ30j MGjYCFzfjr5ZsL6QYVflMIPHRsbQQW9JUtJLcraj4UfCrFICYEVxO1/ILynTyHAx1GBdY3psIn/Hy XduMfl8/DBqXZrbn2aKVjOYxJpBJM6gVJKo/VaMnRlE2rtqI2NUefq/q2beZYBp2uxsT/TO5yWXFq Y66Wz6rFwJIN2j0xGT37K/Up9xrVoiyZuIiKrebFaA9Hv+KG54EpN6Bwtypn/MQLyflRtPgmF8Ftm Rtey3chgfpeGODe52Zfh+kSwXkOWq387COtyy1D4U9hzlFiBZg7Q37mKqcTwzezAOQMOn9LmRFtsY EJht3qeWad9mGbXultSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntrKJ-00BILw-Df; Wed, 25 May 2022 13:45:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntrKG-00BIKt-AS for linux-arm-kernel@lists.infradead.org; Wed, 25 May 2022 13:45:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D24C91042; Wed, 25 May 2022 06:45:22 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.0.228]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E24743F66F; Wed, 25 May 2022 06:45:14 -0700 (PDT) Date: Wed, 25 May 2022 14:45:11 +0100 From: Mark Rutland To: Xu Kuohai Cc: bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, Catalin Marinas , Will Deacon , Steven Rostedt , Ingo Molnar , Daniel Borkmann , Alexei Starovoitov , Zi Shen Lim , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S . Miller" , Hideaki YOSHIFUJI , David Ahern , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, hpa@zytor.com, Shuah Khan , Jakub Kicinski , Jesper Dangaard Brouer , Pasha Tatashin , Ard Biesheuvel , Daniel Kiss , Steven Price , Sudeep Holla , Marc Zyngier , Peter Collingbourne , Mark Brown , Delyan Kratunov , Kumar Kartikeya Dwivedi Subject: Re: [PATCH bpf-next v5 3/6] bpf: Remove is_valid_bpf_tramp_flags() Message-ID: References: <20220518131638.3401509-1-xukuohai@huawei.com> <20220518131638.3401509-4-xukuohai@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220518131638.3401509-4-xukuohai@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_064524_503614_2A647170 X-CRM114-Status: GOOD ( 23.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 09:16:35AM -0400, Xu Kuohai wrote: > BPF_TRAM_F_XXX flags are not used by user code and are almost constant > at compile time, so run time validation is a bit overkill. Remove > is_valid_bpf_tramp_flags() and add some usage comments. > > Signed-off-by: Xu Kuohai > Acked-by: Song Liu Am I right in thinking this is independent of the arm64-specific bits, and could be taken on its own now? Mark. > --- > arch/x86/net/bpf_jit_comp.c | 20 -------------------- > kernel/bpf/bpf_struct_ops.c | 3 +++ > kernel/bpf/trampoline.c | 3 +++ > 3 files changed, 6 insertions(+), 20 deletions(-) > > diff --git a/arch/x86/net/bpf_jit_comp.c b/arch/x86/net/bpf_jit_comp.c > index a2b6d197c226..7698ef3b4821 100644 > --- a/arch/x86/net/bpf_jit_comp.c > +++ b/arch/x86/net/bpf_jit_comp.c > @@ -1922,23 +1922,6 @@ static int invoke_bpf_mod_ret(const struct btf_func_model *m, u8 **pprog, > return 0; > } > > -static bool is_valid_bpf_tramp_flags(unsigned int flags) > -{ > - if ((flags & BPF_TRAMP_F_RESTORE_REGS) && > - (flags & BPF_TRAMP_F_SKIP_FRAME)) > - return false; > - > - /* > - * BPF_TRAMP_F_RET_FENTRY_RET is only used by bpf_struct_ops, > - * and it must be used alone. > - */ > - if ((flags & BPF_TRAMP_F_RET_FENTRY_RET) && > - (flags & ~BPF_TRAMP_F_RET_FENTRY_RET)) > - return false; > - > - return true; > -} > - > /* Example: > * __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev); > * its 'struct btf_func_model' will be nr_args=2 > @@ -2017,9 +2000,6 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *i > if (nr_args > 6) > return -ENOTSUPP; > > - if (!is_valid_bpf_tramp_flags(flags)) > - return -EINVAL; > - > /* Generated trampoline stack layout: > * > * RBP + 8 [ return address ] > diff --git a/kernel/bpf/bpf_struct_ops.c b/kernel/bpf/bpf_struct_ops.c > index d9a3c9207240..0572cc5aeb28 100644 > --- a/kernel/bpf/bpf_struct_ops.c > +++ b/kernel/bpf/bpf_struct_ops.c > @@ -341,6 +341,9 @@ int bpf_struct_ops_prepare_trampoline(struct bpf_tramp_links *tlinks, > > tlinks[BPF_TRAMP_FENTRY].links[0] = link; > tlinks[BPF_TRAMP_FENTRY].nr_links = 1; > + /* BPF_TRAMP_F_RET_FENTRY_RET is only used by bpf_struct_ops, > + * and it must be used alone. > + */ > flags = model->ret_size > 0 ? BPF_TRAMP_F_RET_FENTRY_RET : 0; > return arch_prepare_bpf_trampoline(NULL, image, image_end, > model, flags, tlinks, NULL); > diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c > index 93c7675f0c9e..bd3f2e673874 100644 > --- a/kernel/bpf/trampoline.c > +++ b/kernel/bpf/trampoline.c > @@ -358,6 +358,9 @@ static int bpf_trampoline_update(struct bpf_trampoline *tr) > > if (tlinks[BPF_TRAMP_FEXIT].nr_links || > tlinks[BPF_TRAMP_MODIFY_RETURN].nr_links) > + /* NOTE: BPF_TRAMP_F_RESTORE_REGS and BPF_TRAMP_F_SKIP_FRAME > + * should not be set together. > + */ > flags = BPF_TRAMP_F_CALL_ORIG | BPF_TRAMP_F_SKIP_FRAME; > > if (ip_arg) > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel