Re: [PATCH v10 00/14] vfio-user server in QEMU

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]

On Tue, May 24, 2022 at 11:30:19AM -0400, Jagannathan Raman wrote:
> Hi,
> 
> This is v10 of the server side changes to enable vfio-user in QEMU.
> 
> Thank you for reviewing and sharing your feedback for the previous
> revision. We have addressed your comments in this revision.
> 
> We have dropped the following patches in this series:
>   - tests/avocado: Specify target VM argument to helper routines
>   - configure: require cmake 3.19 or newer
>   - vfio-user: avocado tests for vfio-user
> 
> We have also made the following changes:
>   [PATCH v10 1/14] qdev: unplug blocker for devices
>     - updated functions comments for unplug blockers in hw/qdev-core.h
> 
>   [PATCH v10 4/14] vfio-user: build library
>     - uses meson build system to build libvfio-user library
>     - dropped ubuntu CI build
> 
>   [PATCH v10 5/14] vfio-user: define vfio-user-server object
>     - updated comments for VfioUserServerProperties in qapi/qom.json
> 
>   [PATCH v10 6/14] vfio-user: instantiate vfio-user context
>     - added comments to vfu_object_init_ctx() explaining function contract
> 
>   [PATCH v10 8/14] vfio-user: run vfio-user context
>     - vfu_object_ctx_run() asserts that VfuObject->device is not NULL
>     - added a comment to vfu_object_ctx_run() explaining why
>       VfuObject->device wouldn't be NULL
> 
> Thank you very much!

I'm happy with this series. I've asked Michael Tsirkin and Alex
Williamson to review the interrupt patch. Aside from that I think it's
time to merge and further work can be done in qemu.git.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]