From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Leonardo Bras" <leobras@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"Jagannathan Raman" <jag.raman@oracle.com>,
"John G Johnson" <john.g.johnson@oracle.com>,
"Juan Quintela" <quintela@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Fam Zheng" <fam@euphon.net>, "Peter Xu" <peterx@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v13 1/8] meson.build: Fix docker-test-build@alpine when including linux/errqueue.h
Date: Mon, 16 May 2022 13:51:43 +0100 [thread overview]
Message-ID: <YoJI34nIHXMjQDRi@work-vm> (raw)
In-Reply-To: <YoI3A9lybeUtPM2N@redhat.com>
* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Mon, May 16, 2022 at 12:30:15PM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrangé (berrange@redhat.com) wrote:
> > > On Mon, May 16, 2022 at 12:13:16PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Leonardo Bras (leobras@redhat.com) wrote:
> > > > > A build error happens in alpine CI when linux/errqueue.h is included
> > > > > in io/channel-socket.c, due to redefining of 'struct __kernel_timespec':
> > > >
> > > > OK, looks to be same mechanism as other meson tests.
> > >
> > > >
> > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > >
> > > As of about an hour or so ago, this patch should not be required.
> > >
> > > https://gitlab.alpinelinux.org/alpine/aports/-/issues/13813
> >
> > I'll take it anyway as protection against any other broken build envs.
>
> Can you update the commit message at least then.
Sure, I've added:
[dgilbert: This has been fixed in Alpine issue 13813 and liburing]
> The root casue trigger for the bug is the OS uses a busybox
I guess you mean musl??
> impl of mkdtemp, which isn't compat with the args liburing
> configure was previously using. I doubt there are many such OS
> around to be honest, as most will use coreutils.
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2022-05-16 13:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 6:28 [PATCH v13 0/8] MSG_ZEROCOPY + multifd Leonardo Bras
2022-05-13 6:28 ` [PATCH v13 1/8] meson.build: Fix docker-test-build@alpine when including linux/errqueue.h Leonardo Bras
2022-05-16 11:13 ` Dr. David Alan Gilbert
2022-05-16 11:17 ` Daniel P. Berrangé
2022-05-16 11:30 ` Dr. David Alan Gilbert
2022-05-16 11:35 ` Daniel P. Berrangé
2022-05-16 12:51 ` Dr. David Alan Gilbert [this message]
2022-05-16 14:04 ` Daniel P. Berrangé
2022-05-13 6:28 ` [PATCH v13 2/8] QIOChannel: Add flags on io_writev and introduce io_flush callback Leonardo Bras
2022-05-13 6:28 ` [PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX Leonardo Bras
2022-06-01 9:37 ` [External] " 徐闯
2022-06-01 13:58 ` Peter Xu
2022-06-08 5:37 ` Leonardo Bras Soares Passos
2022-06-08 11:41 ` Peter Xu
2022-06-08 18:14 ` Leonardo Bras Soares Passos
2022-06-08 20:23 ` Peter Xu
2022-06-13 20:58 ` Leonardo Bras Soares Passos
2022-06-13 22:53 ` Peter Xu
2022-06-14 3:14 ` Leonardo Bras Soares Passos
2022-06-08 5:24 ` Leonardo Bras Soares Passos
2022-06-08 6:48 ` chuang xu
2022-06-14 13:09 ` chuang xu
2022-06-14 14:14 ` Dr. David Alan Gilbert
2022-06-15 14:44 ` chuang xu
2022-05-13 6:28 ` [PATCH v13 4/8] migration: Add zero-copy-send parameter for QMP/HMP for Linux Leonardo Bras
2022-05-13 6:28 ` [PATCH v13 5/8] migration: Add migrate_use_tls() helper Leonardo Bras
2022-05-13 6:28 ` [PATCH v13 6/8] multifd: multifd_send_sync_main now returns negative on error Leonardo Bras
2022-05-13 6:28 ` [PATCH v13 7/8] multifd: Send header packet without flags if zero-copy-send is enabled Leonardo Bras
2022-05-13 6:28 ` [PATCH v13 8/8] multifd: Implement zero copy write in multifd migration (multifd-zero-copy) Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoJI34nIHXMjQDRi@work-vm \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=fam@euphon.net \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.