All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Marcos Scriven <marcos@scriven.org>, linux-nvme@lists.infradead.org
Subject: Re: My Western Digital SN850 appears to suffer from deep power state issues - considering submitting quirk patch.
Date: Mon, 16 May 2022 10:58:57 -0700	[thread overview]
Message-ID: <YoKQ4YHKEZxd8C2N@infradead.org> (raw)
In-Reply-To: <YoFYIJ3/yEK1RGTK@kbusch-mbp>

On Sun, May 15, 2022 at 01:44:32PM -0600, Keith Busch wrote:
> Some of the behavior you're describing has been isolated to specific
> drive+platform combinations in the past, but let's hear your results from the
> follow up experiements before considering if we need to introduce a dmi
> type quirk.

Also, are we even sure this is related to power states?

>  
> > Anyway, with all that background, I'm happy to try NVME_QUIRK_NO_DEEPEST_PS for 15b7:5011 locally, and submit here if it works.
> 
> I think that's worth trying. Alternatively, you could just mess with the
> module's param 'nvme_core.default_ps_max_latency_us' value and see if only the
> deepest states or if any low power state is problematic.

Maybe even just nvme_core.default_ps_max_latency_us=0 to verify it
really is power state related as a start.


  parent reply	other threads:[~2022-05-16 17:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15 16:00 My Western Digital SN850 appears to suffer from deep power state issues - considering submitting quirk patch Marcos Scriven
2022-05-15 19:44 ` Keith Busch
2022-05-15 20:13   ` Keith Busch
2022-05-16 17:58   ` Christoph Hellwig [this message]
2022-05-19 10:14     ` Marcos Scriven
2022-05-19 20:02       ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoKQ4YHKEZxd8C2N@infradead.org \
    --to=hch@infradead.org \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=marcos@scriven.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.