From: Hangbin Liu <liuhangbin@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 0/2] selftests: net: add missing tests to Makefile
Date: Tue, 17 May 2022 14:23:22 +0800 [thread overview]
Message-ID: <YoM/Wr6FaTzgokx3@Laptop-X1> (raw)
In-Reply-To: <20220429175604.249bb2fb@kernel.org>
On Fri, Apr 29, 2022 at 05:56:04PM -0700, Jakub Kicinski wrote:
> On Thu, 28 Apr 2022 12:45:09 +0800 Hangbin Liu wrote:
> > I think there need a way to notify the developer when they created a new
> > file in selftests folder. Maybe a bot like bluez.test.bot or kernel
> > test robot could help do that?
>
> Our netdev patch checks are here:
>
> https://github.com/kuba-moo/nipa/tree/master/tests/patch
>
> in case you're willing to code it up and post a PR.
Hi Jakub,
I checked the tools and write a draft patch. But I have a question before post
the PR. AFAIK, This bot is only used for checking patches and adding status in
patchwork. But it doesn't support sending a reply to developer, right?
For the selftest reminder, I think it would be good to let developer know
via email if the file is missing in Makefile. What do you think?
Here is the draft patch:
diff --git a/tests/patch/check_selftest/check_selftest.sh b/tests/patch/check_selftest/check_selftest.sh
new file mode 100755
index 0000000..ad7c608
--- /dev/null
+++ b/tests/patch/check_selftest/check_selftest.sh
@@ -0,0 +1,28 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+
+rt=0
+if ! git show --name-status --oneline | \
+ grep -P '^A\ttools/testing/selftests/net/' | \
+ grep '\.sh$'; then
+ echo "No new net selftests script" >&$DESC_FD
+ exit 0
+fi
+
+files=$(git show --name-status --oneline | grep -P '^A\ttools/testing/selftests/net/' | grep '\.sh$' | sed 's@A\ttools/testing/selftests/net/@@')
+for file in $files; do
+ if echo $file | grep forwarding; then
+ file=$(echo $file | sed 's/forwarding\///')
+ if ! grep -P "[\t| ]$file" tools/testing/selftests/net/forwarding/Makefile;then
+ echo "new test $file not in selftests/net/forwarding/Makefile" >&$DESC_FD
+ rc=1
+ fi
+ else
+ if ! grep -P "[\t| ]$file" tools/testing/selftests/net/Makefile;then
+ echo "new test $file not in selftests/net/Makefile" >&$DESC_FD
+ rc=1
+ fi
+ fi
+done
+
+exit $rc
diff --git a/tests/patch/check_selftest/info.json b/tests/patch/check_selftest/info.json
new file mode 100644
index 0000000..615779f
--- /dev/null
+++ b/tests/patch/check_selftest/info.json
@@ -0,0 +1,3 @@
+{
+ "run": ["check_selftest.sh"]
+}
--
2.35.1
next prev parent reply other threads:[~2022-05-17 6:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 4:45 [PATCH net 0/2] selftests: net: add missing tests to Makefile Hangbin Liu
2022-04-28 4:45 ` [PATCH net 1/2] selftests/net: " Hangbin Liu
2022-04-28 4:45 ` [PATCH net 2/2] selftests/net/forwarding: " Hangbin Liu
2022-04-30 0:56 ` [PATCH net 0/2] selftests: net: " Jakub Kicinski
2022-05-04 3:00 ` Hangbin Liu
2022-05-17 6:23 ` Hangbin Liu [this message]
2022-05-17 19:45 ` Jakub Kicinski
2022-05-18 6:01 ` Hangbin Liu
2022-05-18 15:25 ` Jakub Kicinski
2022-05-19 3:13 ` Hangbin Liu
2022-04-30 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoM/Wr6FaTzgokx3@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.