Re: [PATCH -next] block: fix io hung of setting throttle limit frequently

From: Tejun Heo <tj@kernel.org>
To: "yukuai (C)" <yukuai3@huawei.com>
Cc: Zhang Wensheng <zhangwensheng5@huawei.com>,
	"ming.lei@redhat.com >> Ming Lei" <ming.lei@redhat.com>,
	axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH -next] block: fix io hung of setting throttle limit frequently
Date: Mon, 16 May 2022 18:18:44 -1000	[thread overview]
Message-ID: <YoMiJIUehq1UyzgQ@slm.duckdns.org> (raw)
In-Reply-To: <ca251645-8d52-7a93-6ac2-579d97922a9e@huawei.com>

On Tue, May 17, 2022 at 11:12:28AM +0800, yukuai (C) wrote:
> Ming added a condition in tg_with_in_bps_limit():
> -       if (bps_limit == U64_MAX) {
> +       /* no need to throttle if this bio's bytes have been accounted */
> +       if (bps_limit == U64_MAX || bio_flagged(bio, BIO_THROTTLED)) {
> 
> Which will let the first throttled bio to be issued immediately once
> the config if updated.
> 
> Do you think this behaviour is OK? If so, we can do the same for
> tg_with_in_iops_limit.

So, the current behavior is that if the user is being silly, it will get
slower and slower. The new behavior would be that if the user is being
silly, it can issue IOs faster and faster, which creates a perverse
incentive to be silly.

Probably the right thing to do is probably something like translating the
existing budget in light of the new configuration so that config change
neither gives or takes away the budget which has already accumulated. That
said, are you guys seeing this becoming an issue in practice?

Thanks.

-- 
tejun