From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6333AC433F5 for ; Wed, 18 May 2022 06:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231495AbiERGo4 (ORCPT ); Wed, 18 May 2022 02:44:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231247AbiERGoy (ORCPT ); Wed, 18 May 2022 02:44:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EF2A56771 for ; Tue, 17 May 2022 23:44:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9C9E760B59 for ; Wed, 18 May 2022 06:44:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3902BC385A9; Wed, 18 May 2022 06:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652856293; bh=txZ4z5P32rfkA6Qk2rJ6GxCKmY0Sp1SypywZSzeV0iM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IyNzP+QXv4E8NGBYrVExSrcrfy/AG8MOTmHfU+SHQWuxtDlZCyH8MRidSFNd30g0G yNFoGkGvDEYKh4D8r20z1KlSqQH7bSAU1cbKBujM3QGMHrzy399hmoHskSMm4/fu5G OmEopLm7xURtxDkTQdP6EcwYFHRjjUQA8OkBk6mE= Date: Wed, 18 May 2022 08:44:48 +0200 From: Greg KH To: Kohei Tarumizu Cc: catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, mchehab+huawei@kernel.org, eugenis@google.com, tony.luck@intel.com, pcc@google.com, peterz@infradead.org, marcos@orca.pet, conor.dooley@microchip.com, nicolas.ferre@microchip.com, marcan@marcan.st, linus.walleij@linaro.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 6/8] x86: Add hardware prefetch control support for x86 Message-ID: References: <20220518063032.2377351-1-tarumizu.kohei@fujitsu.com> <20220518063032.2377351-7-tarumizu.kohei@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518063032.2377351-7-tarumizu.kohei@fujitsu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 03:30:30PM +0900, Kohei Tarumizu wrote: > Adds module init/exit code to create sysfs attributes for x86 with > "hardware_prefetcher_enable", "ip_prefetcher_enable" and > "adjacent_cache_line_prefetcher_enable". > > This driver works only if a CPU model is mapped to type of register > specification(e.g. TYPE_L12_BASE) in pfctl_match[]. How will the driver be automatically loaded if this is the case or not? You can not rely on userspace knowing to load a driver on its own, please tie into the proper device discovery. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E695C433F5 for ; Wed, 18 May 2022 06:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SBt3tQo7R39eRqyWmRMpDdQEFT70xIvLDL6t5WjQAfM=; b=t2hIHVINtqTCM1 wjJBsUguT+C1Pr7RKGIbWxLQ+7IlQgx/U2RAAuYxlQpIb4LAzVAimEKAZpBQZQBbYbUfke+ZxjPdL cSdE8ilI+MOWp4DVgCNHvBrNdVq6VSjqNDZy6Fmh/fNkgaIYuXAslyQwqHsy/fRQPZbIZmxNKoUYn gbtnW6Ot38B8tFiIio00O7GWJmxPZM2wr7AILp7v+zQMxdBNf/OdOAeZCmI/WuBzQx+3W2/dNBzrP IzZMAh4987GO2yzxVgcugKZipIG5pRCKDyAy8irI1l3LerXVvNs3QvmodeET4NjZBXaDvJ5nVsB6t gmCkCE2r2GXb9FXwwRug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDQZ-00HSXo-2W; Wed, 18 May 2022 06:44:59 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDQV-00HSVk-Hu for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 06:44:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 37D52B81E90; Wed, 18 May 2022 06:44:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3902BC385A9; Wed, 18 May 2022 06:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652856293; bh=txZ4z5P32rfkA6Qk2rJ6GxCKmY0Sp1SypywZSzeV0iM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IyNzP+QXv4E8NGBYrVExSrcrfy/AG8MOTmHfU+SHQWuxtDlZCyH8MRidSFNd30g0G yNFoGkGvDEYKh4D8r20z1KlSqQH7bSAU1cbKBujM3QGMHrzy399hmoHskSMm4/fu5G OmEopLm7xURtxDkTQdP6EcwYFHRjjUQA8OkBk6mE= Date: Wed, 18 May 2022 08:44:48 +0200 From: Greg KH To: Kohei Tarumizu Subject: Re: [PATCH v4 6/8] x86: Add hardware prefetch control support for x86 Message-ID: References: <20220518063032.2377351-1-tarumizu.kohei@fujitsu.com> <20220518063032.2377351-7-tarumizu.kohei@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220518063032.2377351-7-tarumizu.kohei@fujitsu.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220517_234455_791745_532DD1CB X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rafael@kernel.org, peterz@infradead.org, catalin.marinas@arm.com, linus.walleij@linaro.org, dave.hansen@linux.intel.com, conor.dooley@microchip.com, hpa@zytor.com, will@kernel.org, mchehab+huawei@kernel.org, x86@kernel.org, mingo@redhat.com, eugenis@google.com, arnd@arndb.de, bp@alien8.de, tglx@linutronix.de, pcc@google.com, linux-arm-kernel@lists.infradead.org, marcos@orca.pet, tony.luck@intel.com, marcan@marcan.st, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 03:30:30PM +0900, Kohei Tarumizu wrote: > Adds module init/exit code to create sysfs attributes for x86 with > "hardware_prefetcher_enable", "ip_prefetcher_enable" and > "adjacent_cache_line_prefetcher_enable". > > This driver works only if a CPU model is mapped to type of register > specification(e.g. TYPE_L12_BASE) in pfctl_match[]. How will the driver be automatically loaded if this is the case or not? You can not rely on userspace knowing to load a driver on its own, please tie into the proper device discovery. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel