From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39485C433EF for ; Wed, 18 May 2022 07:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231862AbiERHE7 (ORCPT ); Wed, 18 May 2022 03:04:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231805AbiERHE4 (ORCPT ); Wed, 18 May 2022 03:04:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 933A3985AD for ; Wed, 18 May 2022 00:04:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 513A3B81E9B for ; Wed, 18 May 2022 07:04:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85C4AC385A5; Wed, 18 May 2022 07:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652857493; bh=5/SVsqjHtSz5a25oyFP2C2XiAM7dJCptaoUIfgrtXDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sWw3wk+yMKhbEONY1F/y8qGpl/BwzUVdexM1njLQMEgLiXxY4+mUMrZ1As5X/Mnv1 +kZAV7pQ/zQ7FDrP3EuH/NazlpUs661Ge8h5LH5Tf0wDIM8vRiCN7+2WRwPMrgoAQn 44T1z4qccxjiIcLBR4T5qqKeIsuWMbDKITQP/GU4= Date: Wed, 18 May 2022 09:04:44 +0200 From: Greg KH To: Kohei Tarumizu Cc: catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, mchehab+huawei@kernel.org, eugenis@google.com, tony.luck@intel.com, pcc@google.com, peterz@infradead.org, marcos@orca.pet, conor.dooley@microchip.com, nicolas.ferre@microchip.com, marcan@marcan.st, linus.walleij@linaro.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/8] drivers: base: Add Kconfig/Makefile to build hardware prefetch control core driver Message-ID: References: <20220518063032.2377351-1-tarumizu.kohei@fujitsu.com> <20220518063032.2377351-3-tarumizu.kohei@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220518063032.2377351-3-tarumizu.kohei@fujitsu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 03:30:26PM +0900, Kohei Tarumizu wrote: > Adds Kconfig/Makefile to build hardware prefetch control core driver, > and also adds a MAINTAINERS entry. > > Signed-off-by: Kohei Tarumizu > --- > MAINTAINERS | 6 ++++++ > drivers/base/Kconfig | 9 +++++++++ > drivers/base/Makefile | 1 + > 3 files changed, 16 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6d879cb0afd..f188403bc2e9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8620,6 +8620,12 @@ F: include/linux/hwmon*.h > F: include/trace/events/hwmon*.h > K: (devm_)?hwmon_device_(un)?register(|_with_groups|_with_info) > > +HARDWARE PREFETCH CONTROL DRIVERS > +M: Kohei Tarumizu > +S: Maintained > +F: drivers/base/pfctl.c > +F: include/linux/pfctl.h > + > HARDWARE RANDOM NUMBER GENERATOR CORE > M: Matt Mackall > M: Herbert Xu > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 6f04b831a5c0..8f8a69e7f645 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -230,4 +230,13 @@ config GENERIC_ARCH_NUMA > Enable support for generic NUMA implementation. Currently, RISC-V > and ARM64 use it. > > +config HWPF_CONTROL Shouldn't this have "GENERIC" in the name liks the other generic implementations in this directory? > + bool "Hardware Prefetch Control driver" > + help > + This driver allows user to control CPU's Hardware Prefetch behavior. > + If the machine supports this behavior, it provides a sysfs interface. But this is not a driver, it's a core function that a driver uses. On its own, this code does nothing. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5412C433F5 for ; Wed, 18 May 2022 07:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g5uIJo6jgpkfeBbF4CtzPA+ozS8dYLY9Lh+KdJEjdlg=; b=IB6QAKDthZdnXK tWv4EA++Xkg1kOeiGMqGEd5X8WGbNDOwFWyRGJkITY6BiTwEkZNELH1qpjrT7hweXZmQFlBUfV7Es P4FswGs8d53oYq1NmeXofS1vuNnCUBmqIAwqHppKh1LxJ0Bt99JcgBQLHI7xBF6gSG0ZorxYfichv KUSTQjoOVRHdBAYYQ1X+k0N8tEPMZpCH+HuSTTBzzAvf0NUxbpkkNDoLGIj7SfWQ7/QksyuZeUqkj 8UhgVpiQ8Lp8X1lhF90R4GAMCegYReK+LHjh75stxJo2ZcrIAuGul3rsU0ZQsog51LXQCYNyrB9D2 fg+WVi8L1SvnZEVB9Keg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDjt-00HY2u-Kx; Wed, 18 May 2022 07:04:57 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDjq-00HY1Y-Dr for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 07:04:55 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AAB0360FDA; Wed, 18 May 2022 07:04:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85C4AC385A5; Wed, 18 May 2022 07:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1652857493; bh=5/SVsqjHtSz5a25oyFP2C2XiAM7dJCptaoUIfgrtXDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sWw3wk+yMKhbEONY1F/y8qGpl/BwzUVdexM1njLQMEgLiXxY4+mUMrZ1As5X/Mnv1 +kZAV7pQ/zQ7FDrP3EuH/NazlpUs661Ge8h5LH5Tf0wDIM8vRiCN7+2WRwPMrgoAQn 44T1z4qccxjiIcLBR4T5qqKeIsuWMbDKITQP/GU4= Date: Wed, 18 May 2022 09:04:44 +0200 From: Greg KH To: Kohei Tarumizu Subject: Re: [PATCH v4 2/8] drivers: base: Add Kconfig/Makefile to build hardware prefetch control core driver Message-ID: References: <20220518063032.2377351-1-tarumizu.kohei@fujitsu.com> <20220518063032.2377351-3-tarumizu.kohei@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220518063032.2377351-3-tarumizu.kohei@fujitsu.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_000454_534029_B61F28FF X-CRM114-Status: GOOD ( 18.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rafael@kernel.org, peterz@infradead.org, catalin.marinas@arm.com, linus.walleij@linaro.org, dave.hansen@linux.intel.com, conor.dooley@microchip.com, hpa@zytor.com, will@kernel.org, mchehab+huawei@kernel.org, x86@kernel.org, mingo@redhat.com, eugenis@google.com, arnd@arndb.de, bp@alien8.de, tglx@linutronix.de, pcc@google.com, linux-arm-kernel@lists.infradead.org, marcos@orca.pet, tony.luck@intel.com, marcan@marcan.st, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 18, 2022 at 03:30:26PM +0900, Kohei Tarumizu wrote: > Adds Kconfig/Makefile to build hardware prefetch control core driver, > and also adds a MAINTAINERS entry. > > Signed-off-by: Kohei Tarumizu > --- > MAINTAINERS | 6 ++++++ > drivers/base/Kconfig | 9 +++++++++ > drivers/base/Makefile | 1 + > 3 files changed, 16 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6d879cb0afd..f188403bc2e9 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8620,6 +8620,12 @@ F: include/linux/hwmon*.h > F: include/trace/events/hwmon*.h > K: (devm_)?hwmon_device_(un)?register(|_with_groups|_with_info) > > +HARDWARE PREFETCH CONTROL DRIVERS > +M: Kohei Tarumizu > +S: Maintained > +F: drivers/base/pfctl.c > +F: include/linux/pfctl.h > + > HARDWARE RANDOM NUMBER GENERATOR CORE > M: Matt Mackall > M: Herbert Xu > diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig > index 6f04b831a5c0..8f8a69e7f645 100644 > --- a/drivers/base/Kconfig > +++ b/drivers/base/Kconfig > @@ -230,4 +230,13 @@ config GENERIC_ARCH_NUMA > Enable support for generic NUMA implementation. Currently, RISC-V > and ARM64 use it. > > +config HWPF_CONTROL Shouldn't this have "GENERIC" in the name liks the other generic implementations in this directory? > + bool "Hardware Prefetch Control driver" > + help > + This driver allows user to control CPU's Hardware Prefetch behavior. > + If the machine supports this behavior, it provides a sysfs interface. But this is not a driver, it's a core function that a driver uses. On its own, this code does nothing. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel