From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DD0C433EF for ; Wed, 18 May 2022 08:05:06 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C51740156; Wed, 18 May 2022 10:05:05 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 04265400D6 for ; Wed, 18 May 2022 10:05:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652861103; x=1684397103; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=x7auyprtSNEBELsciFLh5KdJCdywcomABYJcqwHCaTY=; b=DnVr4i7agKaJDU2uAHVQ3PWGwfsYsodU6HzxWy8aZX1FH6ZuXg1c2jrw Xb4QfPuMZFoGXPIR7jETwOkQXDpe4OxljfTmqEbSUlfoKo8Wa9YyhbJvc JwNJn4ZIFoK1WcTo52b3/nBbVeHkD7xcWDzdXMxNaivPjhK1Gb1GF+DOI q5oIHQDCBmK+ozteMpXSp4lR5jvYfGULG5qofgmdw5SzbfNTln8weLoAj 8jnq0BjGgW4qvXkItALdbL2oae8vxqtY8G+/pXk0GbCQVAEEybCB7bTG1 I8dxXMTNNaF7+ZBx36/pql/rJQTTojRRXHJZyhWwEvNi8yffkFfAh7nQL A==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="271493248" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="271493248" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 01:05:02 -0700 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="597634403" Received: from cjokeeff-mobl1.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.3.104]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 May 2022 01:05:01 -0700 Date: Wed, 18 May 2022 09:04:57 +0100 From: Bruce Richardson To: Kai Ji Cc: dev@dpdk.org, roy.fan.zhang@intel.com Subject: Re: [dpdk-dev v2 1/2] build: add in option for qat use intel ipsec-mb lib Message-ID: References: <20220407152931.8771-1-roy.fan.zhang@intel.com> <20220517141652.53769-1-kai.ji@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220517141652.53769-1-kai.ji@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 17, 2022 at 10:16:51PM +0800, Kai Ji wrote: > Add in build option for QAT pmd use intel ipsec-mb lib > instead openssl for precompute partial hash & aes. > > Signed-off-by: Kai Ji > --- > drivers/common/qat/meson.build | 12 ++++++++++++ > meson_options.txt | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/common/qat/meson.build b/drivers/common/qat/meson.build > index b7027f3164..d6eaff3e0e 100644 > --- a/drivers/common/qat/meson.build > +++ b/drivers/common/qat/meson.build > @@ -35,6 +35,18 @@ if qat_crypto and not libcrypto.found() > 'missing dependency, libcrypto') > endif > > +if get_option('qat_libipsecmb') > + IMB_required_ver = '1.0.0' > + libipsecmb = cc.find_library('IPSec_MB', required: false) > + if not lib.found() > + build = false > + reason = 'missing dependency, "libIPSec_MB"' > + else > + ext_deps += libipsecmb > + dpdk_conf.set('RTE_QAT_LIBIPSECMB', true) > + endif > +endif > + In general it's not a good idea for individual drivers to add top-level meson.build options. If every driver does this for all its options we will have an unmanageable set of hundreds of options. Unfortunately, though, I don't see a really good way to replace this with something other than a build option - I assume it's not just good enough to check which of the dependencies is found/not-found? Is there some way that this can be a generic option, that may be applicable to other drivers? Could the option be instead to prioritize FIPs compatibility? /Bruce