All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
To: Derald Woods <woods.technical@gmail.com>
Cc: Tom Rini <trini@konsulko.com>,
	U-Boot Mailing List <u-boot@lists.denx.de>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning
Date: Wed, 18 May 2022 10:21:52 +0200	[thread overview]
Message-ID: <YoSsoPX80pQkW8/y@gmail.com> (raw)
In-Reply-To: <CA+CtpRi0nE-xkWpwrPExysuUgFLmgreRhkre-Z6NfKpjL8xgbw@mail.gmail.com>

On Sun, May 15, 2022 at 01:58:37PM -0500, Derald Woods wrote:
>On Sun, May 15, 2022 at 9:01 AM Tom Rini <trini@konsulko.com> wrote:
>
>> On Sun, May 15, 2022 at 03:38:21PM +0200, Anthoine Bourgeois wrote:
>>
>> > Seems that u-boot can't probe i2c bus at 2.6Mhz speed, so lower
>> > the speed to the default value 100Khz.
>> >
>> > Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@gmail.com>
>> > ---
>> >  arch/arm/dts/omap3-devkit8000.dts | 2 +-
>> >  configs/devkit8000_defconfig      | 1 +
>> >  2 files changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/arch/arm/dts/omap3-devkit8000.dts
>> b/arch/arm/dts/omap3-devkit8000.dts
>> > index eee3ba073b..9cd3708d95 100644
>> > --- a/arch/arm/dts/omap3-devkit8000.dts
>> > +++ b/arch/arm/dts/omap3-devkit8000.dts
>> > @@ -115,7 +115,7 @@
>> >  };
>> >
>> >  &i2c1 {
>> > -     clock-frequency = <2600000>;
>> > +     clock-frequency = <100000>;
>> >
>> >       twl: twl@48 {
>> >               reg = <0x48>;
>>
>> Thanks for updating these platforms.  Can we override this in the
>> -u-boot.dtsi file?
>>
>> --
>> Tom
>>
>
>$ grep -RI "clock-frequency = <2600000>" .
>./arch/arm/dts/logicpd-torpedo-som.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-igep.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-beagle.dts: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-evm-common.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/logicpd-som-lv.dtsi: clock-frequency = <2600000>;
>./arch/arm/dts/omap3-beagle-xm.dts: clock-frequency = <2600000>;
>
>All of these would benefit.

Yes, good idea, this is in v2.

--
Anthoine

  reply	other threads:[~2022-05-18  8:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15 13:38 [PATCH 1/3] ARM: dts: omap3-devkit8000: Add support for Devkit8000 Anthoine Bourgeois
2022-05-15 13:38 ` [PATCH 2/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_I2C warning Anthoine Bourgeois
2022-05-15 14:00   ` Tom Rini
2022-05-15 18:58     ` Derald Woods
2022-05-18  8:21       ` Anthoine Bourgeois [this message]
2022-05-15 13:38 ` [PATCH 3/3] ARM: dts: omap3-devkit8000: Fix CONFIG_DM_ETH warning Anthoine Bourgeois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoSsoPX80pQkW8/y@gmail.com \
    --to=anthoine.bourgeois@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=woods.technical@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.