From: Heiko Carstens <hca@linux.ibm.com>
To: Steffen Eiden <seiden@linux.ibm.com>
Cc: Greg KH <greg@kroah.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Shuah Khan <shuah@kernel.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Nico Boehr <nrb@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v4 1/2] drivers/s390/char: Add Ultravisor io device
Date: Wed, 18 May 2022 13:47:18 +0200 [thread overview]
Message-ID: <YoTcxhulemnqiUbC@osiris> (raw)
In-Reply-To: <20220510144724.3321985-2-seiden@linux.ibm.com>
On Tue, May 10, 2022 at 02:47:23PM +0000, Steffen Eiden wrote:
> diff --git a/drivers/s390/char/Kconfig b/drivers/s390/char/Kconfig
> index 6cc4b19acf85..e9b9902abbaf 100644
> --- a/drivers/s390/char/Kconfig
> +++ b/drivers/s390/char/Kconfig
> @@ -100,6 +100,16 @@ config SCLP_OFB
> This option enables the Open-for-Business interface to the s390
> Service Element.
>
> +config S390_UV_UAPI
> + def_tristate y
> + prompt "Ultravisor userspace API"
> + help
> + Selecting exposes parts of the UV interface to userspace
> + by providing a misc character device at /dev/uv.
> + Using IOCTLs one can interact with the UV.
> + The device is only available if the Ultravisor
> + Facility (158) is present.
Is there a reason why this is default "y"? If you think this should be
compiled into the kernel if used, then why allow to make it a module
at all?
Instead you could get rid of a couple if lines of code.
next prev parent reply other threads:[~2022-05-18 11:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 14:47 [PATCH v4 0/2] s390: Ultravisor device Steffen Eiden
2022-05-10 14:47 ` [PATCH v4 1/2] drivers/s390/char: Add Ultravisor io device Steffen Eiden
2022-05-12 14:33 ` Claudio Imbrenda
2022-05-13 7:45 ` Steffen Eiden
2022-05-13 8:37 ` Claudio Imbrenda
2022-05-13 12:35 ` Steffen Eiden
2022-05-16 11:33 ` Steffen Eiden
2022-05-16 14:51 ` Claudio Imbrenda
2022-05-17 8:38 ` Janosch Frank
2022-05-17 8:42 ` Steffen Eiden
2022-05-17 12:41 ` Janosch Frank
2022-05-18 11:47 ` Heiko Carstens [this message]
2022-05-18 13:45 ` Janosch Frank
2022-05-18 13:49 ` Steffen Eiden
2022-05-19 5:37 ` Heiko Carstens
2022-05-19 9:13 ` Janosch Frank
2022-05-10 14:47 ` [PATCH v4 2/2] selftests: drivers/s390x: Add uvdevice tests Steffen Eiden
2022-05-21 13:53 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoTcxhulemnqiUbC@osiris \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=greg@kroah.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=seiden@linux.ibm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.