All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Zhang Jianhua <chris.zjh@huawei.com>
Cc: tytso@mit.edu, linux-fscrypt@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fs-verity: remove unused parameter desc_size in fsverity_create_info()
Date: Wed, 18 May 2022 11:05:12 -0700	[thread overview]
Message-ID: <YoU1WP8c0n6AlYGM@sol.localdomain> (raw)
In-Reply-To: <20220518132256.2297655-1-chris.zjh@huawei.com>

On Wed, May 18, 2022 at 09:22:56PM +0800, Zhang Jianhua wrote:
> The parameter desc_size in fsverity_create_info() is useless and it is
> not referenced anywhere. The greatest meaning of desc_size here is to
> indecate the size of struct fsverity_descriptor and futher calculate the
> size of signature. However, the desc->sig_size can do it also and it is
> indeed, so remove it.
> 
> Therefore, it is no need to acquire desc_size by fsverity_get_descriptor()
> in ensure_verity_info(), so remove the parameter desc_ret in
> fsverity_get_descriptor() too.
> 
> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
> ---
>  fs/verity/enable.c           |  2 +-
>  fs/verity/fsverity_private.h |  6 ++----
>  fs/verity/open.c             | 12 ++++--------
>  fs/verity/read_metadata.c    |  5 ++---
>  4 files changed, 9 insertions(+), 16 deletions(-)

Applied, thanks!

- Eric

      reply	other threads:[~2022-05-18 18:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 13:22 [PATCH -next] fs-verity: remove unused parameter desc_size in fsverity_create_info() Zhang Jianhua
2022-05-18 18:05 ` Eric Biggers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoU1WP8c0n6AlYGM@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=chris.zjh@huawei.com \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.