All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: dan.carpenter@oracle.com, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	mturquette@baylibre.com, paul@crapouillou.net,
	robh+dt@kernel.org, tsbogend@alpha.franken.de
Subject: Re: [PATCH v5 2/2] clk: ingenic-tcu: Fix missing TCU clock for X1000 SoCs
Date: Thu, 19 May 2022 00:02:48 +0100	[thread overview]
Message-ID: <YoV7GKiaosmX6QnQ@localhost> (raw)
In-Reply-To: <20220518204734.89090C34113@smtp.kernel.org>

On Wed, May 18, 2022 at 01:47:32PM -0700, Stephen Boyd wrote:
> Quoting Aidan MacDonald (2022-04-12 05:27:50)
> > The TCU clock gate on X1000 wasn't requested by the driver and could
> > be gated automatically later on in boot, which prevents timers from
> > running and breaks PWM.
> > 
> > Add a workaround to support old device trees that don't specify the
> > "tcu" clock gate. In this case the kernel will print a warning and
> > attempt to continue without the clock, which is wrong, but it could
> > work if "clk_ignore_unused" is in the kernel arguments.
> > 
> > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> > ---
> 
> Can I take just this one patch through clk tree without the dts part?
> dts snippets go through soc trees.

Yeah. The patches can go through in any order but they both need to be
merged to fix the bug -- each on its own should not change any behavior.

Regards,
Aidan

  reply	other threads:[~2022-05-18 23:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12 12:27 [PATCH v5 0/2] Fix missing TCU clock for X1000/X1830 SoCs Aidan MacDonald
2022-04-12 12:27 ` [PATCH v5 1/2] mips: dts: ingenic: Add TCU clock to x1000/x1830 tcu device node Aidan MacDonald
2022-04-12 22:38   ` Paul Cercueil
2022-04-12 12:27 ` [PATCH v5 2/2] clk: ingenic-tcu: Fix missing TCU clock for X1000 SoCs Aidan MacDonald
2022-04-12 22:39   ` Paul Cercueil
2022-05-18 20:47   ` Stephen Boyd
2022-05-18 23:02     ` Aidan MacDonald [this message]
2022-05-19  0:31   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoV7GKiaosmX6QnQ@localhost \
    --to=aidanmacdonald.0x0@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=paul@crapouillou.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.