From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 425A028EE for ; Thu, 19 May 2022 15:49:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8D1DC34100; Thu, 19 May 2022 15:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652975356; bh=wRDcSZWRg8F5GYZDzBv0ctTZeIUjFAPm7X9uhNSHFwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E8aho+U1muOFpeLWM0FXTi1BWNJEHPMiiyTsSAWPRXoUVn1W9kxdpb8bXWeIqCP0I RgySRFIxpxZGCW+dFeItge4EvYalvRZEg0Cgh0g3od/B0mM9C5I5gHZxlp3zS17szb c5bkgEdd4USnWPTmdrMaQUniW6zDIP6hlmCflaZ35MN1XW370dVNykwsOXVvWL22FT LPl+JL6xj6Fyb+tKDiJN1n9dKwO/T5SCnvCYdekG5eGwwI2FfmR4WyoLQnjiwCQX7B d5cy4ncvffbet63U7dI+bWul3B8lva2Z7pt5x6u6iRvg0XRh4RMHtCp5trBWkacZsd VkXTDxeVKlNHw== Date: Thu, 19 May 2022 16:49:09 +0100 From: Mark Brown To: Andrew Lunn Cc: Krzysztof Kozlowski , Corentin Labbe , calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Message-ID: References: <20220518200939.689308-1-clabbe@baylibre.com> <20220518200939.689308-5-clabbe@baylibre.com> <95f3f0a4-17e6-ec5f-6f2f-23a5a4993a44@linaro.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jOI5UhwGK68KoNhN" Content-Disposition: inline In-Reply-To: X-Cookie: Some restrictions may apply. --jOI5UhwGK68KoNhN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote: > On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote: > > On 19/05/2022 13:31, Mark Brown wrote: > > > On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote: > > >> On 18/05/2022 22:09, Corentin Labbe wrote: > > >>> + regulators: > > >>> + description: > > >>> + List of phandle to regulators needed for the PHY > > >> I don't understand that... is your PHY defining the regulators or using > > >> supplies? If it needs a regulator (as a supply), you need to document > > >> supplies, using existing bindings. > > > They're trying to have a generic driver which works with any random PHY > > > so the binding has no idea what supplies it might need. > > OK, that makes sense, but then question is why not using existing > > naming, so "supplies" and "supply-names"? > I'm not saying it is not possible, but in general, the names are not > interesting. All that is needed is that they are all on, or > potentially all off to save power on shutdown. We don't care how many > there are, or what order they are enabled. I think Krzysztof is referring to the name of the property rather than the contents of the -names property there. --jOI5UhwGK68KoNhN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKGZvQACgkQJNaLcl1U h9BKbAf+IovUQ3DSAoKJdf32JsgeB+o/vNXD8MscsyZm5JvIVj5BOLWLb1emeGJP Yp3omFPSMOvlsZtrBEx7Fk4MO/Rt0zWemfEcHAfnPI2yPp0LVZLBEqStTWeQQHab DdrMZrX6CDbQojP0q4eYGt24OF/dMIYThDp7XU4GDH4Sy7KXD5SpYGuR5Pe9F2Uy KZ/25LSM7z8oKUaMHCx21nUm1bHXbuBiP46PKEX4aiSJ1f+S5WhdlC4PI0ZnUMis iC00xj4guPTArs7K9DX8y4AwrjlMOogR5Nqwkl5c8xiZQs2lsMI/HfnctaUdiIe9 qBKP7Eyse3kVuq04h+CQHDUYTCrBIQ== =ZhuD -----END PGP SIGNATURE----- --jOI5UhwGK68KoNhN-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76BAFC433F5 for ; Thu, 19 May 2022 15:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Kl/7PYSUxaZcm+XLX7g+upJcWg4aYvj23LeLkc70oO4=; b=y0QGE1/L3AU31Ag8DV5FaVVdGl qho7rss7fSSICsJ+gdLsMZz952kIzmocVJKRcVVSXE6VN4euy7RvYw3TwwIfCio9EFrahWHit2pCh cmjGnDHmOSY/UQh8zElDoncGEbKz38Ckk6XdGnFJ/G7Q2GR+mUnT2dgrhQZ6z9TkLrCiYkDBdW64n dHjy5Mqxw9XBPecdqjSzF2/p4+KsTOXqAexQQB+N6VzTZLuRcz4k5XcU4tQJnw4bLDWU9ojFRLs4P /L9lu7ohdQsUhZ6ykifh1K9xndRKb4dOHUcSLM01mwvRy2zsL8dyteBVEaF0FEOHhSQqU0vjgDAsn RX0TFXYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nriVi-008FTV-0n; Thu, 19 May 2022 15:56:22 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nriOt-0088Nl-En for linux-arm-kernel@lists.infradead.org; Thu, 19 May 2022 15:49:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 23998B82622; Thu, 19 May 2022 15:49:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8D1DC34100; Thu, 19 May 2022 15:49:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652975356; bh=wRDcSZWRg8F5GYZDzBv0ctTZeIUjFAPm7X9uhNSHFwo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E8aho+U1muOFpeLWM0FXTi1BWNJEHPMiiyTsSAWPRXoUVn1W9kxdpb8bXWeIqCP0I RgySRFIxpxZGCW+dFeItge4EvYalvRZEg0Cgh0g3od/B0mM9C5I5gHZxlp3zS17szb c5bkgEdd4USnWPTmdrMaQUniW6zDIP6hlmCflaZ35MN1XW370dVNykwsOXVvWL22FT LPl+JL6xj6Fyb+tKDiJN1n9dKwO/T5SCnvCYdekG5eGwwI2FfmR4WyoLQnjiwCQX7B d5cy4ncvffbet63U7dI+bWul3B8lva2Z7pt5x6u6iRvg0XRh4RMHtCp5trBWkacZsd VkXTDxeVKlNHw== Date: Thu, 19 May 2022 16:49:09 +0100 From: Mark Brown To: Andrew Lunn Cc: Krzysztof Kozlowski , Corentin Labbe , calvin.johnson@oss.nxp.com, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, jernej.skrabec@gmail.com, krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org, lgirdwood@gmail.com, linux@armlinux.org.uk, pabeni@redhat.com, robh+dt@kernel.org, samuel@sholland.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org Subject: Re: [PATCH v2 4/5] dt-bindings: net: Add documentation for optional regulators Message-ID: References: <20220518200939.689308-1-clabbe@baylibre.com> <20220518200939.689308-5-clabbe@baylibre.com> <95f3f0a4-17e6-ec5f-6f2f-23a5a4993a44@linaro.org> MIME-Version: 1.0 In-Reply-To: X-Cookie: Some restrictions may apply. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220519_084919_849571_9D7F4B27 X-CRM114-Status: GOOD ( 25.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6904530374825142581==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6904530374825142581== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jOI5UhwGK68KoNhN" Content-Disposition: inline --jOI5UhwGK68KoNhN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 19, 2022 at 01:58:18PM +0200, Andrew Lunn wrote: > On Thu, May 19, 2022 at 01:33:21PM +0200, Krzysztof Kozlowski wrote: > > On 19/05/2022 13:31, Mark Brown wrote: > > > On Thu, May 19, 2022 at 11:55:28AM +0200, Krzysztof Kozlowski wrote: > > >> On 18/05/2022 22:09, Corentin Labbe wrote: > > >>> + regulators: > > >>> + description: > > >>> + List of phandle to regulators needed for the PHY > > >> I don't understand that... is your PHY defining the regulators or using > > >> supplies? If it needs a regulator (as a supply), you need to document > > >> supplies, using existing bindings. > > > They're trying to have a generic driver which works with any random PHY > > > so the binding has no idea what supplies it might need. > > OK, that makes sense, but then question is why not using existing > > naming, so "supplies" and "supply-names"? > I'm not saying it is not possible, but in general, the names are not > interesting. All that is needed is that they are all on, or > potentially all off to save power on shutdown. We don't care how many > there are, or what order they are enabled. I think Krzysztof is referring to the name of the property rather than the contents of the -names property there. --jOI5UhwGK68KoNhN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKGZvQACgkQJNaLcl1U h9BKbAf+IovUQ3DSAoKJdf32JsgeB+o/vNXD8MscsyZm5JvIVj5BOLWLb1emeGJP Yp3omFPSMOvlsZtrBEx7Fk4MO/Rt0zWemfEcHAfnPI2yPp0LVZLBEqStTWeQQHab DdrMZrX6CDbQojP0q4eYGt24OF/dMIYThDp7XU4GDH4Sy7KXD5SpYGuR5Pe9F2Uy KZ/25LSM7z8oKUaMHCx21nUm1bHXbuBiP46PKEX4aiSJ1f+S5WhdlC4PI0ZnUMis iC00xj4guPTArs7K9DX8y4AwrjlMOogR5Nqwkl5c8xiZQs2lsMI/HfnctaUdiIe9 qBKP7Eyse3kVuq04h+CQHDUYTCrBIQ== =ZhuD -----END PGP SIGNATURE----- --jOI5UhwGK68KoNhN-- --===============6904530374825142581== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6904530374825142581==--