From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF313C433FE for ; Thu, 19 May 2022 16:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240934AbiESQij (ORCPT ); Thu, 19 May 2022 12:38:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242108AbiESQig (ORCPT ); Thu, 19 May 2022 12:38:36 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67CB2DFF46 for ; Thu, 19 May 2022 09:38:33 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id nr2-20020a17090b240200b001df2b1bfc40so9240632pjb.5 for ; Thu, 19 May 2022 09:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5R5CIsenxtrkxTKlA3MXRGhcGTe2bd3z24V2JTX79wc=; b=qKiBkzaLa8x6UswSmJfUjwYZA/+8KqTAJth5R0NSkIFDS+OYa4KsG2uOIOgIGEQdP4 F8mf2P2TCB85o7/umxXqrhR9Y71M26PoV9VW5PCToTGFtrBnh84Ox36EcDFBLWVp71jD XUqHHJtkU1aIZoAcr/4yG0jh3rkr4iZ6nyVh6EgEC+gAcHqOjsaXpiFmpOLk1JBJsMqF Dy47hm/WdCkWyLrEe65dUCuQzyzmf/ZvJxQxRDY8dIqoUHYIFuyJWOvXaxPmG2/nZQaw 4q2fomKvJhevs2t2VPjRs0pMPgC3OMNtFLTy1febiE8+FpKTb9FgypUFQEX5dL8geTIh bWJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5R5CIsenxtrkxTKlA3MXRGhcGTe2bd3z24V2JTX79wc=; b=HXA08CCNcT/5xuIHDbYjpfHymy0u/xU/XK4ejTPT154gzepbzhTV0A3Ak5nFk4Q3G/ sqlyFVsIYovmOQmJ1UMGflYIDMXFVkN/MBHeQ3+XqGdgfM9Jhbq0rrRWIZKnY+6IDlgC Do8Dt0ZznL9/TaZCHez4LOQDZeWKpZU8J8docQv2tbdBgUKAesisroW6EmOQLjqWNvTC 2gLtvD7tFWtUQXzK0SrzLHbYa9KZ6uTOE8T4wDRxoQUWIchIYsTnFGNS+G9QPFnLKEan r93mVewlazjIjiR7c5TAyf+Acsbgb3RfUHjLieBdHVWBOfWf5Lvp+3t7rlNaYie/D1Bb kkqg== X-Gm-Message-State: AOAM532rnpg+dHzJDxAqGHYl6/XNNE01juWn9klT1mfM+MQNqUYt7SBT qqrJpWX2zCEPdFNcIFs5Dz+SWw== X-Google-Smtp-Source: ABdhPJxiRsm84/7Erm3zrVNXQjVrfgfFlxyNelaI6knzQLt/AHi12NfjLuBHc0kegGIYgOlMcbZmkQ== X-Received: by 2002:a17:902:db11:b0:161:9513:da41 with SMTP id m17-20020a170902db1100b001619513da41mr5545300plx.145.1652978312706; Thu, 19 May 2022 09:38:32 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id a32-20020a056a001d2000b0050dc762819bsm4173554pfx.117.2022.05.19.09.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 09:38:32 -0700 (PDT) Date: Thu, 19 May 2022 16:38:28 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Wanpeng Li , Vitaly Kuznetsov , Jani Nikula , Paolo Bonzini , Tvrtko Ursulin , Rodrigo Vivi , Zhenyu Wang , Joonas Lahtinen , Tom Lendacky , Ingo Molnar , David Airlie , Thomas Gleixner , Dave Hansen , x86@kernel.org, intel-gfx@lists.freedesktop.org, Daniel Vetter , Borislav Petkov , Joerg Roedel , linux-kernel@vger.kernel.org, Jim Mattson , Zhi Wang , Brijesh Singh , "H. Peter Anvin" , intel-gvt-dev@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC PATCH v3 05/19] x86: KVMGT: use kvm_page_track_write_tracking_enable Message-ID: References: <20220427200314.276673-1-mlevitsk@redhat.com> <20220427200314.276673-6-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427200314.276673-6-mlevitsk@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022, Maxim Levitsky wrote: > @@ -1948,6 +1949,10 @@ static int kvmgt_guest_init(struct mdev_device *mdev) > if (__kvmgt_vgpu_exist(vgpu, kvm)) > return -EEXIST; > > + ret = kvm_page_track_write_tracking_enable(kvm); > + if (ret) > + return ret; If for some reason my idea to enable tracking during kvm_page_track_register_notifier() doesn't pan out, it's probably worth adding a comment saying that enabling write tracking can't be undone. > + > info = vzalloc(sizeof(struct kvmgt_guest_info)); > if (!info) > return -ENOMEM; > -- > 2.26.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D747C433EF for ; Thu, 19 May 2022 16:38:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 976BF10EC90; Thu, 19 May 2022 16:38:34 +0000 (UTC) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52BD610F1EC for ; Thu, 19 May 2022 16:38:33 +0000 (UTC) Received: by mail-pl1-x636.google.com with SMTP id n8so5297681plh.1 for ; Thu, 19 May 2022 09:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5R5CIsenxtrkxTKlA3MXRGhcGTe2bd3z24V2JTX79wc=; b=qKiBkzaLa8x6UswSmJfUjwYZA/+8KqTAJth5R0NSkIFDS+OYa4KsG2uOIOgIGEQdP4 F8mf2P2TCB85o7/umxXqrhR9Y71M26PoV9VW5PCToTGFtrBnh84Ox36EcDFBLWVp71jD XUqHHJtkU1aIZoAcr/4yG0jh3rkr4iZ6nyVh6EgEC+gAcHqOjsaXpiFmpOLk1JBJsMqF Dy47hm/WdCkWyLrEe65dUCuQzyzmf/ZvJxQxRDY8dIqoUHYIFuyJWOvXaxPmG2/nZQaw 4q2fomKvJhevs2t2VPjRs0pMPgC3OMNtFLTy1febiE8+FpKTb9FgypUFQEX5dL8geTIh bWJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5R5CIsenxtrkxTKlA3MXRGhcGTe2bd3z24V2JTX79wc=; b=1iM2Kuo6HDbZVW4CTIcfHurZy7s9lJWFpyGTQUnhuq+852t6o0Js5E65lKXC1sGcAA P+6jqktwN5C94Pqqc9I0RvNAiDAdjskQdOfX7FZk7mQJA7+TVEZVb8iN/A0hB+QSr6ym 3N/Hw4GISjCxKpYG+JcWd1QMG6bZf5nZNB1bzyiQ/vmAjVd3h2uMxNTA/eR7UKR1IrD7 Db05srlCmrAWSwbUsBnmE8XDidS5ibrQvsRMCKkRL8c5sfzyN1f6uOYjeu5PaLvJvjfD GhfZgO0kKBfHmpDmTb/n18Piu35MNr2s9TfRD9PbvYem7jmqFey+D6c6dIgh+CXO18jk MuTg== X-Gm-Message-State: AOAM5308FDPV+v/jjTf8KNELBDkMg9ou97sDF940v0xROKvtszWYCpG/ njqRsvdoUHpLu4S0s9dbOpcuUw== X-Google-Smtp-Source: ABdhPJxiRsm84/7Erm3zrVNXQjVrfgfFlxyNelaI6knzQLt/AHi12NfjLuBHc0kegGIYgOlMcbZmkQ== X-Received: by 2002:a17:902:db11:b0:161:9513:da41 with SMTP id m17-20020a170902db1100b001619513da41mr5545300plx.145.1652978312706; Thu, 19 May 2022 09:38:32 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id a32-20020a056a001d2000b0050dc762819bsm4173554pfx.117.2022.05.19.09.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 May 2022 09:38:32 -0700 (PDT) Date: Thu, 19 May 2022 16:38:28 +0000 From: Sean Christopherson To: Maxim Levitsky Subject: Re: [RFC PATCH v3 05/19] x86: KVMGT: use kvm_page_track_write_tracking_enable Message-ID: References: <20220427200314.276673-1-mlevitsk@redhat.com> <20220427200314.276673-6-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427200314.276673-6-mlevitsk@redhat.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, David Airlie , Dave Hansen , dri-devel@lists.freedesktop.org, "H. Peter Anvin" , Brijesh Singh , Joerg Roedel , x86@kernel.org, Ingo Molnar , Zhi Wang , Tom Lendacky , intel-gfx@lists.freedesktop.org, Borislav Petkov , Rodrigo Vivi , Thomas Gleixner , intel-gvt-dev@lists.freedesktop.org, Jim Mattson , Tvrtko Ursulin , linux-kernel@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Apr 27, 2022, Maxim Levitsky wrote: > @@ -1948,6 +1949,10 @@ static int kvmgt_guest_init(struct mdev_device *mdev) > if (__kvmgt_vgpu_exist(vgpu, kvm)) > return -EEXIST; > > + ret = kvm_page_track_write_tracking_enable(kvm); > + if (ret) > + return ret; If for some reason my idea to enable tracking during kvm_page_track_register_notifier() doesn't pan out, it's probably worth adding a comment saying that enabling write tracking can't be undone. > + > info = vzalloc(sizeof(struct kvmgt_guest_info)); > if (!info) > return -ENOMEM; > -- > 2.26.3 >