From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F1BC4332F for ; Thu, 19 May 2022 17:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234458AbiESR6i (ORCPT ); Thu, 19 May 2022 13:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242864AbiESR6h (ORCPT ); Thu, 19 May 2022 13:58:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95CDDD02BD; Thu, 19 May 2022 10:58:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30815619CF; Thu, 19 May 2022 17:58:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D2DFC385AA; Thu, 19 May 2022 17:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652983115; bh=qPSL3nOy4ors8i7I3XUDymDpFTxUdxPWn9rsFvTq4IU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z0B6c12RB7rnU3d3fbpR59AQwMBiYIHh01cWkCVFWoFxG4S/5WQslaQxF6a2ndlaT SS9SbflaP4pIgkWayhUQVBIGeGX24a5SGPnYCvyhxaqImBQq7zRl2lPettkBow1Y9u BFOpWBdSpUXBEsA9RZp5inbVjsq2ATV62zYtK8E2arym0VFrfChrfTH9vzdu9wDgW9 FNiUNiJf/5StVBcsWkvpyOsRYIzO5YoPX47FtapAKwFRlJjnMVsfDT0XtOl7hNa/hq 3bF55LsX9RF+l7PNlMiCks5Kxp6YukONvO7HhczXJ1szKkvlRkCRa9Gz0fsv2ugsqN XD3AjDZ/T+/4w== Date: Thu, 19 May 2022 23:28:31 +0530 From: Vinod Koul To: Robin Gong Cc: "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "u.kleine-koenig@pengutronix.de" , "plyatov@gmail.com" , "sean.nyekjaer@prevas.dk" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [PATCH v1 03/15] Revert "dmaengine: imx-sdma: refine to load context only once" Message-ID: References: <1556027045-5269-1-git-send-email-yibin.gong@nxp.com> <1556027045-5269-4-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556027045-5269-4-git-send-email-yibin.gong@nxp.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 23-04-19, 13:50, Robin Gong wrote: > This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because Please fix this as well > in spi-imx case, burst length may be changed dynamically. So what is the solution to handle different burst lengths, pls explain... > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 99d9f43..407a56e 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -377,7 +377,6 @@ struct sdma_channel { > unsigned long watermark_level; > u32 shp_addr, per_addr; > enum dma_status status; > - bool context_loaded; > struct imx_dma_data data; > struct work_struct terminate_worker; > }; > @@ -988,9 +987,6 @@ static int sdma_load_context(struct sdma_channel *sdmac) > int ret; > unsigned long flags; > > - if (sdmac->context_loaded) > - return 0; > - > if (sdmac->direction == DMA_DEV_TO_MEM) > load_address = sdmac->pc_from_device; > else if (sdmac->direction == DMA_DEV_TO_DEV) > @@ -1033,8 +1029,6 @@ static int sdma_load_context(struct sdma_channel *sdmac) > > spin_unlock_irqrestore(&sdma->channel_0_lock, flags); > > - sdmac->context_loaded = true; > - > return ret; > } > > @@ -1074,7 +1068,6 @@ static void sdma_channel_terminate_work(struct work_struct *work) > sdmac->desc = NULL; > spin_unlock_irqrestore(&sdmac->vc.lock, flags); > vchan_dma_desc_free_list(&sdmac->vc, &head); > - sdmac->context_loaded = false; > } > > static int sdma_disable_channel_async(struct dma_chan *chan) > -- > 2.7.4 > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67638C433EF for ; Thu, 19 May 2022 17:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=elrtm5xZPQkBHUCTxTSf+LBRbO5IRtnDZIeGXB5+CfI=; b=MIxCieYpVJs8jK RXDMX07T9C+HEDlr1xYUejMDgx6tsC0szPlLbLLqNzbZcTUfCjiE2N9lRd28K5WPcoocmOGW5fW+W Up493wbB1V63ovOq1uNPk36a6Zj7QGpyW/fiPKWG4Uy7MTGN894XcliNJwwrVh3AkFFIMh+vHE06I S8xLewfYgjhQB+Pvqrur7a1Qjv/4DsGJirQWpgCtRseyVTtFFav3fYhYmnhpQL3CoL8kuaBf1sV/a SsNmr/dzWcG9ox8jdYWqVajZpzc1gWvqK2GdhQnfVbI2+smUYaOegnSnDQD3LyU8/38b9VONnD4w3 spbCg5uQm29Qt3b+hJJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrkQ6-008kcw-B3; Thu, 19 May 2022 17:58:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrkQ2-008kb8-Er for linux-arm-kernel@lists.infradead.org; Thu, 19 May 2022 17:58:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 347326177D; Thu, 19 May 2022 17:58:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D2DFC385AA; Thu, 19 May 2022 17:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652983115; bh=qPSL3nOy4ors8i7I3XUDymDpFTxUdxPWn9rsFvTq4IU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z0B6c12RB7rnU3d3fbpR59AQwMBiYIHh01cWkCVFWoFxG4S/5WQslaQxF6a2ndlaT SS9SbflaP4pIgkWayhUQVBIGeGX24a5SGPnYCvyhxaqImBQq7zRl2lPettkBow1Y9u BFOpWBdSpUXBEsA9RZp5inbVjsq2ATV62zYtK8E2arym0VFrfChrfTH9vzdu9wDgW9 FNiUNiJf/5StVBcsWkvpyOsRYIzO5YoPX47FtapAKwFRlJjnMVsfDT0XtOl7hNa/hq 3bF55LsX9RF+l7PNlMiCks5Kxp6YukONvO7HhczXJ1szKkvlRkCRa9Gz0fsv2ugsqN XD3AjDZ/T+/4w== Date: Thu, 19 May 2022 23:28:31 +0530 From: Vinod Koul To: Robin Gong Cc: "broonie@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "u.kleine-koenig@pengutronix.de" , "plyatov@gmail.com" , "sean.nyekjaer@prevas.dk" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "dmaengine@vger.kernel.org" , "devicetree@vger.kernel.org" , "kernel@pengutronix.de" Subject: Re: [PATCH v1 03/15] Revert "dmaengine: imx-sdma: refine to load context only once" Message-ID: References: <1556027045-5269-1-git-send-email-yibin.gong@nxp.com> <1556027045-5269-4-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1556027045-5269-4-git-send-email-yibin.gong@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220519_105838_632143_4D2F7855 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-04-19, 13:50, Robin Gong wrote: > This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because Please fix this as well > in spi-imx case, burst length may be changed dynamically. So what is the solution to handle different burst lengths, pls explain... > > Signed-off-by: Robin Gong > --- > drivers/dma/imx-sdma.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 99d9f43..407a56e 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -377,7 +377,6 @@ struct sdma_channel { > unsigned long watermark_level; > u32 shp_addr, per_addr; > enum dma_status status; > - bool context_loaded; > struct imx_dma_data data; > struct work_struct terminate_worker; > }; > @@ -988,9 +987,6 @@ static int sdma_load_context(struct sdma_channel *sdmac) > int ret; > unsigned long flags; > > - if (sdmac->context_loaded) > - return 0; > - > if (sdmac->direction == DMA_DEV_TO_MEM) > load_address = sdmac->pc_from_device; > else if (sdmac->direction == DMA_DEV_TO_DEV) > @@ -1033,8 +1029,6 @@ static int sdma_load_context(struct sdma_channel *sdmac) > > spin_unlock_irqrestore(&sdma->channel_0_lock, flags); > > - sdmac->context_loaded = true; > - > return ret; > } > > @@ -1074,7 +1068,6 @@ static void sdma_channel_terminate_work(struct work_struct *work) > sdmac->desc = NULL; > spin_unlock_irqrestore(&sdmac->vc.lock, flags); > vchan_dma_desc_free_list(&sdmac->vc, &head); > - sdmac->context_loaded = false; > } > > static int sdma_disable_channel_async(struct dma_chan *chan) > -- > 2.7.4 > -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel