From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D016CC433F5 for ; Fri, 20 May 2022 03:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345104AbiETDRz (ORCPT ); Thu, 19 May 2022 23:17:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345124AbiETDRy (ORCPT ); Thu, 19 May 2022 23:17:54 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3915DA34 for ; Thu, 19 May 2022 20:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sgLAENrVLhV3Ip9Sf4Lx0FGhBG6cAsuJh+48uPiE0ZU=; b=hyDraljJTFiDtYKWgJTmdSDiCy dWbZ1971pGcVgntCWuJcRFAw8hcVqZVXuBmUjmKtQtETCYkHdTyQ/4WKSn1dMdUX77CvnFa3s7Pi+ acgLuoz8bMh/J31qUR+0OU01QrBGbYCaVw5TC0BMVnDLprQOMfLWSa4EzWiZ5F6MxLjOBcZcj8Gqv vWIEfiZDDORbGdgC64gm8bBJ/oMc+rjCGG51pYUoKZRBN7MWAIOomSi21LFdWTFHla4YDXB0Pxfu6 72vG+VXtqvIx8yBJ/WuHpMOKX6AYvgK4hM44OQEWr351s0oiC9zEyrPwSVdTnoYG2NY64HXulxz6y 5Lb2n/sA==; Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrt9E-00GU7n-Ab for linux-fsdevel@vger.kernel.org; Fri, 20 May 2022 03:17:52 +0000 Date: Fri, 20 May 2022 03:17:52 +0000 From: Al Viro To: linux-fsdevel@vger.kernel.org Subject: [PATCH] fs/namei.c:reserve_stack(): tidy up the call of try_to_unlazy() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org !foo() != 0 is a strange way to spell !foo(); fallout from "fs: make unlazy_walk() error handling consistent"... Signed-off-by: Al Viro --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index b867a92c078e..2d6b94a950fe 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1754,7 +1754,7 @@ static int reserve_stack(struct nameidata *nd, struct path *link, unsigned seq) // unlazy even if we fail to grab the link - cleanup needs it bool grabbed_link = legitimize_path(nd, link, seq); - if (!try_to_unlazy(nd) != 0 || !grabbed_link) + if (!try_to_unlazy(nd) || !grabbed_link) return -ECHILD; if (nd_alloc_stack(nd)) -- 2.30.2