From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4934C433F5 for ; Fri, 20 May 2022 07:47:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346620AbiETHrb (ORCPT ); Fri, 20 May 2022 03:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346549AbiETHr3 (ORCPT ); Fri, 20 May 2022 03:47:29 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9645371D89; Fri, 20 May 2022 00:47:27 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id nk9-20020a17090b194900b001df2fcdc165so10842579pjb.0; Fri, 20 May 2022 00:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=56ihVfI55g+5kWoCWi0j9KBKpP7u+QiASGOdishgsYU=; b=fI4qwgrFQO4hVvdc3SUyQ8Cdgd+sywkDfLxoX5FB2E66Rov05yQTZSVOzP7gpoXEQF 0elvCO46fIFZh0PGVYSb0zBP9E8rthiYU1kAunjlGADxZHVDIzKAD9lkoRKg2HXJ1W5y hXlwhv/t9DEN5z9vOFJjkOJHZlgbiKv1kt3tICg8ZW4m3WO5jv6iWCSmP7K1aB7qLYm4 VMIP2whsDbn6dmzkcOergoPPDPGfcjXLPaXh/y5sNGVVKXZAO8zLhLtKDQfFcopimuD1 iFzKXGu0GYsL7i2AAdYko6ymJb3ROx8/6svDCApNBiO36LmQDMIJe2JZDgJ2TmbOdK9q Eg8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=56ihVfI55g+5kWoCWi0j9KBKpP7u+QiASGOdishgsYU=; b=HM34ncEY4fHxu4Xx07p6KWs1bSKp1D4Cq/L9VCHzndNSN63VYDO33Of07xgwiOuFDw qdTRgF6q3QNhJ9hMFBPD+AfVZcUHxoQepZTb2ZBJbFXKHdGwOftBNlT8TxVkD2cal/04 YndHel80ekeJfzMIfv0fnDEjqqYWJAZ5Ho90nhIf5HTkho40yNUn0KtOMtEoP0IUPEd4 m1KS0ryCWldQDYPTQSg4ZF3qklZTsfphRuMQyojd8vY7IdQ3az6CXS7f/XX2ILDFvQd9 cHBkF1gmdM/NKHj1Q4tINQOOh0LsvDPs+9usQNfnrwcG6SNk4opFz06RKE8Pr2Sqrv9I GD1Q== X-Gm-Message-State: AOAM5331K2ZflfCEdV5/3yMlh+VwT393BPqvmcpgFwXx1lpECKu6WPBC INfzm8Azfl1wtnjIjX7VQSI= X-Google-Smtp-Source: ABdhPJzWP/OizPFgR9KmuaPsRGfMHikuqC99X6s0BZZQYR12Xiw5I0XneB0xM48YDFHIVgUBpKEfiw== X-Received: by 2002:a17:90a:760d:b0:1df:6423:d0b9 with SMTP id s13-20020a17090a760d00b001df6423d0b9mr10201911pjk.33.1653032846949; Fri, 20 May 2022 00:47:26 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:1761]) by smtp.gmail.com with ESMTPSA id v12-20020a17090331cc00b0015e8d4eb1ebsm4949822ple.53.2022.05.20.00.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 00:47:26 -0700 (PDT) Sender: Tejun Heo Date: Thu, 19 May 2022 21:47:25 -1000 From: Tejun Heo To: "T.J. Mercier" Cc: Nicolas Dufresne , Zefan Li , Johannes Weiner , Jonathan Corbet , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , John Stultz , Shuah Khan , Daniel Vetter , John Stultz , Carlos Llamas , Kalesh Singh , Kenny.Ho@amd.com, Michal =?iso-8859-1?Q?Koutn=FD?= , Shuah Khan , kernel-team@android.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller Message-ID: References: <20220510235653.933868-1-tjmercier@google.com> <3365cd1d750e84fedc8e75d646a77ffd85619d35.camel@ndufresne.ca> <81026ef07c1ce20f8673b75b17bab79a2b39c548.camel@ndufresne.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Tue, May 17, 2022 at 04:30:29PM -0700, T.J. Mercier wrote: > Thanks for your suggestion. This almost works. "dmabuf" as a key could > work, but I'd actually like to account for each heap. Since heaps can > be dynamically added, I can't accommodate every potential heap name by > hardcoding registrations in the misc controller. On its own, that's a pretty weak reason to be adding a separate gpu controller especially given that it doesn't really seem to be one with proper abstractions for gpu resources. We don't want to keep adding random keys to misc controller but can definitely add limited flexibility. What kind of keys do you need? Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80A40C433F5 for ; Fri, 20 May 2022 07:47:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A84C11B736; Fri, 20 May 2022 07:47:28 +0000 (UTC) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75AC311B736 for ; Fri, 20 May 2022 07:47:27 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id z7-20020a17090abd8700b001df78c7c209so10805389pjr.1 for ; Fri, 20 May 2022 00:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=56ihVfI55g+5kWoCWi0j9KBKpP7u+QiASGOdishgsYU=; b=fI4qwgrFQO4hVvdc3SUyQ8Cdgd+sywkDfLxoX5FB2E66Rov05yQTZSVOzP7gpoXEQF 0elvCO46fIFZh0PGVYSb0zBP9E8rthiYU1kAunjlGADxZHVDIzKAD9lkoRKg2HXJ1W5y hXlwhv/t9DEN5z9vOFJjkOJHZlgbiKv1kt3tICg8ZW4m3WO5jv6iWCSmP7K1aB7qLYm4 VMIP2whsDbn6dmzkcOergoPPDPGfcjXLPaXh/y5sNGVVKXZAO8zLhLtKDQfFcopimuD1 iFzKXGu0GYsL7i2AAdYko6ymJb3ROx8/6svDCApNBiO36LmQDMIJe2JZDgJ2TmbOdK9q Eg8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=56ihVfI55g+5kWoCWi0j9KBKpP7u+QiASGOdishgsYU=; b=5Q0J8htoTgVvU4Z/C/0a6H7vE7pfffHfDdaoZJtxW+piC0yvtLQO3/GCgOME6UHVJZ GQ0b9Jp3Nvei40XRVTYxm6qi2/D5B0mhOvMh+/zn/wtlCNxxT0BD6OJ8DbY93nsmjERZ wFee0X04oa9+A4IVqAIcl+/MRjcM1GPyxssR4Gq6hBOrNPAyLWFi5jWyHyUEISzEmSdc 8oWFmGyBBZcF9J2bqBeoW4KCgr0wkl7k06nESO2QhtUWHAuCHquFk3K0FHV+l48fwHpG I6YClsYzWVr7H++P4yjNDjDMwdFuEQxxcHJ8hoNy2udNt2tEBOMtDpSpDTj2JzNPlmFy mS6w== X-Gm-Message-State: AOAM533oiRi73TMrbMXnrPz7iTVY7GyyfqTGQDrcqdlgItNjluCONW3K dqWYLxvYQB4wbVLxfZelBA0= X-Google-Smtp-Source: ABdhPJzWP/OizPFgR9KmuaPsRGfMHikuqC99X6s0BZZQYR12Xiw5I0XneB0xM48YDFHIVgUBpKEfiw== X-Received: by 2002:a17:90a:760d:b0:1df:6423:d0b9 with SMTP id s13-20020a17090a760d00b001df6423d0b9mr10201911pjk.33.1653032846949; Fri, 20 May 2022 00:47:26 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:1761]) by smtp.gmail.com with ESMTPSA id v12-20020a17090331cc00b0015e8d4eb1ebsm4949822ple.53.2022.05.20.00.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 00:47:26 -0700 (PDT) Date: Thu, 19 May 2022 21:47:25 -1000 From: Tejun Heo To: "T.J. Mercier" Subject: Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller Message-ID: References: <20220510235653.933868-1-tjmercier@google.com> <3365cd1d750e84fedc8e75d646a77ffd85619d35.camel@ndufresne.ca> <81026ef07c1ce20f8673b75b17bab79a2b39c548.camel@ndufresne.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Carlos Llamas , dri-devel@lists.freedesktop.org, John Stultz , Zefan Li , Kalesh Singh , Joel Fernandes , Shuah Khan , Sumit Semwal , Kenny.Ho@amd.com, Benjamin Gaignard , Jonathan Corbet , Martijn Coenen , Nicolas Dufresne , Laura Abbott , kernel-team@android.com, linux-media@vger.kernel.org, Todd Kjos , linaro-mm-sig@lists.linaro.org, Shuah Khan , cgroups@vger.kernel.org, Suren Baghdasaryan , Christian Brauner , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Liam Mark , Christian =?iso-8859-1?Q?K=F6nig?= , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Michal =?iso-8859-1?Q?Koutn=FD?= , Johannes Weiner , Hridya Valsaraju Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello, On Tue, May 17, 2022 at 04:30:29PM -0700, T.J. Mercier wrote: > Thanks for your suggestion. This almost works. "dmabuf" as a key could > work, but I'd actually like to account for each heap. Since heaps can > be dynamically added, I can't accommodate every potential heap name by > hardcoding registrations in the misc controller. On its own, that's a pretty weak reason to be adding a separate gpu controller especially given that it doesn't really seem to be one with proper abstractions for gpu resources. We don't want to keep adding random keys to misc controller but can definitely add limited flexibility. What kind of keys do you need? Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v7 0/6] Proposal for a GPU cgroup controller Date: Thu, 19 May 2022 21:47:25 -1000 Message-ID: References: <20220510235653.933868-1-tjmercier@google.com> <3365cd1d750e84fedc8e75d646a77ffd85619d35.camel@ndufresne.ca> <81026ef07c1ce20f8673b75b17bab79a2b39c548.camel@ndufresne.ca> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=56ihVfI55g+5kWoCWi0j9KBKpP7u+QiASGOdishgsYU=; b=fI4qwgrFQO4hVvdc3SUyQ8Cdgd+sywkDfLxoX5FB2E66Rov05yQTZSVOzP7gpoXEQF 0elvCO46fIFZh0PGVYSb0zBP9E8rthiYU1kAunjlGADxZHVDIzKAD9lkoRKg2HXJ1W5y hXlwhv/t9DEN5z9vOFJjkOJHZlgbiKv1kt3tICg8ZW4m3WO5jv6iWCSmP7K1aB7qLYm4 VMIP2whsDbn6dmzkcOergoPPDPGfcjXLPaXh/y5sNGVVKXZAO8zLhLtKDQfFcopimuD1 iFzKXGu0GYsL7i2AAdYko6ymJb3ROx8/6svDCApNBiO36LmQDMIJe2JZDgJ2TmbOdK9q Eg8A== Sender: Tejun Heo Content-Disposition: inline In-Reply-To: List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "T.J. Mercier" Cc: Nicolas Dufresne , Zefan Li , Johannes Weiner , Jonathan Corbet , Greg Kroah-Hartman , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Hridya Valsaraju , Suren Baghdasaryan , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Benjamin Gaignard , Liam Mark , Laura Abbott , Brian Starkey , John Hello, On Tue, May 17, 2022 at 04:30:29PM -0700, T.J. Mercier wrote: > Thanks for your suggestion. This almost works. "dmabuf" as a key could > work, but I'd actually like to account for each heap. Since heaps can > be dynamically added, I can't accommodate every potential heap name by > hardcoding registrations in the misc controller. On its own, that's a pretty weak reason to be adding a separate gpu controller especially given that it doesn't really seem to be one with proper abstractions for gpu resources. We don't want to keep adding random keys to misc controller but can definitely add limited flexibility. What kind of keys do you need? Thanks. -- tejun