From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75C00C4332F for ; Fri, 20 May 2022 15:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350971AbiETPoT (ORCPT ); Fri, 20 May 2022 11:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233617AbiETPoL (ORCPT ); Fri, 20 May 2022 11:44:11 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EC58179093 for ; Fri, 20 May 2022 08:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DiDfLAXq5OXic23EfOc3wXlMoPBG932gPA4+ltevFWQ=; b=eUHMqYiH0BTIRFgTvQXExFPOjO Q5/clk7FTDLCL2bB7fYo7NIEyWpvCqL3QjgltmBbesGSkafVDnpSjbho5C+9cwyp6584Iwv4nHCml DZwpCPoSXiklGMFRy4M6NELvJyd0bcPlaFqhBgId4CB0hk0EdQuQi7emM16c5QUzVrXq2sj+zN8zJ 5LNJt8NlXuDy/3uI0ei5GCAzAuhNwXrlqna7grV5Jvh+qKm/nit5K80RQPTfsK5tBil7dzswQTujX AlGyLrr0KMpXa7W8oosl9KsbUqI+fhfFgpwmz7b3wcpMVDP79nift6C2Tv+ApFnCApMDivRN52TUP 1owLKsRQ==; Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ns4nM-00GdKP-R0; Fri, 20 May 2022 15:44:04 +0000 Date: Fri, 20 May 2022 15:44:04 +0000 From: Al Viro To: Jens Axboe Cc: "Jason A. Donenfeld" , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char/mem: only use {read,write}_iter, not the old {read,write} functions Message-ID: References: <20220520135030.166831-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 20, 2022 at 09:32:34AM -0600, Jens Axboe wrote: > Didn't look closer, but I'm assuming this is _mostly_ tied to needing to > init 48 bytes of kiocb for each one. There might be ways to embed a > sync_kiocb inside the kiocb for the bits we need there, at least that > could get us down to 32 bytes. My bet would be on iocb_flags() (and kiocb_set_rw_flags()) tests and pointer-chasing, actually. I'd been sick on and off since early November, trying to dig myself from under the piles right now. Christoph's patches in that area are somewhere in the pile ;-/