From: Matthias Kaehlcke <mka@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Enable keyboard backlight for villager
Date: Fri, 20 May 2022 13:29:37 -0700 [thread overview]
Message-ID: <Yof6MeM1Ohthe7Fq@google.com> (raw)
In-Reply-To: <CAD=FV=X4GBLoTuOcHetAFXWLQKFF0yn=E5yv0ExTg8Mwrw1iUw@mail.gmail.com>
On Fri, May 20, 2022 at 12:57:50PM -0700, Doug Anderson wrote:
> Hi,
>
> On Fri, May 20, 2022 at 12:48 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> >
> > Villager has a backlit keyboard, enable support for the backlight.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >
> > arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 8 ++++++++
> > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +-
> > 2 files changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> > index d3d6ffad4eff..b6a6a1454883 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> > @@ -58,6 +58,10 @@ &ap_sar_sensor1 {
> > status = "okay";
> > };
> >
> > +&keyboard_backlight {
> > + status = "okay";
> > +};
>
> Instead of doing this, can you just get rid of the status = "disabled"
> in herobrine.dtsi? I don't think there's any benefit to having two
> levels of "disabled" in the herobrine device tree.
Sure.
I guess the 'disabled' status was put as a micro-optimization to avoid
probing the 'pwm-leds' driver on boards that don't have any such LEDs. In
practical terms it shouldn't really make a difference in terms of memory
or CPU.
next prev parent reply other threads:[~2022-05-20 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 19:48 [PATCH] arm64: dts: qcom: sc7280: Enable keyboard backlight for villager Matthias Kaehlcke
2022-05-20 19:57 ` Doug Anderson
2022-05-20 20:29 ` Matthias Kaehlcke [this message]
2022-05-20 20:38 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yof6MeM1Ohthe7Fq@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.