From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE12C433F5 for ; Sat, 21 May 2022 14:26:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233363AbiEUO0m (ORCPT ); Sat, 21 May 2022 10:26:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbiEUO0l (ORCPT ); Sat, 21 May 2022 10:26:41 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90EEC3AA59 for ; Sat, 21 May 2022 07:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=4TQ7pAeXGZOQJQMxJ/uWJEaE7eYx7c3DeMDfRZc6DD0=; b=1t +lNfsEA+araGeQm2DPJFTKKzXSm3L/xBpW7g2/BkYUPfGX0Y0TMVQEGSnpYTM9DWVRysmNkcMeeDQ 0tLmT53nutvHCASmGPWmWt/BubVATFtSe1/XeJBApHSvYMSSibUjPHMbKm12UE/HKFWsx2fJ+yXo8 S0nhZpWozEz7N2g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nsQ3u-003mGk-FT; Sat, 21 May 2022 16:26:34 +0200 Date: Sat, 21 May 2022 16:26:34 +0200 From: Andrew Lunn To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Joakim Zhang , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, NXP Linux Team , kernel@pengutronix.de Subject: Re: [PATCH v2] net: fec: Do proper error checking for optional clks Message-ID: References: <20220521083425.787204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220521083425.787204-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, May 21, 2022 at 10:34:25AM +0200, Uwe Kleine-König wrote: > An error code returned by devm_clk_get() might have other meanings than > "This clock doesn't exist". So use devm_clk_get_optional() and handle > all remaining errors as fatal. > > Signed-off-by: Uwe Kleine-König Reviewed-by: Andrew Lunn Andrew