From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614A6C433F5 for ; Sun, 22 May 2022 07:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233090AbiEVHRy (ORCPT ); Sun, 22 May 2022 03:17:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231909AbiEVHRy (ORCPT ); Sun, 22 May 2022 03:17:54 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76FD43C498; Sun, 22 May 2022 00:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FYdUNpYTCKI9E//psNaQ4qfwx/AZlbpXMSBjSm3xLAI=; b=jfnCuOiWUTnVFCUfR715RoX543 ALG2snduf5sX62r4QAYIZQJY3+3FI7aWgxv5kcf4/cA+XT6g4VHAFGePDnHXOlKJTBVVepKTaVPgr kzZKGBxQBr6Wx4FJKE/CEurvvAv+v0oKlGFLCMiHMn8sQxJwz+r1f0+hQicjHp/YskSQ7ElO5Iwl/ KPvhZ8OAfCKA1DT4B99UW7w9kHwJkPIQWcyIbpRyQJRqWjcUGGQ3lnLoqkzUtBjSeKmzSY22NL686 nP4tD70Y8sGdLrSEtUfVx/nmgBYb/swPIM8GgtHgb2xQIEJMAIEkogcaKs101kMCo+vvV+v/BtmZX 8Hhp4HHA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsfqW-000m5s-Rj; Sun, 22 May 2022 07:17:48 +0000 Date: Sun, 22 May 2022 00:17:48 -0700 From: Christoph Hellwig To: Stefan Roesch Cc: io-uring@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, jack@suse.cz, hch@infradead.org Subject: Re: [RFC PATCH v4 03/17] mm: Prepare balance_dirty_pages() for async buffered writes Message-ID: References: <20220520183646.2002023-1-shr@fb.com> <20220520183646.2002023-4-shr@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520183646.2002023-4-shr@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, May 20, 2022 at 11:36:32AM -0700, Stefan Roesch wrote: > From: Jan Kara > > If balance_dirty_pages() gets called for async buffered write, we don't > want to wait. Instead we need to indicate to the caller that throttling > is needed so that it can stop writing and offload the rest of the write > to a context that can block. I don't tink this really makes sense without the next patch, so I'd suggest to merge the two.