From: Dmitry Torokhov <email@example.com> To: Douglas Anderson <firstname.lastname@example.org> Cc: Jiri Kosina <email@example.com>, Benjamin Tissoires <firstname.lastname@example.org>, Rob Herring <email@example.com>, Krzysztof Kozlowski <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH 2/2] HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens Date: Sun, 22 May 2022 14:31:37 -0700 [thread overview] Message-ID: <YoqrudJZneAZ010D@google.com> (raw) In-Reply-To: <20220519155925.2.I2d3f735a485157eeaa24d60be8a327f98101789d@changeid> On Thu, May 19, 2022 at 04:00:03PM -0700, Douglas Anderson wrote: > Like many i2c-hid touchscreen controllers, the Elan eKTH6915 has a > reset GPIO hooked up to it. According to the datasheet, the way we're > supposed to turn the touchscreen on is: > > 1. Turn on the 3.3V supply. > 2. Turn on the IO supply. It's OK if this is hardwired to the 3.3V > supply, but if it's not then it must be turned on _after_ the 3.3V > supply. > 3. Wait >= 1 ms. > 4. Deassert the reset GPIO (reset GPIO is active low, so there would > be a leakage path if this was deasserted _before_ the IO supply). > 5. Wait 300 ms. > > Much of the above can be handled by the generic i2c-hid-of driver, but > the "reset" GPIO is not supported by that driver. Thus we'll do the > same as we did for Goodix and add a new tiny driver that uses the > i2c-hid core. > > NOTE: support for this new touchscreen could theorically fit into the > Goodix driver. I've made it a separate driver because the Elan driver > supports _two_ regulators and it's unclear exactly how that would fit > in with commit 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset line > to true state of the regulator"). > > Signed-off-by: Douglas Anderson <firstname.lastname@example.org> Reviewed-by: Dmitry Torokhov <email@example.com> > + > + return i2c_hid_core_probe(client, &ihid_elan->ops, 0x0001, 0); Maybe #define for the descriptor address, or rename elan_i2c_hid_timing_data into elan_i2c_hid_chip_data and put it there? Thanks. -- Dmitry
next prev parent reply other threads:[~2022-05-22 21:31 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-19 23:00 [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce bindings for Elan eKTH6915 Douglas Anderson 2022-05-19 23:00 ` [PATCH 2/2] HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens Douglas Anderson 2022-05-22 21:31 ` Dmitry Torokhov [this message] 2022-05-22 21:32 ` [PATCH 1/2] dt-bindings: HID: i2c-hid: elan: Introduce bindings for Elan eKTH6915 Dmitry Torokhov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YoqrudJZneAZ010D@google.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/2] HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.