From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF23C433EF for ; Mon, 23 May 2022 06:12:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 845BE83EF9; Mon, 23 May 2022 08:12:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="EoQRuENh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4442383F06; Mon, 23 May 2022 08:12:11 +0200 (CEST) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 978C883EDC for ; Mon, 23 May 2022 08:12:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-wr1-x434.google.com with SMTP id t6so19749292wra.4 for ; Sun, 22 May 2022 23:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=exN4BP2lyYnUDYbx01uNLbWP3OYJ9W1MV2fW2uFu0Xc=; b=EoQRuENhtltOzNHBn18iM9j+7pRsszRW7tpFyKJRtM6ZuxOdfsZdrvD0wT1A4Ybd1e zdQUEkT5khw8PHbgaZ2/C9BFxqjoBp6FEJ81U2Un84BhVXSWqbDdjSh1TiDI7D+1pbqs JmnLqIH4WWVqgfMFwdpzVh8nNi2rpGqTwF8CfcmKnGwbtDCFnTYf9S9ctb0QC9nPfCsQ Mp1J6/9GFJ0slxIKH9/ujLEXcswT9qrBkQG+BFeSzySL5nKx4Uya3Dg1PTJj4pGJsXlS KdeWgmFEpxBTVdEH9I3FyZ2r3LRwnc0epxnryGyCHWpaYHd+1NKPNIWBPN4x0/7UIVIk b9nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=exN4BP2lyYnUDYbx01uNLbWP3OYJ9W1MV2fW2uFu0Xc=; b=1X+Y++Tn4IB1eyaAY6AiF3+Nx87QRSr1DN1iJSKbvJdtCKn77l0gn2hbdz45VRXea2 AzJaaZp5y2wCFX2+obDMaRKmO2ILWI4DEMrStUWjz++PeBS4jzWpaMLn6F4BkV7UO9Re daHmUUxWoRmel9J4rLwyJ0WfjpDNkNhSHm5/RFFONwblorEhguFjkKOKovebVp5EyJTO SstpUJoq8HmQm84iYY5rpiHT3rNgJ9eOtlMicqTLNE61SgiPoKHAe3ydh9SJRMPUuq4w N+104fkE6tDxgFuVsPWaa0EBuKlNEXgNmUfGEMluX6o8kgDRc7smzwKLzMuuzpYGIYAj ubUw== X-Gm-Message-State: AOAM530l+GOsqIeXyjaaLCcW9lB+bUiGo+s/tlw2FztRddEYc/dUOs0+ 8ZY5XyRyQDV4+WFlSfrjMzJ5Fg== X-Google-Smtp-Source: ABdhPJy4Z/6hPiWIN9/xBUUd8WEAtgJurrE74Pv4tdOZPDRZ9nWZoIfsgGw6VzcbElM0rx8wx8u0uQ== X-Received: by 2002:a5d:4f0c:0:b0:20e:5906:713d with SMTP id c12-20020a5d4f0c000000b0020e5906713dmr17503538wru.634.1653286328165; Sun, 22 May 2022 23:12:08 -0700 (PDT) Received: from hera ([176.92.137.112]) by smtp.gmail.com with ESMTPSA id g17-20020adfbc91000000b0020e6c51f070sm9152408wrh.112.2022.05.22.23.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 May 2022 23:12:07 -0700 (PDT) Date: Mon, 23 May 2022 09:12:05 +0300 From: Ilias Apalodimas To: Eddie James Cc: u-boot@lists.denx.de Subject: Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips Message-ID: References: <20220513183000.47392-1-eajames@linux.ibm.com> <20220513183000.47392-3-eajames@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220513183000.47392-3-eajames@linux.ibm.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Eddie, Thanks for the patch. [...] > +static const struct tpm_tis_chip_data tpm_tis_std_chip_data = { > + .pcr_count = 24, > + .pcr_select_min = 3, > +}; > + > +static const struct udevice_id tpm_tis_i2c_ids[] = { > + { > + .compatible = "nuvoton,npct75x", > + .data = (ulong)&tpm_tis_std_chip_data, > + }, > + { > + .compatible = "tcg,tpm-tis-i2c", > + .data = (ulong)&tpm_tis_std_chip_data, > + }, > + { } > +}; > + > +U_BOOT_DRIVER(tpm_tis_i2c) = { > + .name = "tpm_tis_i2c", > + .id = UCLASS_TPM, > + .of_match = tpm_tis_i2c_ids, > + .ops = &tpm_tis_i2c_ops, > + .probe = tpm_tis_i2c_probe, > + .remove = tpm_tis_i2c_remove, > + .priv_auto_alloc_size = sizeof(struct tpm_chip), Shouldn't this be .priv_auto only? IIRC we got rid of the .priv_auto_alloc_size a while back? If so I can fix this while merging Regards /Ilias > +}; > -- > 2.27.0 >