Re: [PATCH v2 1/9] tty: n_gsm: fix user open not possible at responder until initiator open

From: Greg KH <gregkh@linuxfoundation.org>
To: "Starke, Daniel" <daniel.starke@siemens.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"jirislaby@kernel.org" <jirislaby@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/9] tty: n_gsm: fix user open not possible at responder until initiator open
Date: Mon, 23 May 2022 14:09:39 +0200	[thread overview]
Message-ID: <Yot5gwXsdqGvkJCQ@kroah.com> (raw)
In-Reply-To: <DB9PR10MB58810877B0B37B6212471415E0D49@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>

On Mon, May 23, 2022 at 08:45:06AM +0000, Starke, Daniel wrote:
> > > +/**
> > > + *	gsm_dlci_wait_open	-	wait for channel open procedure
> > > + *	@dlci: DLCI to open
> > > + *
> > > + *	Wait for a DLCI opening from the other side. Asynchronously wait until
> > > + *	we get a SABM and set off timers and the responses.
> > > + */
> > > +static void gsm_dlci_wait_open(struct gsm_dlci *dlci) {
> > > +	switch (dlci->state) {
> > > +	case DLCI_CLOSED:
> > > +	case DLCI_CLOSING:
> > > +		dlci->state = DLCI_OPENING;
> > > +		break;
> > > +	default:
> > > +		break;
> > > +	}
> > > +}
> > 
> > The documentation for this function is odd, you are not waiting for
> > anything.  You are just changing the state.  This makes no sense as-is,
> > sorry.
> 
> Thank you for your comment. I have prepared a new version. I will send it
> after the other 8 patches have been commented.

No, please fix up and resend the series, it is long gone from my review
queue.

thanks,

greg k-h