From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Riccardo Mancini <rickyman7@gmail.com>,
Sohaib Mohamed <sohaib.amhmd@gmail.com>,
Carsten Haitzler <carsten.haitzler@arm.com>,
Marco Elver <elver@google.com>,
John Garry <john.garry@huawei.com>,
Michael Petlan <mpetlan@redhat.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v2 0/8] Make more tests skip rather than fail
Date: Mon, 23 May 2022 10:05:37 -0300 [thread overview]
Message-ID: <YouGoc9elnPwV5IM@kernel.org> (raw)
In-Reply-To: <20220518042027.836799-1-irogers@google.com>
Em Tue, May 17, 2022 at 09:20:19PM -0700, Ian Rogers escreveu:
> A long standing niggle has been that tests that cannot pass are marked
> as failing rather than skip. John Garry mentioned a similar concern
> in [1]. These changes fix this behavior so that as root, or not, at
> least the first 10 tests are passing or skipping.
>
> [1] https://lore.kernel.org/lkml/d32376b5-5538-ff00-6620-e74ad4b4abf2@huawei.com/
>
> v2. Updates reviewed-by and acked-by. It addresses review comments
> from Namhyung Kim <namhyung@kernel.org>. An extra fix is now
> included for PERF_RECORD_* which can fail as a user because of
> perf_event_paranoid.
Thanks, applied.
- Arnaldo
> Ian Rogers (8):
> perf test: Skip reason for suites with 1 test
> perf test: Use skip in vmlinux kallsyms
> perf test: Use skip in openat syscall
> perf test: Basic mmap use skip
> perf test: Parse events tidy terms_test
> perf test: Parse events tidy evlist_test
> perf test: Parse events break apart tests
> perf test: Use skip in PERF_RECORD_*
>
> tools/perf/tests/builtin-test.c | 6 +-
> tools/perf/tests/mmap-basic.c | 18 +-
> tools/perf/tests/openat-syscall-all-cpus.c | 23 +-
> tools/perf/tests/openat-syscall.c | 20 +-
> tools/perf/tests/parse-events.c | 492 +++++++++++----------
> tools/perf/tests/perf-record.c | 18 +-
> tools/perf/tests/vmlinux-kallsyms.c | 12 +-
> 7 files changed, 341 insertions(+), 248 deletions(-)
>
> --
> 2.36.0.550.gb090851708-goog
--
- Arnaldo
prev parent reply other threads:[~2022-05-23 13:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 4:20 [PATCH v2 0/8] Make more tests skip rather than fail Ian Rogers
2022-05-18 4:20 ` [PATCH v2 1/8] perf test: Skip reason for suites with 1 test Ian Rogers
2022-05-18 4:20 ` [PATCH v2 2/8] perf test: Use skip in vmlinux kallsyms Ian Rogers
2022-05-18 4:20 ` [PATCH v2 3/8] perf test: Use skip in openat syscall Ian Rogers
2022-05-18 4:20 ` [PATCH v2 4/8] perf test: Basic mmap use skip Ian Rogers
2022-05-18 4:20 ` [PATCH v2 5/8] perf test: Parse events tidy terms_test Ian Rogers
2022-05-18 4:20 ` [PATCH v2 6/8] perf test: Parse events tidy evlist_test Ian Rogers
2022-05-18 4:20 ` [PATCH v2 7/8] perf test: Parse events break apart tests Ian Rogers
2022-05-18 4:20 ` [PATCH v2 8/8] perf test: Use skip in PERF_RECORD_* Ian Rogers
2022-05-23 13:05 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YouGoc9elnPwV5IM@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=carsten.haitzler@arm.com \
--cc=elver@google.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=sohaib.amhmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.