Re: [PATCH v2 1/2] ucsi_ccg: ACPI based I2c client enumeration for AMD ASICs

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Fri, May 20, 2022 at 04:57:03PM +0530, Sanket Goswami wrote:
> Some of the AMD platforms have Cypress CCGX PD controller connected
> to system I2C i.e designware I2C controller. Added support to enumerate
> the CCGX client by adding ACPI ID to the firmware.

Oh, this patch needs to come only after the patch 2/2. Otherwise
you'll break bisectability. Please swap the places of these patches in
the next version.

thanks,

> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
> ---
>  drivers/usb/typec/ucsi/ucsi_ccg.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 6db7c8ddd51c..7585599bacfd 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1418,6 +1418,12 @@ static const struct i2c_device_id ucsi_ccg_device_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, ucsi_ccg_device_id);
>  
> +static const struct acpi_device_id amd_i2c_ucsi_match[] = {
> +	{"AMDI0042"},
> +	{}
> +};
> +MODULE_DEVICE_TABLE(acpi, amd_i2c_ucsi_match);
> +
>  static int ucsi_ccg_resume(struct device *dev)
>  {
>  	struct i2c_client *client = to_i2c_client(dev);
> @@ -1459,6 +1465,7 @@ static struct i2c_driver ucsi_ccg_driver = {
>  		.name = "ucsi_ccg",
>  		.pm = &ucsi_ccg_pm,
>  		.dev_groups = ucsi_ccg_groups,
> +		.acpi_match_table = amd_i2c_ucsi_match,
>  	},
>  	.probe = ucsi_ccg_probe,
>  	.remove = ucsi_ccg_remove,
> -- 
> 2.25.1

-- 
heikki