From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F045C43334 for ; Tue, 7 Jun 2022 21:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359009AbiFGVJd (ORCPT ); Tue, 7 Jun 2022 17:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379049AbiFGVIn (ORCPT ); Tue, 7 Jun 2022 17:08:43 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 150E421329C for ; Tue, 7 Jun 2022 11:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654627860; x=1686163860; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+IFA82BTf1vg/c1CM750oB0li57yhexf+/6W61dEKqs=; b=FDwxk2lZq8guSnoyw0ov4POd5KIaFfjO9XmUGKiLnplykzxHjjybYLLY It3yO9M+M7KlJN14iCwjUTpDLyFCnhCJ1U6fcVR0jOE+W79KNC8l60It0 giQQOl5NVAIbe1pVAKiVcJeR6UVKSK24XTMDAqAQ9V31F5aMe34AglAo8 6x8VC90Q4ifE4tAZ3oQuwapSwl8n1UPBUBGfdQkvbn9UpWd+A+GhlDaip 44zUHNJdAACXvbI5ZPdOa8MfC6pv0PgdK4VDoX9hU0kYjMWiT6GnToaK4 ShMpk5W9OdAI25DQ/iCUPz9HrBTniPbhMGbHhd951vTdqi+UyK+Bpm0D1 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="274272039" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="274272039" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 11:50:26 -0700 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="670122995" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 11:50:24 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nyeHV-000Vxe-52; Tue, 07 Jun 2022 21:50:21 +0300 Date: Tue, 7 Jun 2022 21:50:20 +0300 From: Andy Shevchenko To: Miquel Raynal Cc: Vinod Koul , dmaengine@vger.kernel.org, Milan Stevanovic , Jimmy Lalande , Pascal Eberhard , Thomas Petazzoni , Herve Codina , Clement Leger , kernel test robot Subject: Re: [PATCH v2 2/2] dmaengine: dw: dmamux: Fix build without CONFIG_OF Message-ID: References: <20220607152215.46731-1-miquel.raynal@bootlin.com> <20220607152215.46731-2-miquel.raynal@bootlin.com> <20220607191759.7e3a2fcc@xps-13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607191759.7e3a2fcc@xps-13> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Tue, Jun 07, 2022 at 07:17:59PM +0200, Miquel Raynal wrote: > andriy.shevchenko@linux.intel.com wrote on Tue, 7 Jun 2022 19:32:47 > +0300: > > On Tue, Jun 07, 2022 at 05:22:15PM +0200, Miquel Raynal wrote: ... > > No, what I asked is the opposite. > > I don't get what you want. Can you please explain what you mean by > "simply drop CONFIG_OF"? The below code changes shouldn't be present in this patch, that's all. ... > > > +#ifdef CONFIG_OF > > > static const struct of_device_id rzn1_dmamux_match[] = { > > > { .compatible = "renesas,rzn1-dmamux" }, > > > {} > > > }; > > > MODULE_DEVICE_TABLE(of, rzn1_dmamux_match); > > > +#endif > > > > > > static struct platform_driver rzn1_dmamux_driver = { > > > .driver = { > > > .name = "renesas,rzn1-dmamux", > > > - .of_match_table = rzn1_dmamux_match, > > > + .of_match_table = of_match_ptr(rzn1_dmamux_match), > > > }, > > > .probe = rzn1_dmamux_probe, > > > }; -- With Best Regards, Andy Shevchenko