From: Roman Gushchin <roman.gushchin@linux.dev>
To: Eric Biggers <ebiggers@kernel.org>
Cc: syzbot <syzbot+300d27c79fe6d4cbcc39@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzkaller-bugs@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [syzbot] WARNING in register_shrinker_prepared
Date: Mon, 6 Jun 2022 16:35:05 -0700 [thread overview]
Message-ID: <Yp6PKQ5bPmwu9b2E@carbon> (raw)
In-Reply-To: <Yp5y7NoNP9WF6vCS@sol.localdomain>
On Mon, Jun 06, 2022 at 02:34:36PM -0700, Eric Biggers wrote:
> On Mon, Jun 06, 2022 at 12:23:02PM -0700, Andrew Morton wrote:
> > (cc Roman)
> >
> > On Mon, 06 Jun 2022 10:17:34 -0700 syzbot <syzbot+300d27c79fe6d4cbcc39@syzkaller.appspotmail.com> wrote:
> >
> > > Hello,
> > >
> > > syzbot found the following issue on:
> > >
> > > HEAD commit: 1cfd968b58a1 Add linux-next specific files for 20220603
> > > git tree: linux-next
> > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=12f7b6b3f00000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=7da8386e3742814f
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=300d27c79fe6d4cbcc39
> > > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=103e5177f00000
> > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13545057f00000
> > >
> > > IMPORTANT: if you fix the issue, please add the following tag to the commit:
> > > Reported-by: syzbot+300d27c79fe6d4cbcc39@syzkaller.appspotmail.com
> > >
> > > loop0: detected capacity change from 0 to 20
> > > ------------[ cut here ]------------
> > > WARNING: CPU: 0 PID: 3694 at mm/vmscan.c:681 register_shrinker_prepared+0x119/0x150 mm/vmscan.c:681
> >
> > That's
> >
> > WARN_ON_ONCE(shrinker_debugfs_add(shrinker));
> >
> > I assume that debugfs_create_dir() failed. Please see the NOTE: in
> > that function's kerneldoc.
> >
>
> The call to ida_alloc() can fail too.
>
> register_shrinker_prepared() is not allowed to fail; anything that can fail must
> happen in prealloc_shrinker(). So either this new debugfs registration code
> needs to be moved to prealloc_shrinker(), or errors from it need to be ignored
> (which might be appropriate since it is just debugfs).
I don't think we want to panic or fail to mount filesystems because of it,
so I agree, ignoring is the best option.
next prev parent reply other threads:[~2022-06-06 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 17:17 [syzbot] WARNING in register_shrinker_prepared syzbot
2022-06-06 19:23 ` Andrew Morton
2022-06-06 21:34 ` Eric Biggers
2022-06-06 23:35 ` Roman Gushchin [this message]
2022-06-06 23:29 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp6PKQ5bPmwu9b2E@carbon \
--to=roman.gushchin@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+300d27c79fe6d4cbcc39@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.