All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH] qsd: document vduse-blk exports
Date: Fri, 27 May 2022 17:54:12 +0200	[thread overview]
Message-ID: <YpD0JA69G2R6ZHkN@redhat.com> (raw)
In-Reply-To: <CACycT3tEDW0ePvRRDuiUNA=5-OshL97WdJGpXsp5xBSkg6FROg@mail.gmail.com>

Am 26.05.2022 um 13:36 hat Yongji Xie geschrieben:
> On Wed, May 25, 2022 at 8:19 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > Document vduse-blk exports in qemu-storage-daemon --help and the
> > qemu-storage-daemon(1) man page.
> >
> > Based-on: <20220523084611.91-1-xieyongji@bytedance.com>
> > Cc: Xie Yongji <xieyongji@bytedance.com>
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

> > @@ -110,6 +111,26 @@ Standard options:
> >    ``allow-other`` to auto (the default) will try enabling this option, and on
> >    error fall back to disabling it.
> >
> > +  The ``vduse-blk`` export type uses the ``id`` as the VDUSE device name.
> > +  ``num-queues`` sets the number of virtqueues (the default is 1).
> > +  ``queue-size`` sets the virtqueue descriptor table size (the default is 256).
> > +
> > +  The instantiated VDUSE device must then be added to the vDPA bus using the
> > +  vdpa(8) command from the iproute2 project::
> > +
> > +  # vdpa dev add <id> mgmtdev vduse
> 
> Should it be:
> 
> # vdpa dev add name <id> mgmtdev vduse

Thanks, fixed this up (as well as a missing "\n" in the help output) and
applied to the block branch.

Kevin



  reply	other threads:[~2022-05-27 16:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25 12:19 [PATCH] qsd: document vduse-blk exports Stefan Hajnoczi
2022-05-26 11:36 ` Yongji Xie
2022-05-27 15:54   ` Kevin Wolf [this message]
2022-05-29 18:35     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpD0JA69G2R6ZHkN@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.