From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D8FC433EF for ; Sat, 28 May 2022 05:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352846AbiE1FDN (ORCPT ); Sat, 28 May 2022 01:03:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235749AbiE1FDN (ORCPT ); Sat, 28 May 2022 01:03:13 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4FB2C3D00; Fri, 27 May 2022 22:03:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nU2UQDrRrTNgZCGlx3+Juyg9gJKqa9hFvsLcatF4nYk=; b=HqAA4MktGO1WMudvYma9Q5OBoR WgN6YSaxtPq6Naw9oAM/KxoqZkaAB0g/rKEE5aSlqLTCiRokm7eYH+PU+AxrxvTIAZ+gLY10zgbzN x0iaC+BgxU2ZAqsRHsswWxy9XrcEsKHFH38ftS1MaXged/qeSavGaRzSbR4rAuR4X4nUgKxJPErG9 Y9nNFyEWEkO3DFJrt1tTyZ75poO8I4sJtdOUu86PGLF6YHA49WPSztat8ddJ58nRfjZS9WhsCBJJS wU16/5hH37wJKBAdlbbOw063jkQ7LCrTPDG/jt68ZFrdHa55r99Z0dChsVNMNsm9AFKABdG0F69Q6 FgnVpuFA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuobW-001SZy-Fk; Sat, 28 May 2022 05:03:10 +0000 Date: Fri, 27 May 2022 22:03:10 -0700 From: Christoph Hellwig To: Jaegeuk Kim Cc: Eric Biggers , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] f2fs: add sysfs entry to avoid FUA Message-ID: References: <20220527205955.3251982-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, May 27, 2022 at 06:06:08PM -0700, Jaegeuk Kim wrote: > I think there's still some benefit to use FUA such as small chunk writes > for checkpoint. Did you measure if there is? Because some SSDs basically implemented FUA as an implied flush after the write, in which case it would not really help there either (but also not hurt). But as the previous two maintainers already said - this needs quirking at the driver layer, not in the submitter. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9699FC433EF for ; Sat, 28 May 2022 05:03:28 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nuobn-0006e6-4h; Sat, 28 May 2022 05:03:26 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nuobl-0006e0-2c for linux-f2fs-devel@lists.sourceforge.net; Sat, 28 May 2022 05:03:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nU2UQDrRrTNgZCGlx3+Juyg9gJKqa9hFvsLcatF4nYk=; b=jBqIqxId5qsxSqyvCRKimTsSGF x3UgzDEc0qaKvTS/0PqB6cqllJiqffroDzf/ne5TM/JkYTDw9ylYt4yv1noS8imD5XL0ga8O/pCh2 al3lbSUvhQ9NWw0e+H5rPNs38+GvS78r4EX50OkjoCloUbh1yUIhojPCg+RC7ipm75IA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nU2UQDrRrTNgZCGlx3+Juyg9gJKqa9hFvsLcatF4nYk=; b=Pap2HkD1WfsQ6xHONpvQpU7IFR RfQbfjZEeWfALEHaAwhc2t8mZsZTOL9Jzks4aNnRgux5OGnhhlkOiA6iR1XmEUgh9hQvKMs38wHwI 7ZrnMrqxymYDwErOFEUy8RBJfbh/9W0n8XYFmnMMQAFQ+UCfmWZtM2Ga4eyOTVJ4fnFM=; Received: from [198.137.202.133] (helo=bombadil.infradead.org) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nuobe-00011d-KS for linux-f2fs-devel@lists.sourceforge.net; Sat, 28 May 2022 05:03:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nU2UQDrRrTNgZCGlx3+Juyg9gJKqa9hFvsLcatF4nYk=; b=HqAA4MktGO1WMudvYma9Q5OBoR WgN6YSaxtPq6Naw9oAM/KxoqZkaAB0g/rKEE5aSlqLTCiRokm7eYH+PU+AxrxvTIAZ+gLY10zgbzN x0iaC+BgxU2ZAqsRHsswWxy9XrcEsKHFH38ftS1MaXged/qeSavGaRzSbR4rAuR4X4nUgKxJPErG9 Y9nNFyEWEkO3DFJrt1tTyZ75poO8I4sJtdOUu86PGLF6YHA49WPSztat8ddJ58nRfjZS9WhsCBJJS wU16/5hH37wJKBAdlbbOw063jkQ7LCrTPDG/jt68ZFrdHa55r99Z0dChsVNMNsm9AFKABdG0F69Q6 FgnVpuFA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuobW-001SZy-Fk; Sat, 28 May 2022 05:03:10 +0000 Date: Fri, 27 May 2022 22:03:10 -0700 From: Christoph Hellwig To: Jaegeuk Kim Message-ID: References: <20220527205955.3251982-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1nuobe-00011d-KS Subject: Re: [f2fs-dev] [PATCH] f2fs: add sysfs entry to avoid FUA X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Biggers , linux-block@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Fri, May 27, 2022 at 06:06:08PM -0700, Jaegeuk Kim wrote: > I think there's still some benefit to use FUA such as small chunk writes > for checkpoint. Did you measure if there is? Because some SSDs basically implemented FUA as an implied flush after the write, in which case it would not really help there either (but also not hurt). But as the previous two maintainers already said - this needs quirking at the driver layer, not in the submitter. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel