From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8EEC433EF for ; Mon, 30 May 2022 07:53:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232726AbiE3HxW (ORCPT ); Mon, 30 May 2022 03:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233600AbiE3HxH (ORCPT ); Mon, 30 May 2022 03:53:07 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 494B0287; Mon, 30 May 2022 00:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PA/t+O0nJ8ZID3NeeJjW9bADPDFRaoAD2wrlnvNm2Fc=; b=JA05FiD+94Y9SDtuOfX8qU7/8b jQWH1UQ/LOU5p+OQy7OXowgT92X1PEDMGFn8eOHLmFZ5jNS3dia/BQzM8friSrCqpcyAwXOeq/bGA Sdh8fWGD3zvA1fweBQ/SVTvosAAa+0/lrhlLUJna7Oj38RVccmcXxeTnUG2kp4q45U41H9UrZoO3V J7MkpFmGQKV2c/RYPw4NuksF7YmyZduE7aIimfAS9vxjrv/3eLJ6nenDMKXzCULjpF8W2wLvwh5AX fW9xxzVa9+BLNQQWyDwveVUtRVkTHaQQA5sDLJEj1ckFQVAUzlF9MJRKxmzMJD3t4X9n02wa52bep ntxwAg7A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvaC0-004I5j-7g; Mon, 30 May 2022 07:52:00 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 0B9AC980DE7; Mon, 30 May 2022 09:51:58 +0200 (CEST) Date: Mon, 30 May 2022 09:51:57 +0200 From: Peter Zijlstra To: "Madhavan T. Venkataraman" Cc: Mark Brown , jpoimboe@redhat.com, chenzhongjin@huawei.com, mark.rutland@arm.com, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 09/20] objtool: arm64: Implement command to invoke the decoder Message-ID: References: <20220524001637.1707472-1-madvenka@linux.microsoft.com> <20220524001637.1707472-10-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 29, 2022 at 09:49:44AM -0500, Madhavan T. Venkataraman wrote: > > > On 5/24/22 09:09, Mark Brown wrote: > > On Mon, May 23, 2022 at 07:16:26PM -0500, madvenka@linux.microsoft.com wrote: > >> From: "Madhavan T. Venkataraman" > >> > >> Implement a built-in command called cmd_fpv() that can be invoked as > >> follows: > >> > >> objtool fpv generate file.o > >> > >> The built-in command invokes decode_instructions() to walk each function > >> and decode the instructions of the function. > > > > In commit b51277eb9775ce91 ("objtool: Ditch subcommands") Josh removed > > subcommands so this interface is going to need a rethink. > > Thanks for mentioning this. I will sync my patchset to the latest and send out version 3. Before you do; why are you duplicating lots of validate_branch() ? Why can't you use the regular code to generate ORC data? I'm really not happy about all this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA7C5C433EF for ; Mon, 30 May 2022 07:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MqLm0J/JIdATlD95uunaJCb/dF7giMLSVd826tMQDD8=; b=KsiH5tsjQhkbin PL9L8gDGk1qKIE+OkEWH+Y89IHxTGoxeizUK0+TCedoMf7zl7zZhOPLETLkuKnC6B+diT8WQIykdh UGXUbbgvpF+uVAYQnW/RZdz2KUtitUMi0J6X9KXwVMVrzsC98+2Ss0gPlFsDdZBWsevKxO2REBYKs IH5S2ChOLP2AVi67DctBlEEjs4d9IkvrbU596quoH1jOdQX1LXNz+LkckVsfHJq03k7BwRckBII51 cA3u8K/u3O4AEtLGBUjdgLy0CUI89cyUaCYxYi3OwwQ24ICXzlGrxTXcuVdqlgMSvhC00dAsFt7PU hwsb9ZgbBj2xXvK17j3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvaC7-005mMk-W5; Mon, 30 May 2022 07:52:08 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvaC5-005mJW-LF for linux-arm-kernel@bombadil.infradead.org; Mon, 30 May 2022 07:52:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PA/t+O0nJ8ZID3NeeJjW9bADPDFRaoAD2wrlnvNm2Fc=; b=JA05FiD+94Y9SDtuOfX8qU7/8b jQWH1UQ/LOU5p+OQy7OXowgT92X1PEDMGFn8eOHLmFZ5jNS3dia/BQzM8friSrCqpcyAwXOeq/bGA Sdh8fWGD3zvA1fweBQ/SVTvosAAa+0/lrhlLUJna7Oj38RVccmcXxeTnUG2kp4q45U41H9UrZoO3V J7MkpFmGQKV2c/RYPw4NuksF7YmyZduE7aIimfAS9vxjrv/3eLJ6nenDMKXzCULjpF8W2wLvwh5AX fW9xxzVa9+BLNQQWyDwveVUtRVkTHaQQA5sDLJEj1ckFQVAUzlF9MJRKxmzMJD3t4X9n02wa52bep ntxwAg7A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nvaC0-004I5j-7g; Mon, 30 May 2022 07:52:00 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 0B9AC980DE7; Mon, 30 May 2022 09:51:58 +0200 (CEST) Date: Mon, 30 May 2022 09:51:57 +0200 From: Peter Zijlstra To: "Madhavan T. Venkataraman" Cc: Mark Brown , jpoimboe@redhat.com, chenzhongjin@huawei.com, mark.rutland@arm.com, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jamorris@linux.microsoft.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 09/20] objtool: arm64: Implement command to invoke the decoder Message-ID: References: <20220524001637.1707472-1-madvenka@linux.microsoft.com> <20220524001637.1707472-10-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 29, 2022 at 09:49:44AM -0500, Madhavan T. Venkataraman wrote: > > > On 5/24/22 09:09, Mark Brown wrote: > > On Mon, May 23, 2022 at 07:16:26PM -0500, madvenka@linux.microsoft.com wrote: > >> From: "Madhavan T. Venkataraman" > >> > >> Implement a built-in command called cmd_fpv() that can be invoked as > >> follows: > >> > >> objtool fpv generate file.o > >> > >> The built-in command invokes decode_instructions() to walk each function > >> and decode the instructions of the function. > > > > In commit b51277eb9775ce91 ("objtool: Ditch subcommands") Josh removed > > subcommands so this interface is going to need a rethink. > > Thanks for mentioning this. I will sync my patchset to the latest and send out version 3. Before you do; why are you duplicating lots of validate_branch() ? Why can't you use the regular code to generate ORC data? I'm really not happy about all this. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel