From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE3E5CCA477 for ; Wed, 1 Jun 2022 17:25:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353700AbiFARZi (ORCPT ); Wed, 1 Jun 2022 13:25:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345750AbiFARZh (ORCPT ); Wed, 1 Jun 2022 13:25:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D115937AB4; Wed, 1 Jun 2022 10:25:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 162C4615F9; Wed, 1 Jun 2022 17:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 301D1C385A5; Wed, 1 Jun 2022 17:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654104334; bh=jMMe7B3BhgdISh7uct3BKpjV+FPEgE6gFytMtHtHl0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHO+qMWQe5cP8tmgUQqj8fPGjJwS3Otgz+OXIEdGPVJSradD7wwZvicTh/XeTN6xn 36cftZjh2U4vxTC907inz6H2ofvk+02etbYJZRSA3kWg1Zraq122z9y1G6zY5uAzjM 9xDC4IBmiXmiVoI5M28u6BmC46gm/t04m9/d3Uk738NKcetPPZ1x+AIx5ihXth0Frb Ch9UusaL6Sktiv1EghEBMMueZ59I77EcbHnOJL4/Jl32ORyzuRmi00q7R572WE5XOK /zF9VgHnpoTDGhq77ORqvchBakQOe3gxA1stj2MKAJaA3beP0uvbuDT0szSX/KVl+i ui6hmrXqhf3Iw== Date: Wed, 1 Jun 2022 10:25:31 -0700 From: Nathan Chancellor To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful Message-ID: References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220404050559.132378-10-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org Hi Christoph, On Mon, Apr 04, 2022 at 07:05:53AM +0200, Christoph Hellwig wrote: > Pass a bool to pass if swiotlb needs to be enabled based on the > addressing needs and replace the verbose argument with a set of > flags, including one to force enable bounce buffering. > > Note that this patch removes the possibility to force xen-swiotlb > use using swiotlb=force on the command line on x86 (arm and arm64 > never supported that), but this interface will be restored shortly. > > Signed-off-by: Christoph Hellwig I bisected a performance regression in WSL2 to this change as commit c6af2aa9ffc9 ("swiotlb: make the swiotlb_init interface more useful") in mainline (bisect log below). I initially noticed it because accessing the Windows filesystem through the /mnt/c mount is about 40x slower if I am doing my math right based on the benchmarks below. Before: $ uname -r; and hyperfine "ls -l /mnt/c/Users/natec/Downloads" 5.18.0-rc3-microsoft-standard-WSL2-00008-ga3e230926708 Benchmark 1: ls -l /mnt/c/Users/natec/Downloads Time (mean ± σ): 564.5 ms ± 24.1 ms [User: 2.5 ms, System: 130.3 ms] Range (min … max): 510.2 ms … 588.0 ms 10 runs After $ uname -r; and hyperfine "ls -l /mnt/c/Users/natec/Downloads" 5.18.0-rc3-microsoft-standard-WSL2-00009-gc6af2aa9ffc9 Benchmark 1: ls -l /mnt/c/Users/natec/Downloads Time (mean ± σ): 23.282 s ± 1.220 s [User: 0.013 s, System: 0.101 s] Range (min … max): 21.793 s … 25.317 s 10 runs I do see 'swiotlb=force' on the cmdline: $ cat /proc/cmdline initrd=\initrd.img panic=-1 nr_cpus=8 swiotlb=force earlycon=uart8250,io,0x3f8,115200 console=hvc0 debug pty.legacy_count=0 /mnt/c appears to be a 9p mount, not sure if that is relevant here: $ mount &| grep /mnt/c drvfs on /mnt/c type 9p (rw,noatime,dirsync,aname=drvfs;path=C:\;uid=1000;gid=1000;symlinkroot=/mnt/,mmap,access=client,msize=262144,trans=virtio) If there is any other information I can provide, please let me know. Cheers, Nathan # bad: [700170bf6b4d773e328fa54ebb70ba444007c702] Merge tag 'nfs-for-5.19-1' of git://git.linux-nfs.org/projects/anna/linux-nfs # good: [4b0986a3613c92f4ec1bdc7f60ec66fea135991f] Linux 5.18 git bisect start '700170bf6b4d773e328fa54ebb70ba444007c702' 'v5.18' # good: [86c87bea6b42100c67418af690919c44de6ede6e] Merge tag 'devicetree-for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux git bisect good 86c87bea6b42100c67418af690919c44de6ede6e # bad: [ae862183285cbb2ef9032770d98ffa9becffe9d5] Merge tag 'arm-dt-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc git bisect bad ae862183285cbb2ef9032770d98ffa9becffe9d5 # good: [2518f226c60d8e04d18ba4295500a5b0b8ac7659] Merge tag 'drm-next-2022-05-25' of git://anongit.freedesktop.org/drm/drm git bisect good 2518f226c60d8e04d18ba4295500a5b0b8ac7659 # bad: [babf0bb978e3c9fce6c4eba6b744c8754fd43d8e] Merge tag 'xfs-5.19-for-linus' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux git bisect bad babf0bb978e3c9fce6c4eba6b744c8754fd43d8e # good: [beed983621fbdfd291e6e3a0cdc4d10517e60af8] ASoC: Intel: avs: Machine board registration git bisect good beed983621fbdfd291e6e3a0cdc4d10517e60af8 # good: [fbe86daca0ba878b04fa241b85e26e54d17d4229] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi git bisect good fbe86daca0ba878b04fa241b85e26e54d17d4229 # good: [166afc45ed5523298541fd0297f9ad585cc2708c] Merge tag 'reflink-speedups-5.19_2022-04-28' of git://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux into xfs-5.19-for-next git bisect good 166afc45ed5523298541fd0297f9ad585cc2708c # bad: [e375780b631a5fc2a61a3b4fa12429255361a31e] Merge tag 'fsnotify_for_v5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs git bisect bad e375780b631a5fc2a61a3b4fa12429255361a31e # bad: [4a37f3dd9a83186cb88d44808ab35b78375082c9] dma-direct: don't over-decrypt memory git bisect bad 4a37f3dd9a83186cb88d44808ab35b78375082c9 # bad: [742519538e6b07250c8085bbff4bd358bc03bf16] swiotlb: pass a gfp_mask argument to swiotlb_init_late git bisect bad 742519538e6b07250c8085bbff4bd358bc03bf16 # good: [9bbe7a7fc126e3d14fefa4b035854aba080926d9] arm/xen: don't check for xen_initial_domain() in xen_create_contiguous_region git bisect good 9bbe7a7fc126e3d14fefa4b035854aba080926d9 # good: [a3e230926708125205ffd06d3dc2175a8263ae7e] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled git bisect good a3e230926708125205ffd06d3dc2175a8263ae7e # bad: [8ba2ed1be90fc210126f68186564707478552c95] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction git bisect bad 8ba2ed1be90fc210126f68186564707478552c95 # bad: [c6af2aa9ffc9763826607bc2664ef3ea4475ed18] swiotlb: make the swiotlb_init interface more useful git bisect bad c6af2aa9ffc9763826607bc2664ef3ea4475ed18 # first bad commit: [c6af2aa9ffc9763826607bc2664ef3ea4475ed18] swiotlb: make the swiotlb_init interface more useful From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CB98C43334 for ; Wed, 1 Jun 2022 17:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zSW1OVFH5oqLkjTZH1IsBW2MTV8WgVakUMLdg9PnK6A=; b=SLhvB0sdIJtIVk waDyfipOrDgsSHrmGGAYfp8gxUoG5LThu1UmfrlcJNn+9dGM4OExqV315IVkl1xRfGxUnbRgND/4u bQevaDWB1objJAkQ7sWueXZVOlfFG3kmQCERzA5Kl0r/LSpVHVnL+ijyULan7Ttvyr6TQYBlMvClM gOYC0N5DBeCEeRE1HulStcVWSZ7eGjLKpUmSF3W8nKiHJ0m/vYDdsY7cTO6afPquW+op9pwPjE1sx jxl0Ocxt0UTF5qV19kVNwfTLdbwqmNSDPFaV/UeQXgfaG0maLBvGVfmq3IU73OQb7anPVvq5h12XX iaRYSnxiyvsiGtjNxBmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwS6O-00HHu0-RE; Wed, 01 Jun 2022 17:25:48 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwS6E-00HHpn-4P; Wed, 01 Jun 2022 17:25:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA5C2B81BC3; Wed, 1 Jun 2022 17:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 301D1C385A5; Wed, 1 Jun 2022 17:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654104334; bh=jMMe7B3BhgdISh7uct3BKpjV+FPEgE6gFytMtHtHl0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHO+qMWQe5cP8tmgUQqj8fPGjJwS3Otgz+OXIEdGPVJSradD7wwZvicTh/XeTN6xn 36cftZjh2U4vxTC907inz6H2ofvk+02etbYJZRSA3kWg1Zraq122z9y1G6zY5uAzjM 9xDC4IBmiXmiVoI5M28u6BmC46gm/t04m9/d3Uk738NKcetPPZ1x+AIx5ihXth0Frb Ch9UusaL6Sktiv1EghEBMMueZ59I77EcbHnOJL4/Jl32ORyzuRmi00q7R572WE5XOK /zF9VgHnpoTDGhq77ORqvchBakQOe3gxA1stj2MKAJaA3beP0uvbuDT0szSX/KVl+i ui6hmrXqhf3Iw== Date: Wed, 1 Jun 2022 10:25:31 -0700 From: Nathan Chancellor To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful Message-ID: References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-10-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220404050559.132378-10-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_102538_502410_CB0BCA7C X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgQ2hyaXN0b3BoLAoKT24gTW9uLCBBcHIgMDQsIDIwMjIgYXQgMDc6MDU6NTNBTSArMDIwMCwg Q2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gUGFzcyBhIGJvb2wgdG8gcGFzcyBpZiBzd2lvdGxi IG5lZWRzIHRvIGJlIGVuYWJsZWQgYmFzZWQgb24gdGhlCj4gYWRkcmVzc2luZyBuZWVkcyBhbmQg cmVwbGFjZSB0aGUgdmVyYm9zZSBhcmd1bWVudCB3aXRoIGEgc2V0IG9mCj4gZmxhZ3MsIGluY2x1 ZGluZyBvbmUgdG8gZm9yY2UgZW5hYmxlIGJvdW5jZSBidWZmZXJpbmcuCj4gCj4gTm90ZSB0aGF0 IHRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUgcG9zc2liaWxpdHkgdG8gZm9yY2UgeGVuLXN3aW90bGIK PiB1c2UgdXNpbmcgc3dpb3RsYj1mb3JjZSBvbiB0aGUgY29tbWFuZCBsaW5lIG9uIHg4NiAoYXJt IGFuZCBhcm02NAo+IG5ldmVyIHN1cHBvcnRlZCB0aGF0KSwgYnV0IHRoaXMgaW50ZXJmYWNlIHdp bGwgYmUgcmVzdG9yZWQgc2hvcnRseS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVs bHdpZyA8aGNoQGxzdC5kZT4KCkkgYmlzZWN0ZWQgYSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIGlu IFdTTDIgdG8gdGhpcyBjaGFuZ2UgYXMgY29tbWl0CmM2YWYyYWE5ZmZjOSAoInN3aW90bGI6IG1h a2UgdGhlIHN3aW90bGJfaW5pdCBpbnRlcmZhY2UgbW9yZSB1c2VmdWwiKSBpbgptYWlubGluZSAo YmlzZWN0IGxvZyBiZWxvdykuIEkgaW5pdGlhbGx5IG5vdGljZWQgaXQgYmVjYXVzZSBhY2Nlc3Np bmcgdGhlCldpbmRvd3MgZmlsZXN5c3RlbSB0aHJvdWdoIHRoZSAvbW50L2MgbW91bnQgaXMgYWJv dXQgNDB4IHNsb3dlciBpZiBJIGFtIGRvaW5nCm15IG1hdGggcmlnaHQgYmFzZWQgb24gdGhlIGJl bmNobWFya3MgYmVsb3cuCgpCZWZvcmU6CgokIHVuYW1lIC1yOyBhbmQgaHlwZXJmaW5lICJscyAt bCAvbW50L2MvVXNlcnMvbmF0ZWMvRG93bmxvYWRzIgo1LjE4LjAtcmMzLW1pY3Jvc29mdC1zdGFu ZGFyZC1XU0wyLTAwMDA4LWdhM2UyMzA5MjY3MDgKQmVuY2htYXJrIDE6IGxzIC1sIC9tbnQvYy9V c2Vycy9uYXRlYy9Eb3dubG9hZHMKICBUaW1lIChtZWFuIMKxIM+DKTogICAgIDU2NC41IG1zIMKx ICAyNC4xIG1zICAgIFtVc2VyOiAyLjUgbXMsIFN5c3RlbTogMTMwLjMgbXNdCiAgUmFuZ2UgKG1p biDigKYgbWF4KTogICA1MTAuMiBtcyDigKYgNTg4LjAgbXMgICAgMTAgcnVucwoKQWZ0ZXIKCiQg dW5hbWUgLXI7IGFuZCBoeXBlcmZpbmUgImxzIC1sIC9tbnQvYy9Vc2Vycy9uYXRlYy9Eb3dubG9h ZHMiCjUuMTguMC1yYzMtbWljcm9zb2Z0LXN0YW5kYXJkLVdTTDItMDAwMDktZ2M2YWYyYWE5ZmZj OQpCZW5jaG1hcmsgMTogbHMgLWwgL21udC9jL1VzZXJzL25hdGVjL0Rvd25sb2FkcwogIFRpbWUg KG1lYW4gwrEgz4MpOiAgICAgMjMuMjgyIHMgwrEgIDEuMjIwIHMgICAgW1VzZXI6IDAuMDEzIHMs IFN5c3RlbTogMC4xMDEgc10KICBSYW5nZSAobWluIOKApiBtYXgpOiAgIDIxLjc5MyBzIOKApiAy NS4zMTcgcyAgICAxMCBydW5zCgpJIGRvIHNlZSAnc3dpb3RsYj1mb3JjZScgb24gdGhlIGNtZGxp bmU6CgokIGNhdCAvcHJvYy9jbWRsaW5lCmluaXRyZD1caW5pdHJkLmltZyBwYW5pYz0tMSBucl9j cHVzPTggc3dpb3RsYj1mb3JjZSBlYXJseWNvbj11YXJ0ODI1MCxpbywweDNmOCwxMTUyMDAgY29u c29sZT1odmMwIGRlYnVnIHB0eS5sZWdhY3lfY291bnQ9MAoKL21udC9jIGFwcGVhcnMgdG8gYmUg YSA5cCBtb3VudCwgbm90IHN1cmUgaWYgdGhhdCBpcyByZWxldmFudCBoZXJlOgoKJCBtb3VudCAm fCBncmVwIC9tbnQvYwpkcnZmcyBvbiAvbW50L2MgdHlwZSA5cCAocncsbm9hdGltZSxkaXJzeW5j LGFuYW1lPWRydmZzO3BhdGg9QzpcO3VpZD0xMDAwO2dpZD0xMDAwO3N5bWxpbmtyb290PS9tbnQv LG1tYXAsYWNjZXNzPWNsaWVudCxtc2l6ZT0yNjIxNDQsdHJhbnM9dmlydGlvKQoKSWYgdGhlcmUg aXMgYW55IG90aGVyIGluZm9ybWF0aW9uIEkgY2FuIHByb3ZpZGUsIHBsZWFzZSBsZXQgbWUga25v dy4KCkNoZWVycywKTmF0aGFuCgojIGJhZDogWzcwMDE3MGJmNmI0ZDc3M2UzMjhmYTU0ZWJiNzBi YTQ0NDAwN2M3MDJdIE1lcmdlIHRhZyAnbmZzLWZvci01LjE5LTEnIG9mIGdpdDovL2dpdC5saW51 eC1uZnMub3JnL3Byb2plY3RzL2FubmEvbGludXgtbmZzCiMgZ29vZDogWzRiMDk4NmEzNjEzYzky ZjRlYzFiZGM3ZjYwZWM2NmZlYTEzNTk5MWZdIExpbnV4IDUuMTgKZ2l0IGJpc2VjdCBzdGFydCAn NzAwMTcwYmY2YjRkNzczZTMyOGZhNTRlYmI3MGJhNDQ0MDA3YzcwMicgJ3Y1LjE4JwojIGdvb2Q6 IFs4NmM4N2JlYTZiNDIxMDBjNjc0MThhZjY5MDkxOWM0NGRlNmVkZTZlXSBNZXJnZSB0YWcgJ2Rl dmljZXRyZWUtZm9yLTUuMTknIG9mIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgv a2VybmVsL2dpdC9yb2JoL2xpbnV4CmdpdCBiaXNlY3QgZ29vZCA4NmM4N2JlYTZiNDIxMDBjNjc0 MThhZjY5MDkxOWM0NGRlNmVkZTZlCiMgYmFkOiBbYWU4NjIxODMyODVjYmIyZWY5MDMyNzcwZDk4 ZmZhOWJlY2ZmZTlkNV0gTWVyZ2UgdGFnICdhcm0tZHQtNS4xOScgb2YgZ2l0Oi8vZ2l0Lmtlcm5l bC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3NvYy9zb2MKZ2l0IGJpc2VjdCBiYWQgYWU4 NjIxODMyODVjYmIyZWY5MDMyNzcwZDk4ZmZhOWJlY2ZmZTlkNQojIGdvb2Q6IFsyNTE4ZjIyNmM2 MGQ4ZTA0ZDE4YmE0Mjk1NTAwYTViMGI4YWM3NjU5XSBNZXJnZSB0YWcgJ2RybS1uZXh0LTIwMjIt MDUtMjUnIG9mIGdpdDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL2RybS9kcm0KZ2l0IGJpc2Vj dCBnb29kIDI1MThmMjI2YzYwZDhlMDRkMThiYTQyOTU1MDBhNWIwYjhhYzc2NTkKIyBiYWQ6IFti YWJmMGJiOTc4ZTNjOWZjZTZjNGViYTZiNzQ0Yzg3NTRmZDQzZDhlXSBNZXJnZSB0YWcgJ3hmcy01 LjE5LWZvci1saW51cycgb2YgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9mcy94ZnMveGZz LWxpbnV4CmdpdCBiaXNlY3QgYmFkIGJhYmYwYmI5NzhlM2M5ZmNlNmM0ZWJhNmI3NDRjODc1NGZk NDNkOGUKIyBnb29kOiBbYmVlZDk4MzYyMWZiZGZkMjkxZTZlM2EwY2RjNGQxMDUxN2U2MGFmOF0g QVNvQzogSW50ZWw6IGF2czogTWFjaGluZSBib2FyZCByZWdpc3RyYXRpb24KZ2l0IGJpc2VjdCBn b29kIGJlZWQ5ODM2MjFmYmRmZDI5MWU2ZTNhMGNkYzRkMTA1MTdlNjBhZjgKIyBnb29kOiBbZmJl ODZkYWNhMGJhODc4YjA0ZmEyNDFiODVlMjZlNTRkMTdkNDIyOV0gTWVyZ2UgdGFnICdzY3NpLW1p c2MnIG9mIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9qZWpi L3Njc2kKZ2l0IGJpc2VjdCBnb29kIGZiZTg2ZGFjYTBiYTg3OGIwNGZhMjQxYjg1ZTI2ZTU0ZDE3 ZDQyMjkKIyBnb29kOiBbMTY2YWZjNDVlZDU1MjMyOTg1NDFmZDAyOTdmOWFkNTg1Y2MyNzA4Y10g TWVyZ2UgdGFnICdyZWZsaW5rLXNwZWVkdXBzLTUuMTlfMjAyMi0wNC0yOCcgb2YgZ2l0Oi8vZ2l0 Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2Rqd29uZy94ZnMtbGludXggaW50 byB4ZnMtNS4xOS1mb3ItbmV4dApnaXQgYmlzZWN0IGdvb2QgMTY2YWZjNDVlZDU1MjMyOTg1NDFm ZDAyOTdmOWFkNTg1Y2MyNzA4YwojIGJhZDogW2UzNzU3ODBiNjMxYTVmYzJhNjFhM2I0ZmExMjQy OTI1NTM2MWEzMWVdIE1lcmdlIHRhZyAnZnNub3RpZnlfZm9yX3Y1LjE5LXJjMScgb2YgZ2l0Oi8v Z2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2phY2svbGludXgtZnMKZ2l0 IGJpc2VjdCBiYWQgZTM3NTc4MGI2MzFhNWZjMmE2MWEzYjRmYTEyNDI5MjU1MzYxYTMxZQojIGJh ZDogWzRhMzdmM2RkOWE4MzE4NmNiODhkNDQ4MDhhYjM1Yjc4Mzc1MDgyYzldIGRtYS1kaXJlY3Q6 IGRvbid0IG92ZXItZGVjcnlwdCBtZW1vcnkKZ2l0IGJpc2VjdCBiYWQgNGEzN2YzZGQ5YTgzMTg2 Y2I4OGQ0NDgwOGFiMzViNzgzNzUwODJjOQojIGJhZDogWzc0MjUxOTUzOGU2YjA3MjUwYzgwODVi YmZmNGJkMzU4YmMwM2JmMTZdIHN3aW90bGI6IHBhc3MgYSBnZnBfbWFzayBhcmd1bWVudCB0byBz d2lvdGxiX2luaXRfbGF0ZQpnaXQgYmlzZWN0IGJhZCA3NDI1MTk1MzhlNmIwNzI1MGM4MDg1YmJm ZjRiZDM1OGJjMDNiZjE2CiMgZ29vZDogWzliYmU3YTdmYzEyNmUzZDE0ZmVmYTRiMDM1ODU0YWJh MDgwOTI2ZDldIGFybS94ZW46IGRvbid0IGNoZWNrIGZvciB4ZW5faW5pdGlhbF9kb21haW4oKSBp biB4ZW5fY3JlYXRlX2NvbnRpZ3VvdXNfcmVnaW9uCmdpdCBiaXNlY3QgZ29vZCA5YmJlN2E3ZmMx MjZlM2QxNGZlZmE0YjAzNTg1NGFiYTA4MDkyNmQ5CiMgZ29vZDogW2EzZTIzMDkyNjcwODEyNTIw NWZmZDA2ZDNkYzIxNzVhODI2M2FlN2VdIHg4NjogY2VudHJhbGl6ZSBzZXR0aW5nIFNXSU9UTEJf Rk9SQ0Ugd2hlbiBndWVzdCBtZW1vcnkgZW5jcnlwdGlvbiBpcyBlbmFibGVkCmdpdCBiaXNlY3Qg Z29vZCBhM2UyMzA5MjY3MDgxMjUyMDVmZmQwNmQzZGMyMTc1YTgyNjNhZTdlCiMgYmFkOiBbOGJh MmVkMWJlOTBmYzIxMDEyNmY2ODE4NjU2NDcwNzQ3ODU1MmM5NV0gc3dpb3RsYjogYWRkIGEgU1dJ T1RMQl9BTlkgZmxhZyB0byBsaWZ0IHRoZSBsb3cgbWVtb3J5IHJlc3RyaWN0aW9uCmdpdCBiaXNl Y3QgYmFkIDhiYTJlZDFiZTkwZmMyMTAxMjZmNjgxODY1NjQ3MDc0Nzg1NTJjOTUKIyBiYWQ6IFtj NmFmMmFhOWZmYzk3NjM4MjY2MDdiYzI2NjRlZjNlYTQ0NzVlZDE4XSBzd2lvdGxiOiBtYWtlIHRo ZSBzd2lvdGxiX2luaXQgaW50ZXJmYWNlIG1vcmUgdXNlZnVsCmdpdCBiaXNlY3QgYmFkIGM2YWYy YWE5ZmZjOTc2MzgyNjYwN2JjMjY2NGVmM2VhNDQ3NWVkMTgKIyBmaXJzdCBiYWQgY29tbWl0OiBb YzZhZjJhYTlmZmM5NzYzODI2NjA3YmMyNjY0ZWYzZWE0NDc1ZWQxOF0gc3dpb3RsYjogbWFrZSB0 aGUgc3dpb3RsYl9pbml0IGludGVyZmFjZSBtb3JlIHVzZWZ1bAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0Cmxp bnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D1ACC43334 for ; Wed, 1 Jun 2022 17:26:17 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LCwzW5Tndz3c8M for ; Thu, 2 Jun 2022 03:26:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=GHO+qMWQ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=nathan@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=GHO+qMWQ; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LCwyq3SVCz3bl7 for ; Thu, 2 Jun 2022 03:25:39 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA5C2B81BC3; Wed, 1 Jun 2022 17:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 301D1C385A5; Wed, 1 Jun 2022 17:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654104334; bh=jMMe7B3BhgdISh7uct3BKpjV+FPEgE6gFytMtHtHl0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHO+qMWQe5cP8tmgUQqj8fPGjJwS3Otgz+OXIEdGPVJSradD7wwZvicTh/XeTN6xn 36cftZjh2U4vxTC907inz6H2ofvk+02etbYJZRSA3kWg1Zraq122z9y1G6zY5uAzjM 9xDC4IBmiXmiVoI5M28u6BmC46gm/t04m9/d3Uk738NKcetPPZ1x+AIx5ihXth0Frb Ch9UusaL6Sktiv1EghEBMMueZ59I77EcbHnOJL4/Jl32ORyzuRmi00q7R572WE5XOK /zF9VgHnpoTDGhq77ORqvchBakQOe3gxA1stj2MKAJaA3beP0uvbuDT0szSX/KVl+i ui6hmrXqhf3Iw== Date: Wed, 1 Jun 2022 10:25:31 -0700 From: Nathan Chancellor To: Christoph Hellwig Subject: Re: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful Message-ID: References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220404050559.132378-10-hch@lst.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Stefano Stabellini , Joerg Roedel , Konrad Rzeszutek Wilk , tboot-devel@lists.sourceforge.net, xen-devel@lists.xenproject.org, David Woodhouse , Tom Lendacky , Anshuman Khandual , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, Juergen Gross , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy , Lu Baolu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christoph, On Mon, Apr 04, 2022 at 07:05:53AM +0200, Christoph Hellwig wrote: > Pass a bool to pass if swiotlb needs to be enabled based on the > addressing needs and replace the verbose argument with a set of > flags, including one to force enable bounce buffering. > > Note that this patch removes the possibility to force xen-swiotlb > use using swiotlb=force on the command line on x86 (arm and arm64 > never supported that), but this interface will be restored shortly. > > Signed-off-by: Christoph Hellwig I bisected a performance regression in WSL2 to this change as commit c6af2aa9ffc9 ("swiotlb: make the swiotlb_init interface more useful") in mainline (bisect log below). I initially noticed it because accessing the Windows filesystem through the /mnt/c mount is about 40x slower if I am doing my math right based on the benchmarks below. Before: $ uname -r; and hyperfine "ls -l /mnt/c/Users/natec/Downloads" 5.18.0-rc3-microsoft-standard-WSL2-00008-ga3e230926708 Benchmark 1: ls -l /mnt/c/Users/natec/Downloads Time (mean ± σ): 564.5 ms ± 24.1 ms [User: 2.5 ms, System: 130.3 ms] Range (min … max): 510.2 ms … 588.0 ms 10 runs After $ uname -r; and hyperfine "ls -l /mnt/c/Users/natec/Downloads" 5.18.0-rc3-microsoft-standard-WSL2-00009-gc6af2aa9ffc9 Benchmark 1: ls -l /mnt/c/Users/natec/Downloads Time (mean ± σ): 23.282 s ± 1.220 s [User: 0.013 s, System: 0.101 s] Range (min … max): 21.793 s … 25.317 s 10 runs I do see 'swiotlb=force' on the cmdline: $ cat /proc/cmdline initrd=\initrd.img panic=-1 nr_cpus=8 swiotlb=force earlycon=uart8250,io,0x3f8,115200 console=hvc0 debug pty.legacy_count=0 /mnt/c appears to be a 9p mount, not sure if that is relevant here: $ mount &| grep /mnt/c drvfs on /mnt/c type 9p (rw,noatime,dirsync,aname=drvfs;path=C:\;uid=1000;gid=1000;symlinkroot=/mnt/,mmap,access=client,msize=262144,trans=virtio) If there is any other information I can provide, please let me know. Cheers, Nathan # bad: [700170bf6b4d773e328fa54ebb70ba444007c702] Merge tag 'nfs-for-5.19-1' of git://git.linux-nfs.org/projects/anna/linux-nfs # good: [4b0986a3613c92f4ec1bdc7f60ec66fea135991f] Linux 5.18 git bisect start '700170bf6b4d773e328fa54ebb70ba444007c702' 'v5.18' # good: [86c87bea6b42100c67418af690919c44de6ede6e] Merge tag 'devicetree-for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux git bisect good 86c87bea6b42100c67418af690919c44de6ede6e # bad: [ae862183285cbb2ef9032770d98ffa9becffe9d5] Merge tag 'arm-dt-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc git bisect bad ae862183285cbb2ef9032770d98ffa9becffe9d5 # good: [2518f226c60d8e04d18ba4295500a5b0b8ac7659] Merge tag 'drm-next-2022-05-25' of git://anongit.freedesktop.org/drm/drm git bisect good 2518f226c60d8e04d18ba4295500a5b0b8ac7659 # bad: [babf0bb978e3c9fce6c4eba6b744c8754fd43d8e] Merge tag 'xfs-5.19-for-linus' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux git bisect bad babf0bb978e3c9fce6c4eba6b744c8754fd43d8e # good: [beed983621fbdfd291e6e3a0cdc4d10517e60af8] ASoC: Intel: avs: Machine board registration git bisect good beed983621fbdfd291e6e3a0cdc4d10517e60af8 # good: [fbe86daca0ba878b04fa241b85e26e54d17d4229] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi git bisect good fbe86daca0ba878b04fa241b85e26e54d17d4229 # good: [166afc45ed5523298541fd0297f9ad585cc2708c] Merge tag 'reflink-speedups-5.19_2022-04-28' of git://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux into xfs-5.19-for-next git bisect good 166afc45ed5523298541fd0297f9ad585cc2708c # bad: [e375780b631a5fc2a61a3b4fa12429255361a31e] Merge tag 'fsnotify_for_v5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs git bisect bad e375780b631a5fc2a61a3b4fa12429255361a31e # bad: [4a37f3dd9a83186cb88d44808ab35b78375082c9] dma-direct: don't over-decrypt memory git bisect bad 4a37f3dd9a83186cb88d44808ab35b78375082c9 # bad: [742519538e6b07250c8085bbff4bd358bc03bf16] swiotlb: pass a gfp_mask argument to swiotlb_init_late git bisect bad 742519538e6b07250c8085bbff4bd358bc03bf16 # good: [9bbe7a7fc126e3d14fefa4b035854aba080926d9] arm/xen: don't check for xen_initial_domain() in xen_create_contiguous_region git bisect good 9bbe7a7fc126e3d14fefa4b035854aba080926d9 # good: [a3e230926708125205ffd06d3dc2175a8263ae7e] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled git bisect good a3e230926708125205ffd06d3dc2175a8263ae7e # bad: [8ba2ed1be90fc210126f68186564707478552c95] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction git bisect bad 8ba2ed1be90fc210126f68186564707478552c95 # bad: [c6af2aa9ffc9763826607bc2664ef3ea4475ed18] swiotlb: make the swiotlb_init interface more useful git bisect bad c6af2aa9ffc9763826607bc2664ef3ea4475ed18 # first bad commit: [c6af2aa9ffc9763826607bc2664ef3ea4475ed18] swiotlb: make the swiotlb_init interface more useful From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD981C433EF for ; Wed, 1 Jun 2022 17:25:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7E828405B1; Wed, 1 Jun 2022 17:25:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WQE-Sl-BrOqT; Wed, 1 Jun 2022 17:25:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 4D0AD400B8; Wed, 1 Jun 2022 17:25:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 09253C0039; Wed, 1 Jun 2022 17:25:42 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D3158C002D for ; Wed, 1 Jun 2022 17:25:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BB251417AE for ; Wed, 1 Jun 2022 17:25:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4-qgF4RKOpt7 for ; Wed, 1 Jun 2022 17:25:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp4.osuosl.org (Postfix) with ESMTPS id 59D2B417A8 for ; Wed, 1 Jun 2022 17:25:39 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA5C2B81BC3; Wed, 1 Jun 2022 17:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 301D1C385A5; Wed, 1 Jun 2022 17:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654104334; bh=jMMe7B3BhgdISh7uct3BKpjV+FPEgE6gFytMtHtHl0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHO+qMWQe5cP8tmgUQqj8fPGjJwS3Otgz+OXIEdGPVJSradD7wwZvicTh/XeTN6xn 36cftZjh2U4vxTC907inz6H2ofvk+02etbYJZRSA3kWg1Zraq122z9y1G6zY5uAzjM 9xDC4IBmiXmiVoI5M28u6BmC46gm/t04m9/d3Uk738NKcetPPZ1x+AIx5ihXth0Frb Ch9UusaL6Sktiv1EghEBMMueZ59I77EcbHnOJL4/Jl32ORyzuRmi00q7R572WE5XOK /zF9VgHnpoTDGhq77ORqvchBakQOe3gxA1stj2MKAJaA3beP0uvbuDT0szSX/KVl+i ui6hmrXqhf3Iw== Date: Wed, 1 Jun 2022 10:25:31 -0700 From: Nathan Chancellor To: Christoph Hellwig Subject: Re: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful Message-ID: References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-10-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220404050559.132378-10-hch@lst.de> Cc: linux-hyperv@vger.kernel.org, x86@kernel.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, Stefano Stabellini , Konrad Rzeszutek Wilk , tboot-devel@lists.sourceforge.net, xen-devel@lists.xenproject.org, David Woodhouse , Tom Lendacky , Anshuman Khandual , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, Juergen Gross , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, iommu@lists.linux-foundation.org, Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgQ2hyaXN0b3BoLAoKT24gTW9uLCBBcHIgMDQsIDIwMjIgYXQgMDc6MDU6NTNBTSArMDIwMCwg Q2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gUGFzcyBhIGJvb2wgdG8gcGFzcyBpZiBzd2lvdGxi IG5lZWRzIHRvIGJlIGVuYWJsZWQgYmFzZWQgb24gdGhlCj4gYWRkcmVzc2luZyBuZWVkcyBhbmQg cmVwbGFjZSB0aGUgdmVyYm9zZSBhcmd1bWVudCB3aXRoIGEgc2V0IG9mCj4gZmxhZ3MsIGluY2x1 ZGluZyBvbmUgdG8gZm9yY2UgZW5hYmxlIGJvdW5jZSBidWZmZXJpbmcuCj4gCj4gTm90ZSB0aGF0 IHRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUgcG9zc2liaWxpdHkgdG8gZm9yY2UgeGVuLXN3aW90bGIK PiB1c2UgdXNpbmcgc3dpb3RsYj1mb3JjZSBvbiB0aGUgY29tbWFuZCBsaW5lIG9uIHg4NiAoYXJt IGFuZCBhcm02NAo+IG5ldmVyIHN1cHBvcnRlZCB0aGF0KSwgYnV0IHRoaXMgaW50ZXJmYWNlIHdp bGwgYmUgcmVzdG9yZWQgc2hvcnRseS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVs bHdpZyA8aGNoQGxzdC5kZT4KCkkgYmlzZWN0ZWQgYSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIGlu IFdTTDIgdG8gdGhpcyBjaGFuZ2UgYXMgY29tbWl0CmM2YWYyYWE5ZmZjOSAoInN3aW90bGI6IG1h a2UgdGhlIHN3aW90bGJfaW5pdCBpbnRlcmZhY2UgbW9yZSB1c2VmdWwiKSBpbgptYWlubGluZSAo YmlzZWN0IGxvZyBiZWxvdykuIEkgaW5pdGlhbGx5IG5vdGljZWQgaXQgYmVjYXVzZSBhY2Nlc3Np bmcgdGhlCldpbmRvd3MgZmlsZXN5c3RlbSB0aHJvdWdoIHRoZSAvbW50L2MgbW91bnQgaXMgYWJv dXQgNDB4IHNsb3dlciBpZiBJIGFtIGRvaW5nCm15IG1hdGggcmlnaHQgYmFzZWQgb24gdGhlIGJl bmNobWFya3MgYmVsb3cuCgpCZWZvcmU6CgokIHVuYW1lIC1yOyBhbmQgaHlwZXJmaW5lICJscyAt bCAvbW50L2MvVXNlcnMvbmF0ZWMvRG93bmxvYWRzIgo1LjE4LjAtcmMzLW1pY3Jvc29mdC1zdGFu ZGFyZC1XU0wyLTAwMDA4LWdhM2UyMzA5MjY3MDgKQmVuY2htYXJrIDE6IGxzIC1sIC9tbnQvYy9V c2Vycy9uYXRlYy9Eb3dubG9hZHMKICBUaW1lIChtZWFuIMKxIM+DKTogICAgIDU2NC41IG1zIMKx ICAyNC4xIG1zICAgIFtVc2VyOiAyLjUgbXMsIFN5c3RlbTogMTMwLjMgbXNdCiAgUmFuZ2UgKG1p biDigKYgbWF4KTogICA1MTAuMiBtcyDigKYgNTg4LjAgbXMgICAgMTAgcnVucwoKQWZ0ZXIKCiQg dW5hbWUgLXI7IGFuZCBoeXBlcmZpbmUgImxzIC1sIC9tbnQvYy9Vc2Vycy9uYXRlYy9Eb3dubG9h ZHMiCjUuMTguMC1yYzMtbWljcm9zb2Z0LXN0YW5kYXJkLVdTTDItMDAwMDktZ2M2YWYyYWE5ZmZj OQpCZW5jaG1hcmsgMTogbHMgLWwgL21udC9jL1VzZXJzL25hdGVjL0Rvd25sb2FkcwogIFRpbWUg KG1lYW4gwrEgz4MpOiAgICAgMjMuMjgyIHMgwrEgIDEuMjIwIHMgICAgW1VzZXI6IDAuMDEzIHMs IFN5c3RlbTogMC4xMDEgc10KICBSYW5nZSAobWluIOKApiBtYXgpOiAgIDIxLjc5MyBzIOKApiAy NS4zMTcgcyAgICAxMCBydW5zCgpJIGRvIHNlZSAnc3dpb3RsYj1mb3JjZScgb24gdGhlIGNtZGxp bmU6CgokIGNhdCAvcHJvYy9jbWRsaW5lCmluaXRyZD1caW5pdHJkLmltZyBwYW5pYz0tMSBucl9j cHVzPTggc3dpb3RsYj1mb3JjZSBlYXJseWNvbj11YXJ0ODI1MCxpbywweDNmOCwxMTUyMDAgY29u c29sZT1odmMwIGRlYnVnIHB0eS5sZWdhY3lfY291bnQ9MAoKL21udC9jIGFwcGVhcnMgdG8gYmUg YSA5cCBtb3VudCwgbm90IHN1cmUgaWYgdGhhdCBpcyByZWxldmFudCBoZXJlOgoKJCBtb3VudCAm fCBncmVwIC9tbnQvYwpkcnZmcyBvbiAvbW50L2MgdHlwZSA5cCAocncsbm9hdGltZSxkaXJzeW5j LGFuYW1lPWRydmZzO3BhdGg9QzpcO3VpZD0xMDAwO2dpZD0xMDAwO3N5bWxpbmtyb290PS9tbnQv LG1tYXAsYWNjZXNzPWNsaWVudCxtc2l6ZT0yNjIxNDQsdHJhbnM9dmlydGlvKQoKSWYgdGhlcmUg aXMgYW55IG90aGVyIGluZm9ybWF0aW9uIEkgY2FuIHByb3ZpZGUsIHBsZWFzZSBsZXQgbWUga25v dy4KCkNoZWVycywKTmF0aGFuCgojIGJhZDogWzcwMDE3MGJmNmI0ZDc3M2UzMjhmYTU0ZWJiNzBi YTQ0NDAwN2M3MDJdIE1lcmdlIHRhZyAnbmZzLWZvci01LjE5LTEnIG9mIGdpdDovL2dpdC5saW51 eC1uZnMub3JnL3Byb2plY3RzL2FubmEvbGludXgtbmZzCiMgZ29vZDogWzRiMDk4NmEzNjEzYzky ZjRlYzFiZGM3ZjYwZWM2NmZlYTEzNTk5MWZdIExpbnV4IDUuMTgKZ2l0IGJpc2VjdCBzdGFydCAn NzAwMTcwYmY2YjRkNzczZTMyOGZhNTRlYmI3MGJhNDQ0MDA3YzcwMicgJ3Y1LjE4JwojIGdvb2Q6 IFs4NmM4N2JlYTZiNDIxMDBjNjc0MThhZjY5MDkxOWM0NGRlNmVkZTZlXSBNZXJnZSB0YWcgJ2Rl dmljZXRyZWUtZm9yLTUuMTknIG9mIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgv a2VybmVsL2dpdC9yb2JoL2xpbnV4CmdpdCBiaXNlY3QgZ29vZCA4NmM4N2JlYTZiNDIxMDBjNjc0 MThhZjY5MDkxOWM0NGRlNmVkZTZlCiMgYmFkOiBbYWU4NjIxODMyODVjYmIyZWY5MDMyNzcwZDk4 ZmZhOWJlY2ZmZTlkNV0gTWVyZ2UgdGFnICdhcm0tZHQtNS4xOScgb2YgZ2l0Oi8vZ2l0Lmtlcm5l bC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3NvYy9zb2MKZ2l0IGJpc2VjdCBiYWQgYWU4 NjIxODMyODVjYmIyZWY5MDMyNzcwZDk4ZmZhOWJlY2ZmZTlkNQojIGdvb2Q6IFsyNTE4ZjIyNmM2 MGQ4ZTA0ZDE4YmE0Mjk1NTAwYTViMGI4YWM3NjU5XSBNZXJnZSB0YWcgJ2RybS1uZXh0LTIwMjIt MDUtMjUnIG9mIGdpdDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL2RybS9kcm0KZ2l0IGJpc2Vj dCBnb29kIDI1MThmMjI2YzYwZDhlMDRkMThiYTQyOTU1MDBhNWIwYjhhYzc2NTkKIyBiYWQ6IFti YWJmMGJiOTc4ZTNjOWZjZTZjNGViYTZiNzQ0Yzg3NTRmZDQzZDhlXSBNZXJnZSB0YWcgJ3hmcy01 LjE5LWZvci1saW51cycgb2YgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9mcy94ZnMveGZz LWxpbnV4CmdpdCBiaXNlY3QgYmFkIGJhYmYwYmI5NzhlM2M5ZmNlNmM0ZWJhNmI3NDRjODc1NGZk NDNkOGUKIyBnb29kOiBbYmVlZDk4MzYyMWZiZGZkMjkxZTZlM2EwY2RjNGQxMDUxN2U2MGFmOF0g QVNvQzogSW50ZWw6IGF2czogTWFjaGluZSBib2FyZCByZWdpc3RyYXRpb24KZ2l0IGJpc2VjdCBn b29kIGJlZWQ5ODM2MjFmYmRmZDI5MWU2ZTNhMGNkYzRkMTA1MTdlNjBhZjgKIyBnb29kOiBbZmJl ODZkYWNhMGJhODc4YjA0ZmEyNDFiODVlMjZlNTRkMTdkNDIyOV0gTWVyZ2UgdGFnICdzY3NpLW1p c2MnIG9mIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9qZWpi L3Njc2kKZ2l0IGJpc2VjdCBnb29kIGZiZTg2ZGFjYTBiYTg3OGIwNGZhMjQxYjg1ZTI2ZTU0ZDE3 ZDQyMjkKIyBnb29kOiBbMTY2YWZjNDVlZDU1MjMyOTg1NDFmZDAyOTdmOWFkNTg1Y2MyNzA4Y10g TWVyZ2UgdGFnICdyZWZsaW5rLXNwZWVkdXBzLTUuMTlfMjAyMi0wNC0yOCcgb2YgZ2l0Oi8vZ2l0 Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2Rqd29uZy94ZnMtbGludXggaW50 byB4ZnMtNS4xOS1mb3ItbmV4dApnaXQgYmlzZWN0IGdvb2QgMTY2YWZjNDVlZDU1MjMyOTg1NDFm ZDAyOTdmOWFkNTg1Y2MyNzA4YwojIGJhZDogW2UzNzU3ODBiNjMxYTVmYzJhNjFhM2I0ZmExMjQy OTI1NTM2MWEzMWVdIE1lcmdlIHRhZyAnZnNub3RpZnlfZm9yX3Y1LjE5LXJjMScgb2YgZ2l0Oi8v Z2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2phY2svbGludXgtZnMKZ2l0 IGJpc2VjdCBiYWQgZTM3NTc4MGI2MzFhNWZjMmE2MWEzYjRmYTEyNDI5MjU1MzYxYTMxZQojIGJh ZDogWzRhMzdmM2RkOWE4MzE4NmNiODhkNDQ4MDhhYjM1Yjc4Mzc1MDgyYzldIGRtYS1kaXJlY3Q6 IGRvbid0IG92ZXItZGVjcnlwdCBtZW1vcnkKZ2l0IGJpc2VjdCBiYWQgNGEzN2YzZGQ5YTgzMTg2 Y2I4OGQ0NDgwOGFiMzViNzgzNzUwODJjOQojIGJhZDogWzc0MjUxOTUzOGU2YjA3MjUwYzgwODVi YmZmNGJkMzU4YmMwM2JmMTZdIHN3aW90bGI6IHBhc3MgYSBnZnBfbWFzayBhcmd1bWVudCB0byBz d2lvdGxiX2luaXRfbGF0ZQpnaXQgYmlzZWN0IGJhZCA3NDI1MTk1MzhlNmIwNzI1MGM4MDg1YmJm ZjRiZDM1OGJjMDNiZjE2CiMgZ29vZDogWzliYmU3YTdmYzEyNmUzZDE0ZmVmYTRiMDM1ODU0YWJh MDgwOTI2ZDldIGFybS94ZW46IGRvbid0IGNoZWNrIGZvciB4ZW5faW5pdGlhbF9kb21haW4oKSBp biB4ZW5fY3JlYXRlX2NvbnRpZ3VvdXNfcmVnaW9uCmdpdCBiaXNlY3QgZ29vZCA5YmJlN2E3ZmMx MjZlM2QxNGZlZmE0YjAzNTg1NGFiYTA4MDkyNmQ5CiMgZ29vZDogW2EzZTIzMDkyNjcwODEyNTIw NWZmZDA2ZDNkYzIxNzVhODI2M2FlN2VdIHg4NjogY2VudHJhbGl6ZSBzZXR0aW5nIFNXSU9UTEJf Rk9SQ0Ugd2hlbiBndWVzdCBtZW1vcnkgZW5jcnlwdGlvbiBpcyBlbmFibGVkCmdpdCBiaXNlY3Qg Z29vZCBhM2UyMzA5MjY3MDgxMjUyMDVmZmQwNmQzZGMyMTc1YTgyNjNhZTdlCiMgYmFkOiBbOGJh MmVkMWJlOTBmYzIxMDEyNmY2ODE4NjU2NDcwNzQ3ODU1MmM5NV0gc3dpb3RsYjogYWRkIGEgU1dJ T1RMQl9BTlkgZmxhZyB0byBsaWZ0IHRoZSBsb3cgbWVtb3J5IHJlc3RyaWN0aW9uCmdpdCBiaXNl Y3QgYmFkIDhiYTJlZDFiZTkwZmMyMTAxMjZmNjgxODY1NjQ3MDc0Nzg1NTJjOTUKIyBiYWQ6IFtj NmFmMmFhOWZmYzk3NjM4MjY2MDdiYzI2NjRlZjNlYTQ0NzVlZDE4XSBzd2lvdGxiOiBtYWtlIHRo ZSBzd2lvdGxiX2luaXQgaW50ZXJmYWNlIG1vcmUgdXNlZnVsCmdpdCBiaXNlY3QgYmFkIGM2YWYy YWE5ZmZjOTc2MzgyNjYwN2JjMjY2NGVmM2VhNDQ3NWVkMTgKIyBmaXJzdCBiYWQgY29tbWl0OiBb YzZhZjJhYTlmZmM5NzYzODI2NjA3YmMyNjY0ZWYzZWE0NDc1ZWQxOF0gc3dpb3RsYjogbWFrZSB0 aGUgc3dpb3RsYl9pbml0IGludGVyZmFjZSBtb3JlIHVzZWZ1bApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlz dHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3Jn L21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EE21C43334 for ; Wed, 1 Jun 2022 17:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z1BcUiwXf4dX9/89GjL8nP2pF5UZPBAORs641A5d8tw=; b=XbwJX95R7uKCHK 3y0YIRfv04pqlLbR8/QFda9A+qies8Iaq6g9p97ZldY8M4QfQQNbgQuRwFa0XGd+zEJy2pZoKvgE3 eTsRFN5Dd832DxEGTIXikz0bN//XELdAVtp9peIn1SqsJDmjsyXqA1DUewTd6U83HZQyu95x9v/tz WTYkoxNAZQyo3HDpDnNmZbbVtZZHXzTd7ZYUqp7DtyhiUJ1J+FaIiDX50rA/g0/ycz5sbTlzGHDLo TX5suUV7XnfkWJopD2SHB5wMgnykMxSsjwFl1kyb4Eh5LCUQDhuJDWuMfbHSjmKPSMnbgk64Et2M6 JRWV7AqoQeqCKotejIog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwS6G-00HHqs-SO; Wed, 01 Jun 2022 17:25:40 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwS6E-00HHpn-4P; Wed, 01 Jun 2022 17:25:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DA5C2B81BC3; Wed, 1 Jun 2022 17:25:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 301D1C385A5; Wed, 1 Jun 2022 17:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654104334; bh=jMMe7B3BhgdISh7uct3BKpjV+FPEgE6gFytMtHtHl0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GHO+qMWQe5cP8tmgUQqj8fPGjJwS3Otgz+OXIEdGPVJSradD7wwZvicTh/XeTN6xn 36cftZjh2U4vxTC907inz6H2ofvk+02etbYJZRSA3kWg1Zraq122z9y1G6zY5uAzjM 9xDC4IBmiXmiVoI5M28u6BmC46gm/t04m9/d3Uk738NKcetPPZ1x+AIx5ihXth0Frb Ch9UusaL6Sktiv1EghEBMMueZ59I77EcbHnOJL4/Jl32ORyzuRmi00q7R572WE5XOK /zF9VgHnpoTDGhq77ORqvchBakQOe3gxA1stj2MKAJaA3beP0uvbuDT0szSX/KVl+i ui6hmrXqhf3Iw== Date: Wed, 1 Jun 2022 10:25:31 -0700 From: Nathan Chancellor To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Subject: Re: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful Message-ID: References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-10-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220404050559.132378-10-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_102538_502410_CB0BCA7C X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2hyaXN0b3BoLAoKT24gTW9uLCBBcHIgMDQsIDIwMjIgYXQgMDc6MDU6NTNBTSArMDIwMCwg Q2hyaXN0b3BoIEhlbGx3aWcgd3JvdGU6Cj4gUGFzcyBhIGJvb2wgdG8gcGFzcyBpZiBzd2lvdGxi IG5lZWRzIHRvIGJlIGVuYWJsZWQgYmFzZWQgb24gdGhlCj4gYWRkcmVzc2luZyBuZWVkcyBhbmQg cmVwbGFjZSB0aGUgdmVyYm9zZSBhcmd1bWVudCB3aXRoIGEgc2V0IG9mCj4gZmxhZ3MsIGluY2x1 ZGluZyBvbmUgdG8gZm9yY2UgZW5hYmxlIGJvdW5jZSBidWZmZXJpbmcuCj4gCj4gTm90ZSB0aGF0 IHRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUgcG9zc2liaWxpdHkgdG8gZm9yY2UgeGVuLXN3aW90bGIK PiB1c2UgdXNpbmcgc3dpb3RsYj1mb3JjZSBvbiB0aGUgY29tbWFuZCBsaW5lIG9uIHg4NiAoYXJt IGFuZCBhcm02NAo+IG5ldmVyIHN1cHBvcnRlZCB0aGF0KSwgYnV0IHRoaXMgaW50ZXJmYWNlIHdp bGwgYmUgcmVzdG9yZWQgc2hvcnRseS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RvcGggSGVs bHdpZyA8aGNoQGxzdC5kZT4KCkkgYmlzZWN0ZWQgYSBwZXJmb3JtYW5jZSByZWdyZXNzaW9uIGlu IFdTTDIgdG8gdGhpcyBjaGFuZ2UgYXMgY29tbWl0CmM2YWYyYWE5ZmZjOSAoInN3aW90bGI6IG1h a2UgdGhlIHN3aW90bGJfaW5pdCBpbnRlcmZhY2UgbW9yZSB1c2VmdWwiKSBpbgptYWlubGluZSAo YmlzZWN0IGxvZyBiZWxvdykuIEkgaW5pdGlhbGx5IG5vdGljZWQgaXQgYmVjYXVzZSBhY2Nlc3Np bmcgdGhlCldpbmRvd3MgZmlsZXN5c3RlbSB0aHJvdWdoIHRoZSAvbW50L2MgbW91bnQgaXMgYWJv dXQgNDB4IHNsb3dlciBpZiBJIGFtIGRvaW5nCm15IG1hdGggcmlnaHQgYmFzZWQgb24gdGhlIGJl bmNobWFya3MgYmVsb3cuCgpCZWZvcmU6CgokIHVuYW1lIC1yOyBhbmQgaHlwZXJmaW5lICJscyAt bCAvbW50L2MvVXNlcnMvbmF0ZWMvRG93bmxvYWRzIgo1LjE4LjAtcmMzLW1pY3Jvc29mdC1zdGFu ZGFyZC1XU0wyLTAwMDA4LWdhM2UyMzA5MjY3MDgKQmVuY2htYXJrIDE6IGxzIC1sIC9tbnQvYy9V c2Vycy9uYXRlYy9Eb3dubG9hZHMKICBUaW1lIChtZWFuIMKxIM+DKTogICAgIDU2NC41IG1zIMKx ICAyNC4xIG1zICAgIFtVc2VyOiAyLjUgbXMsIFN5c3RlbTogMTMwLjMgbXNdCiAgUmFuZ2UgKG1p biDigKYgbWF4KTogICA1MTAuMiBtcyDigKYgNTg4LjAgbXMgICAgMTAgcnVucwoKQWZ0ZXIKCiQg dW5hbWUgLXI7IGFuZCBoeXBlcmZpbmUgImxzIC1sIC9tbnQvYy9Vc2Vycy9uYXRlYy9Eb3dubG9h ZHMiCjUuMTguMC1yYzMtbWljcm9zb2Z0LXN0YW5kYXJkLVdTTDItMDAwMDktZ2M2YWYyYWE5ZmZj OQpCZW5jaG1hcmsgMTogbHMgLWwgL21udC9jL1VzZXJzL25hdGVjL0Rvd25sb2FkcwogIFRpbWUg KG1lYW4gwrEgz4MpOiAgICAgMjMuMjgyIHMgwrEgIDEuMjIwIHMgICAgW1VzZXI6IDAuMDEzIHMs IFN5c3RlbTogMC4xMDEgc10KICBSYW5nZSAobWluIOKApiBtYXgpOiAgIDIxLjc5MyBzIOKApiAy NS4zMTcgcyAgICAxMCBydW5zCgpJIGRvIHNlZSAnc3dpb3RsYj1mb3JjZScgb24gdGhlIGNtZGxp bmU6CgokIGNhdCAvcHJvYy9jbWRsaW5lCmluaXRyZD1caW5pdHJkLmltZyBwYW5pYz0tMSBucl9j cHVzPTggc3dpb3RsYj1mb3JjZSBlYXJseWNvbj11YXJ0ODI1MCxpbywweDNmOCwxMTUyMDAgY29u c29sZT1odmMwIGRlYnVnIHB0eS5sZWdhY3lfY291bnQ9MAoKL21udC9jIGFwcGVhcnMgdG8gYmUg YSA5cCBtb3VudCwgbm90IHN1cmUgaWYgdGhhdCBpcyByZWxldmFudCBoZXJlOgoKJCBtb3VudCAm fCBncmVwIC9tbnQvYwpkcnZmcyBvbiAvbW50L2MgdHlwZSA5cCAocncsbm9hdGltZSxkaXJzeW5j LGFuYW1lPWRydmZzO3BhdGg9QzpcO3VpZD0xMDAwO2dpZD0xMDAwO3N5bWxpbmtyb290PS9tbnQv LG1tYXAsYWNjZXNzPWNsaWVudCxtc2l6ZT0yNjIxNDQsdHJhbnM9dmlydGlvKQoKSWYgdGhlcmUg aXMgYW55IG90aGVyIGluZm9ybWF0aW9uIEkgY2FuIHByb3ZpZGUsIHBsZWFzZSBsZXQgbWUga25v dy4KCkNoZWVycywKTmF0aGFuCgojIGJhZDogWzcwMDE3MGJmNmI0ZDc3M2UzMjhmYTU0ZWJiNzBi YTQ0NDAwN2M3MDJdIE1lcmdlIHRhZyAnbmZzLWZvci01LjE5LTEnIG9mIGdpdDovL2dpdC5saW51 eC1uZnMub3JnL3Byb2plY3RzL2FubmEvbGludXgtbmZzCiMgZ29vZDogWzRiMDk4NmEzNjEzYzky ZjRlYzFiZGM3ZjYwZWM2NmZlYTEzNTk5MWZdIExpbnV4IDUuMTgKZ2l0IGJpc2VjdCBzdGFydCAn NzAwMTcwYmY2YjRkNzczZTMyOGZhNTRlYmI3MGJhNDQ0MDA3YzcwMicgJ3Y1LjE4JwojIGdvb2Q6 IFs4NmM4N2JlYTZiNDIxMDBjNjc0MThhZjY5MDkxOWM0NGRlNmVkZTZlXSBNZXJnZSB0YWcgJ2Rl dmljZXRyZWUtZm9yLTUuMTknIG9mIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgv a2VybmVsL2dpdC9yb2JoL2xpbnV4CmdpdCBiaXNlY3QgZ29vZCA4NmM4N2JlYTZiNDIxMDBjNjc0 MThhZjY5MDkxOWM0NGRlNmVkZTZlCiMgYmFkOiBbYWU4NjIxODMyODVjYmIyZWY5MDMyNzcwZDk4 ZmZhOWJlY2ZmZTlkNV0gTWVyZ2UgdGFnICdhcm0tZHQtNS4xOScgb2YgZ2l0Oi8vZ2l0Lmtlcm5l bC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3NvYy9zb2MKZ2l0IGJpc2VjdCBiYWQgYWU4 NjIxODMyODVjYmIyZWY5MDMyNzcwZDk4ZmZhOWJlY2ZmZTlkNQojIGdvb2Q6IFsyNTE4ZjIyNmM2 MGQ4ZTA0ZDE4YmE0Mjk1NTAwYTViMGI4YWM3NjU5XSBNZXJnZSB0YWcgJ2RybS1uZXh0LTIwMjIt MDUtMjUnIG9mIGdpdDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL2RybS9kcm0KZ2l0IGJpc2Vj dCBnb29kIDI1MThmMjI2YzYwZDhlMDRkMThiYTQyOTU1MDBhNWIwYjhhYzc2NTkKIyBiYWQ6IFti YWJmMGJiOTc4ZTNjOWZjZTZjNGViYTZiNzQ0Yzg3NTRmZDQzZDhlXSBNZXJnZSB0YWcgJ3hmcy01 LjE5LWZvci1saW51cycgb2YgZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9mcy94ZnMveGZz LWxpbnV4CmdpdCBiaXNlY3QgYmFkIGJhYmYwYmI5NzhlM2M5ZmNlNmM0ZWJhNmI3NDRjODc1NGZk NDNkOGUKIyBnb29kOiBbYmVlZDk4MzYyMWZiZGZkMjkxZTZlM2EwY2RjNGQxMDUxN2U2MGFmOF0g QVNvQzogSW50ZWw6IGF2czogTWFjaGluZSBib2FyZCByZWdpc3RyYXRpb24KZ2l0IGJpc2VjdCBn b29kIGJlZWQ5ODM2MjFmYmRmZDI5MWU2ZTNhMGNkYzRkMTA1MTdlNjBhZjgKIyBnb29kOiBbZmJl ODZkYWNhMGJhODc4YjA0ZmEyNDFiODVlMjZlNTRkMTdkNDIyOV0gTWVyZ2UgdGFnICdzY3NpLW1p c2MnIG9mIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9qZWpi L3Njc2kKZ2l0IGJpc2VjdCBnb29kIGZiZTg2ZGFjYTBiYTg3OGIwNGZhMjQxYjg1ZTI2ZTU0ZDE3 ZDQyMjkKIyBnb29kOiBbMTY2YWZjNDVlZDU1MjMyOTg1NDFmZDAyOTdmOWFkNTg1Y2MyNzA4Y10g TWVyZ2UgdGFnICdyZWZsaW5rLXNwZWVkdXBzLTUuMTlfMjAyMi0wNC0yOCcgb2YgZ2l0Oi8vZ2l0 Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2Rqd29uZy94ZnMtbGludXggaW50 byB4ZnMtNS4xOS1mb3ItbmV4dApnaXQgYmlzZWN0IGdvb2QgMTY2YWZjNDVlZDU1MjMyOTg1NDFm ZDAyOTdmOWFkNTg1Y2MyNzA4YwojIGJhZDogW2UzNzU3ODBiNjMxYTVmYzJhNjFhM2I0ZmExMjQy OTI1NTM2MWEzMWVdIE1lcmdlIHRhZyAnZnNub3RpZnlfZm9yX3Y1LjE5LXJjMScgb2YgZ2l0Oi8v Z2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L2phY2svbGludXgtZnMKZ2l0 IGJpc2VjdCBiYWQgZTM3NTc4MGI2MzFhNWZjMmE2MWEzYjRmYTEyNDI5MjU1MzYxYTMxZQojIGJh ZDogWzRhMzdmM2RkOWE4MzE4NmNiODhkNDQ4MDhhYjM1Yjc4Mzc1MDgyYzldIGRtYS1kaXJlY3Q6 IGRvbid0IG92ZXItZGVjcnlwdCBtZW1vcnkKZ2l0IGJpc2VjdCBiYWQgNGEzN2YzZGQ5YTgzMTg2 Y2I4OGQ0NDgwOGFiMzViNzgzNzUwODJjOQojIGJhZDogWzc0MjUxOTUzOGU2YjA3MjUwYzgwODVi YmZmNGJkMzU4YmMwM2JmMTZdIHN3aW90bGI6IHBhc3MgYSBnZnBfbWFzayBhcmd1bWVudCB0byBz d2lvdGxiX2luaXRfbGF0ZQpnaXQgYmlzZWN0IGJhZCA3NDI1MTk1MzhlNmIwNzI1MGM4MDg1YmJm ZjRiZDM1OGJjMDNiZjE2CiMgZ29vZDogWzliYmU3YTdmYzEyNmUzZDE0ZmVmYTRiMDM1ODU0YWJh MDgwOTI2ZDldIGFybS94ZW46IGRvbid0IGNoZWNrIGZvciB4ZW5faW5pdGlhbF9kb21haW4oKSBp biB4ZW5fY3JlYXRlX2NvbnRpZ3VvdXNfcmVnaW9uCmdpdCBiaXNlY3QgZ29vZCA5YmJlN2E3ZmMx MjZlM2QxNGZlZmE0YjAzNTg1NGFiYTA4MDkyNmQ5CiMgZ29vZDogW2EzZTIzMDkyNjcwODEyNTIw NWZmZDA2ZDNkYzIxNzVhODI2M2FlN2VdIHg4NjogY2VudHJhbGl6ZSBzZXR0aW5nIFNXSU9UTEJf Rk9SQ0Ugd2hlbiBndWVzdCBtZW1vcnkgZW5jcnlwdGlvbiBpcyBlbmFibGVkCmdpdCBiaXNlY3Qg Z29vZCBhM2UyMzA5MjY3MDgxMjUyMDVmZmQwNmQzZGMyMTc1YTgyNjNhZTdlCiMgYmFkOiBbOGJh MmVkMWJlOTBmYzIxMDEyNmY2ODE4NjU2NDcwNzQ3ODU1MmM5NV0gc3dpb3RsYjogYWRkIGEgU1dJ T1RMQl9BTlkgZmxhZyB0byBsaWZ0IHRoZSBsb3cgbWVtb3J5IHJlc3RyaWN0aW9uCmdpdCBiaXNl Y3QgYmFkIDhiYTJlZDFiZTkwZmMyMTAxMjZmNjgxODY1NjQ3MDc0Nzg1NTJjOTUKIyBiYWQ6IFtj NmFmMmFhOWZmYzk3NjM4MjY2MDdiYzI2NjRlZjNlYTQ0NzVlZDE4XSBzd2lvdGxiOiBtYWtlIHRo ZSBzd2lvdGxiX2luaXQgaW50ZXJmYWNlIG1vcmUgdXNlZnVsCmdpdCBiaXNlY3QgYmFkIGM2YWYy YWE5ZmZjOTc2MzgyNjYwN2JjMjY2NGVmM2VhNDQ3NWVkMTgKIyBmaXJzdCBiYWQgY29tbWl0OiBb YzZhZjJhYTlmZmM5NzYzODI2NjA3YmMyNjY0ZWYzZWE0NDc1ZWQxOF0gc3dpb3RsYjogbWFrZSB0 aGUgc3dpb3RsYl9pbml0IGludGVyZmFjZSBtb3JlIHVzZWZ1bAoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nathan Chancellor Date: Wed, 01 Jun 2022 17:25:31 +0000 Subject: Re: [PATCH 09/15] swiotlb: make the swiotlb_init interface more useful Message-Id: List-Id: References: <20220404050559.132378-1-hch@lst.de> <20220404050559.132378-10-hch@lst.de> In-Reply-To: <20220404050559.132378-10-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Christoph Hellwig Cc: iommu@lists.linux-foundation.org, x86@kernel.org, Anshuman Khandual , Tom Lendacky , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Juergen Gross , Joerg Roedel , David Woodhouse , Lu Baolu , Robin Murphy , linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, tboot-devel@lists.sourceforge.net, linux-pci@vger.kernel.org Hi Christoph, On Mon, Apr 04, 2022 at 07:05:53AM +0200, Christoph Hellwig wrote: > Pass a bool to pass if swiotlb needs to be enabled based on the > addressing needs and replace the verbose argument with a set of > flags, including one to force enable bounce buffering. > > Note that this patch removes the possibility to force xen-swiotlb > use using swiotlb=force on the command line on x86 (arm and arm64 > never supported that), but this interface will be restored shortly. > > Signed-off-by: Christoph Hellwig I bisected a performance regression in WSL2 to this change as commit c6af2aa9ffc9 ("swiotlb: make the swiotlb_init interface more useful") in mainline (bisect log below). I initially noticed it because accessing the Windows filesystem through the /mnt/c mount is about 40x slower if I am doing my math right based on the benchmarks below. Before: $ uname -r; and hyperfine "ls -l /mnt/c/Users/natec/Downloads" 5.18.0-rc3-microsoft-standard-WSL2-00008-ga3e230926708 Benchmark 1: ls -l /mnt/c/Users/natec/Downloads Time (mean ± σ): 564.5 ms ± 24.1 ms [User: 2.5 ms, System: 130.3 ms] Range (min … max): 510.2 ms … 588.0 ms 10 runs After $ uname -r; and hyperfine "ls -l /mnt/c/Users/natec/Downloads" 5.18.0-rc3-microsoft-standard-WSL2-00009-gc6af2aa9ffc9 Benchmark 1: ls -l /mnt/c/Users/natec/Downloads Time (mean ± σ): 23.282 s ± 1.220 s [User: 0.013 s, System: 0.101 s] Range (min … max): 21.793 s … 25.317 s 10 runs I do see 'swiotlb=force' on the cmdline: $ cat /proc/cmdline initrd=\initrd.img panic=-1 nr_cpus=8 swiotlb=force earlycon=uart8250,io,0x3f8,115200 console=hvc0 debug pty.legacy_count=0 /mnt/c appears to be a 9p mount, not sure if that is relevant here: $ mount &| grep /mnt/c drvfs on /mnt/c type 9p (rw,noatime,dirsync,aname=drvfs;path=C:\;uid00;gid00;symlinkroot=/mnt/,mmap,access=client,msize&2144,trans=virtio) If there is any other information I can provide, please let me know. Cheers, Nathan # bad: [700170bf6b4d773e328fa54ebb70ba444007c702] Merge tag 'nfs-for-5.19-1' of git://git.linux-nfs.org/projects/anna/linux-nfs # good: [4b0986a3613c92f4ec1bdc7f60ec66fea135991f] Linux 5.18 git bisect start '700170bf6b4d773e328fa54ebb70ba444007c702' 'v5.18' # good: [86c87bea6b42100c67418af690919c44de6ede6e] Merge tag 'devicetree-for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux git bisect good 86c87bea6b42100c67418af690919c44de6ede6e # bad: [ae862183285cbb2ef9032770d98ffa9becffe9d5] Merge tag 'arm-dt-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc git bisect bad ae862183285cbb2ef9032770d98ffa9becffe9d5 # good: [2518f226c60d8e04d18ba4295500a5b0b8ac7659] Merge tag 'drm-next-2022-05-25' of git://anongit.freedesktop.org/drm/drm git bisect good 2518f226c60d8e04d18ba4295500a5b0b8ac7659 # bad: [babf0bb978e3c9fce6c4eba6b744c8754fd43d8e] Merge tag 'xfs-5.19-for-linus' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux git bisect bad babf0bb978e3c9fce6c4eba6b744c8754fd43d8e # good: [beed983621fbdfd291e6e3a0cdc4d10517e60af8] ASoC: Intel: avs: Machine board registration git bisect good beed983621fbdfd291e6e3a0cdc4d10517e60af8 # good: [fbe86daca0ba878b04fa241b85e26e54d17d4229] Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi git bisect good fbe86daca0ba878b04fa241b85e26e54d17d4229 # good: [166afc45ed5523298541fd0297f9ad585cc2708c] Merge tag 'reflink-speedups-5.19_2022-04-28' of git://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux into xfs-5.19-for-next git bisect good 166afc45ed5523298541fd0297f9ad585cc2708c # bad: [e375780b631a5fc2a61a3b4fa12429255361a31e] Merge tag 'fsnotify_for_v5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs git bisect bad e375780b631a5fc2a61a3b4fa12429255361a31e # bad: [4a37f3dd9a83186cb88d44808ab35b78375082c9] dma-direct: don't over-decrypt memory git bisect bad 4a37f3dd9a83186cb88d44808ab35b78375082c9 # bad: [742519538e6b07250c8085bbff4bd358bc03bf16] swiotlb: pass a gfp_mask argument to swiotlb_init_late git bisect bad 742519538e6b07250c8085bbff4bd358bc03bf16 # good: [9bbe7a7fc126e3d14fefa4b035854aba080926d9] arm/xen: don't check for xen_initial_domain() in xen_create_contiguous_region git bisect good 9bbe7a7fc126e3d14fefa4b035854aba080926d9 # good: [a3e230926708125205ffd06d3dc2175a8263ae7e] x86: centralize setting SWIOTLB_FORCE when guest memory encryption is enabled git bisect good a3e230926708125205ffd06d3dc2175a8263ae7e # bad: [8ba2ed1be90fc210126f68186564707478552c95] swiotlb: add a SWIOTLB_ANY flag to lift the low memory restriction git bisect bad 8ba2ed1be90fc210126f68186564707478552c95 # bad: [c6af2aa9ffc9763826607bc2664ef3ea4475ed18] swiotlb: make the swiotlb_init interface more useful git bisect bad c6af2aa9ffc9763826607bc2664ef3ea4475ed18 # first bad commit: [c6af2aa9ffc9763826607bc2664ef3ea4475ed18] swiotlb: make the swiotlb_init interface more useful