From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8611CCA473 for ; Thu, 2 Jun 2022 03:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233397AbiFBDGq (ORCPT ); Wed, 1 Jun 2022 23:06:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbiFBDGn (ORCPT ); Wed, 1 Jun 2022 23:06:43 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D15A23B17B for ; Wed, 1 Jun 2022 20:06:42 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id u4so636709pgk.11 for ; Wed, 01 Jun 2022 20:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2wNLI+UiPxMD8gpYb8X0rEwvSxrz6cSA2s7fFzdJJpo=; b=U7mxsOuX6jlRQc/N2wDNPLldG8N8Q//HPEH8MZkAnJQTYBblNNDA6fvJcYZa2+ajhu r7v8owfFW4WH9wCmj4KA9V7eXigowV+GwmRcRsY/bmS96PzTs2Y4LN+gvpOvNDeyWh6g GXxB6XFIimI5GljV7sKZpmyYYoAHvuFXHsvc5wRHpAnt/h4J44rLOBoDqGvTKwjXY9lN lA8WlNUJq4AZRgtThcD+jnB/opVPFJ1f7MmsBfaOgQu1AJyDo5hFyWPpGqzd6wvSo2PF 14kSrZTDwtXro5yUWNjjwaUt5ut8ETmbwzfNA0W6I4LXQ0KDtbjiiWhgeGQqHGOw8UOM KM4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2wNLI+UiPxMD8gpYb8X0rEwvSxrz6cSA2s7fFzdJJpo=; b=j5k4oYWmen0Lg8tZhivz70hosutUGKoTR6vXt2Y9uMjOjVi0N76B69olhk0Z1D033L k/9fjPZsFUAl5PU8yUAK3Ah5w8NyX9Q6rj7q3ZI5ZoyNGuqJBRtjf6w1RFtq1HAlGd/r Es+OGs9nLo4umTPrrIoqQp1mJndnBBtQqRLxUy5arZkL5jlozgLNos35h/dmr0PwQxVt in3f6Jk3ujtOGTUtphLnmywziZFvmTRDYMr3WjuBgr0gy6QGGT0xyzwSgDoD8CawgBRI 0zenLGvGPIjJzSC7AgYGjq8lPf90ioAlCsSvD+Hy49NEKg/eyGShwNML4+v4BEf1sE/t Avsw== X-Gm-Message-State: AOAM532EC9JSMofc+8bkjYawoW/oVU/xm4R2hIBsd0NI4/rxunaNweBq VQpW7GXd5vJh2iZCdq/+sy1s2Q== X-Google-Smtp-Source: ABdhPJyCOcJbpRbXJqeVRd/304cyIed9Z6+PjPA9f74qJZ36s3xgnk3oFV7hWHEbHUgOVebZGcEixg== X-Received: by 2002:a63:db47:0:b0:3fc:17e5:9fbb with SMTP id x7-20020a63db47000000b003fc17e59fbbmr2215874pgi.504.1654139201494; Wed, 01 Jun 2022 20:06:41 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:2468:2a68:7bbe:680c]) by smtp.gmail.com with ESMTPSA id s16-20020aa78bd0000000b0051bbd79fc9csm960267pfd.57.2022.06.01.20.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 20:06:41 -0700 (PDT) Date: Thu, 2 Jun 2022 11:06:35 +0800 From: Muchun Song To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, longman@redhat.com Subject: Re: [PATCH v5 03/11] mm: memcontrol: prepare objcg API for non-kmem usage Message-ID: References: <20220530074919.46352-1-songmuchun@bytedance.com> <20220530074919.46352-4-songmuchun@bytedance.com> <20220601173434.GB16134@blackbody.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220601173434.GB16134@blackbody.suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 01, 2022 at 07:34:34PM +0200, Michal Koutný wrote: > Hello. > > On Mon, May 30, 2022 at 03:49:11PM +0800, Muchun Song wrote: > > So we also allocate an object cgroup for the root_mem_cgroup. > > This change made me wary that this patch also kmem charging in the > root_mem_cgroup. Fortunately, get_obj_cgroup_from_current won't return Sorry for the confusing. Right, we don't charge kmem to the root objcg. > this objcg so all is fine. > > > +} > > +#else > > +static inline void obj_cgroup_release_bytes(struct obj_cgroup *objcg) > > +{ > > +} > > +#endif > > This empty body is for !CONFIG_MEMCG_KMEM, however, the subsequent use for LRU > pages makes no use of these, so it's warranted. > > Altogether, I find this correct, hence > Reviewed-by: Michal Koutný > Thanks Michal. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muchun Song Subject: Re: [PATCH v5 03/11] mm: memcontrol: prepare objcg API for non-kmem usage Date: Thu, 2 Jun 2022 11:06:35 +0800 Message-ID: References: <20220530074919.46352-1-songmuchun@bytedance.com> <20220530074919.46352-4-songmuchun@bytedance.com> <20220601173434.GB16134@blackbody.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2wNLI+UiPxMD8gpYb8X0rEwvSxrz6cSA2s7fFzdJJpo=; b=U7mxsOuX6jlRQc/N2wDNPLldG8N8Q//HPEH8MZkAnJQTYBblNNDA6fvJcYZa2+ajhu r7v8owfFW4WH9wCmj4KA9V7eXigowV+GwmRcRsY/bmS96PzTs2Y4LN+gvpOvNDeyWh6g GXxB6XFIimI5GljV7sKZpmyYYoAHvuFXHsvc5wRHpAnt/h4J44rLOBoDqGvTKwjXY9lN lA8WlNUJq4AZRgtThcD+jnB/opVPFJ1f7MmsBfaOgQu1AJyDo5hFyWPpGqzd6wvSo2PF 14kSrZTDwtXro5yUWNjjwaUt5ut8ETmbwzfNA0W6I4LXQ0KDtbjiiWhgeGQqHGOw8UOM KM4g== Content-Disposition: inline In-Reply-To: <20220601173434.GB16134-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org> List-ID: Content-Type: text/plain; charset="iso-8859-1" To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, duanxiongchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org, longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org On Wed, Jun 01, 2022 at 07:34:34PM +0200, Michal Koutn=FD wrote: > Hello. >=20 > On Mon, May 30, 2022 at 03:49:11PM +0800, Muchun Song wrote: > > So we also allocate an object cgroup for the root_mem_cgroup. >=20 > This change made me wary that this patch also kmem charging in the > root_mem_cgroup. Fortunately, get_obj_cgroup_from_current won't return Sorry for the confusing. Right, we don't charge kmem to the root objcg. > this objcg so all is fine. >=20 > > +} > > +#else > > +static inline void obj_cgroup_release_bytes(struct obj_cgroup *objcg) > > +{ > > +} > > +#endif >=20 > This empty body is for !CONFIG_MEMCG_KMEM, however, the subsequent use fo= r LRU > pages makes no use of these, so it's warranted. >=20 > Altogether, I find this correct, hence > Reviewed-by: Michal Koutn=FD > Thanks Michal.