* [PATCH] hw/nvme: clear aen mask on reset
@ 2022-05-12 9:30 Klaus Jensen
2022-06-03 20:33 ` Klaus Jensen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Klaus Jensen @ 2022-05-12 9:30 UTC (permalink / raw)
To: qemu-devel; +Cc: Klaus Jensen, Keith Busch, qemu-block, Klaus Jensen
From: Klaus Jensen <k.jensen@samsung.com>
The internally maintained AEN mask is not cleared on reset. Fix this.
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 1e6e0fcad918..4c8200dfb859 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -5889,6 +5889,7 @@ static void nvme_ctrl_reset(NvmeCtrl *n)
}
n->aer_queued = 0;
+ n->aer_mask = 0;
n->outstanding_aers = 0;
n->qs_created = false;
}
--
2.36.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/nvme: clear aen mask on reset
2022-05-12 9:30 [PATCH] hw/nvme: clear aen mask on reset Klaus Jensen
@ 2022-06-03 20:33 ` Klaus Jensen
2022-06-03 20:49 ` Keith Busch
2022-06-17 6:40 ` Klaus Jensen
2 siblings, 0 replies; 4+ messages in thread
From: Klaus Jensen @ 2022-06-03 20:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Keith Busch, qemu-block, Klaus Jensen
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
On May 12 11:30, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The internally maintained AEN mask is not cleared on reset. Fix this.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/ctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 1e6e0fcad918..4c8200dfb859 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
> @@ -5889,6 +5889,7 @@ static void nvme_ctrl_reset(NvmeCtrl *n)
> }
>
> n->aer_queued = 0;
> + n->aer_mask = 0;
> n->outstanding_aers = 0;
> n->qs_created = false;
> }
> --
> 2.36.0
>
Gentle bump.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/nvme: clear aen mask on reset
2022-05-12 9:30 [PATCH] hw/nvme: clear aen mask on reset Klaus Jensen
2022-06-03 20:33 ` Klaus Jensen
@ 2022-06-03 20:49 ` Keith Busch
2022-06-17 6:40 ` Klaus Jensen
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2022-06-03 20:49 UTC (permalink / raw)
To: Klaus Jensen; +Cc: qemu-devel, qemu-block, Klaus Jensen
On Thu, May 12, 2022 at 11:30:55AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The internally maintained AEN mask is not cleared on reset. Fix this.
Looks good.
Reviewed-by: Keith Busch <kbusch@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/nvme: clear aen mask on reset
2022-05-12 9:30 [PATCH] hw/nvme: clear aen mask on reset Klaus Jensen
2022-06-03 20:33 ` Klaus Jensen
2022-06-03 20:49 ` Keith Busch
@ 2022-06-17 6:40 ` Klaus Jensen
2 siblings, 0 replies; 4+ messages in thread
From: Klaus Jensen @ 2022-06-17 6:40 UTC (permalink / raw)
To: qemu-devel; +Cc: Keith Busch, qemu-block, Klaus Jensen
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On May 12 11:30, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
>
> The internally maintained AEN mask is not cleared on reset. Fix this.
>
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> hw/nvme/ctrl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 1e6e0fcad918..4c8200dfb859 100644
> --- a/hw/nvme/ctrl.c
> +++ b/hw/nvme/ctrl.c
> @@ -5889,6 +5889,7 @@ static void nvme_ctrl_reset(NvmeCtrl *n)
> }
>
> n->aer_queued = 0;
> + n->aer_mask = 0;
> n->outstanding_aers = 0;
> n->qs_created = false;
> }
> --
> 2.36.0
>
Applied to nvme-next.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-17 6:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 9:30 [PATCH] hw/nvme: clear aen mask on reset Klaus Jensen
2022-06-03 20:33 ` Klaus Jensen
2022-06-03 20:49 ` Keith Busch
2022-06-17 6:40 ` Klaus Jensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.