From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B89C43334 for ; Sun, 5 Jun 2022 15:11:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345426AbiFEPLO (ORCPT ); Sun, 5 Jun 2022 11:11:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235016AbiFEPLI (ORCPT ); Sun, 5 Jun 2022 11:11:08 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CC5C24963; Sun, 5 Jun 2022 08:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=iWUbGe4LrkszuU4l/we/4GAXrYyZL/tQclEBTdqNsUU=; b=wkdQflUSAzs9i1PnUB+Eg2PW06 dMUud3WOM8o9J0P01ibvjsMW4vzeyI/PVVWMvGihfz1oR1OT1Ng4NJK2QcSYb3C5HZiKIiVM6c3kH HMgIlQhv9GN2OS0mM3qeNwey0w5fNY6c68nFdN12I5prpmBcDgvexqi/bl40dr5svV4s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nxruA-005eSM-HH; Sun, 05 Jun 2022 17:11:02 +0200 Date: Sun, 5 Jun 2022 17:11:02 +0200 From: Andrew Lunn To: Puranjay Mohan Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org, s-anna@ti.com, linux-arm-kernel@lists.infradead.org, rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com, robh+dt@kernel.org, afd@ti.com Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Message-ID: References: <20220531095108.21757-1-p-mohan@ti.com> <20220531095108.21757-2-p-mohan@ti.com> <4ccba38a-ccde-83cd-195b-77db7a64477c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > He said ethernet-port is preferred but all other drivers were using > "port" so I though it is not compulsory. Will change it if it compulsory > to use ethernet-port It is a good idea to mention this in the change history. It is then clear you have considered it, but decided against it. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 399C3C43334 for ; Sun, 5 Jun 2022 15:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t+jiwuZdMsuMtB3DpnvFbkBJA03CrkaK/XVk/bUQgSo=; b=BQ65DmDfchAFj/ 3/xA/e7ZUX/NEEeeUl5CgadKb2wmWgv51zh1Tuy9SX1IG02fE/VSgPL4WoAm4sG0vGQUOMVzxjvdm /NrF69tXJybHN5BAri+vOfwCF/OXgtsIAwd6qj7alsPahDh+ceqoujdWy3Ry5xI+IEiEn9LutSrCc FQjfVh9S2g6NBrkLqZst96ymnQLi8kFwl1Vb3gZpFDqtbJX+JpTmeyk7fK/P6pxVRyIdsEYw56VPb MLj5R/3TASGe+q+7cAclt/CMquplZuDP/3Vf2wmESCRyoGAHPmp66iHvaJkEqD6wvYZLrtfomvbCg dDOablohynZCL2IuIVhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxruM-00Eimw-JV; Sun, 05 Jun 2022 15:11:14 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nxruK-00Eikz-0B for linux-arm-kernel@lists.infradead.org; Sun, 05 Jun 2022 15:11:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=iWUbGe4LrkszuU4l/we/4GAXrYyZL/tQclEBTdqNsUU=; b=wkdQflUSAzs9i1PnUB+Eg2PW06 dMUud3WOM8o9J0P01ibvjsMW4vzeyI/PVVWMvGihfz1oR1OT1Ng4NJK2QcSYb3C5HZiKIiVM6c3kH HMgIlQhv9GN2OS0mM3qeNwey0w5fNY6c68nFdN12I5prpmBcDgvexqi/bl40dr5svV4s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nxruA-005eSM-HH; Sun, 05 Jun 2022 17:11:02 +0200 Date: Sun, 5 Jun 2022 17:11:02 +0200 From: Andrew Lunn To: Puranjay Mohan Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Message-ID: References: <20220531095108.21757-1-p-mohan@ti.com> <20220531095108.21757-2-p-mohan@ti.com> <4ccba38a-ccde-83cd-195b-77db7a64477c@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220605_081112_081419_257DD099 X-CRM114-Status: UNSURE ( 7.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, rogerq@kernel.org, afd@ti.com, Krzysztof Kozlowski , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, ssantosh@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > He said ethernet-port is preferred but all other drivers were using > "port" so I though it is not compulsory. Will change it if it compulsory > to use ethernet-port It is a good idea to mention this in the change history. It is then clear you have considered it, but decided against it. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel