From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF8AC433EF for ; Wed, 8 Jun 2022 19:53:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235705AbiFHTxF (ORCPT ); Wed, 8 Jun 2022 15:53:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233902AbiFHTxC (ORCPT ); Wed, 8 Jun 2022 15:53:02 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21C8518A846 for ; Wed, 8 Jun 2022 12:53:01 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id l7-20020a17090aaa8700b001dd1a5b9965so19266988pjq.2 for ; Wed, 08 Jun 2022 12:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CrK6nuHPCK0ai5XnfNscYvGQzujrncbP+EE8Tg1jqVY=; b=oz74sLOu1cI/PGZ+9XsXfKfDziDDz9IGD0+aDbA7yqOAHS4MmH2vo+kv9XzWRXZ871 GmQH4SQsiuLItvHTyX7vUC/OgfoLBsXPlmyyGzoLlT/u74G1Zi3X4eD82L+JQTOVkwnd tAhTj28kDkFB/Ekzvhd96nJVKFlMHOf82w07VxVclGShdZMKQ/KmP4OSgNGf6sUn1Omy 4DxWegvKWXAfOJneXddCGZmHdJvA7Ny+ZUUbSnXnsmfGPVREqteA0+WXDHf1HWFltfvV 0eey0fM+hW+XPTWG335n987Z4eVSFB83UTTfT/4JleM4qXOdIwqpzexeDPOJrbV/F8Ww CRpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CrK6nuHPCK0ai5XnfNscYvGQzujrncbP+EE8Tg1jqVY=; b=V9It3WbpWhaNqIBCj4GQ8xNl7LMSOiz0RGdgcl0UIso3R7awsINCC79FX+h9bEdAq5 wqfFU9ZSWEXPy4qD7skpgJxtow8dA8GvESBLLh7xQieugvcBH5T7XDCjaXRWWuXXCRcj +YYzEDsENSN4lF4i9LWY3A5083xrmfVAKXuGeNll8wCD6x1MFI+s+D2vDo9i2tZRGE14 Mqt0WbwFyw5xm8apPf9oZMc6zSifZ1rD/VQssQSnOtliqsRSY7IeVm9f2mB4XT1uls7h wW2pYVNG/UEJNV577oR02ZwqIWlIC730CYegM9QjKTLkhVc7FF4EugeQzH8DSfkFl5HO Eb2w== X-Gm-Message-State: AOAM533fQ+yG3WBR6xaoaS7eCSIE50VW3n6Gd4/Kr7pLbaUv32tkvQP/ dSUmXBuG0o2cXPiUmCTWENg/StgcMU+lHg== X-Google-Smtp-Source: ABdhPJyuyxAZZRxXxEcZjymKkii0h0h5xyEvOsrt+cO8go7KgSQU5KqQ4jlX7YthEbQAfqqtKqeuVA== X-Received: by 2002:a17:903:1c8:b0:167:67ff:323d with SMTP id e8-20020a17090301c800b0016767ff323dmr21867638plh.22.1654717980268; Wed, 08 Jun 2022 12:53:00 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id d9-20020a656b89000000b003fd7e217686sm7635036pgw.57.2022.06.08.12.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 12:52:59 -0700 (PDT) Date: Wed, 8 Jun 2022 19:52:55 +0000 From: Sean Christopherson To: Andrew Jones Cc: Paolo Bonzini , kvm@vger.kernel.org, Vitaly Kuznetsov , David Matlack , Ben Gardon , Oliver Upton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 041/144] KVM: selftests: Use vm_create_without_vcpus() in hardware_disable_test Message-ID: References: <20220603004331.1523888-1-seanjc@google.com> <20220603004331.1523888-42-seanjc@google.com> <20220608144332.a5syqvj5ttb2zarw@gator> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220608144332.a5syqvj5ttb2zarw@gator> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2022, Andrew Jones wrote: > On Fri, Jun 03, 2022 at 12:41:48AM +0000, Sean Christopherson wrote: > > Use vm_create_without_vcpus() instead of open coding a rough equivalent > > in hardware_disable_test. > > > > Signed-off-by: Sean Christopherson > > --- > > tools/testing/selftests/kvm/hardware_disable_test.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/hardware_disable_test.c b/tools/testing/selftests/kvm/hardware_disable_test.c > > index 81ba8645772a..32837207fe4e 100644 > > --- a/tools/testing/selftests/kvm/hardware_disable_test.c > > +++ b/tools/testing/selftests/kvm/hardware_disable_test.c > > @@ -104,9 +104,7 @@ static void run_test(uint32_t run) > > for (i = 0; i < VCPU_NUM; i++) > > CPU_SET(i, &cpu_set); > > > > - vm = vm_create(DEFAULT_GUEST_PHY_PAGES); > > - kvm_vm_elf_load(vm, program_invocation_name); > > - vm_create_irqchip(vm); > > + vm = vm_create_without_vcpus(VM_MODE_DEFAULT, DEFAULT_GUEST_PHY_PAGES); > nit: ^ extra space Heh, and I managed to carry that to the end of the series. At least I'm consistent?