Re: [PATCH crypto v4] crypto: blake2s - remove shash module

From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	gaochao <gaochao49@huawei.com>, Ard Biesheuvel <ardb@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH crypto v4] crypto: blake2s - remove shash module
Date: Fri, 10 Jun 2022 17:16:42 +0800	[thread overview]
Message-ID: <YqML+uyz1b7Gw1Bh@gondor.apana.org.au> (raw)
In-Reply-To: <20220528194407.302903-1-Jason@zx2c4.com>

On Sat, May 28, 2022 at 09:44:07PM +0200, Jason A. Donenfeld wrote:
> BLAKE2s has no currently known use as an shash. Just remove all of this
> unnecessary plumbing. Removing this shash was something we talked about
> back when we were making BLAKE2s a built-in, but I simply never got
> around to doing it. So this completes that project.
> 
> Importantly, this fixs a bug in which the lib code depends on
> crypto_simd_disabled_for_test, causing linker errors.
> 
> Also add more alignment tests to the selftests and compare SIMD and
> non-SIMD compression functions, to make up for what we lose from
> testmgr.c.
> 
> Reported-by: gaochao <gaochao49@huawei.com>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: stable@vger.kernel.org
> Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in")
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  arch/arm/crypto/Kconfig           |   2 +-
>  arch/arm/crypto/Makefile          |   4 +-
>  arch/arm/crypto/blake2s-shash.c   |  75 -----------
>  arch/x86/crypto/Makefile          |   4 +-
>  arch/x86/crypto/blake2s-glue.c    |   3 +-
>  arch/x86/crypto/blake2s-shash.c   |  77 -----------
>  crypto/Kconfig                    |  20 +--
>  crypto/Makefile                   |   1 -
>  crypto/blake2s_generic.c          |  75 -----------
>  crypto/tcrypt.c                   |  12 --
>  crypto/testmgr.c                  |  24 ----
>  crypto/testmgr.h                  | 217 ------------------------------
>  include/crypto/internal/blake2s.h | 108 ---------------
>  lib/crypto/blake2s-selftest.c     |  41 ++++++
>  lib/crypto/blake2s.c              |  37 ++++-
>  15 files changed, 76 insertions(+), 624 deletions(-)
>  delete mode 100644 arch/arm/crypto/blake2s-shash.c
>  delete mode 100644 arch/x86/crypto/blake2s-shash.c
>  delete mode 100644 crypto/blake2s_generic.c

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt