Re: [PATCH v2 02/17] regmap-irq: Add get_irq_reg to support unusual register layouts

From: Mark Brown <broonie@kernel.org>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, wens@csie.org,
	jic23@kernel.org, lee.jones@linaro.org, sre@kernel.org,
	gregkh@linuxfoundation.org, lgirdwood@gmail.com, lars@metafoo.de,
	rafael@kernel.org, quic_gurus@quicinc.com,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 02/17] regmap-irq: Add get_irq_reg to support unusual register layouts
Date: Fri, 10 Jun 2022 17:47:05 +0100	[thread overview]
Message-ID: <YqN1iTyyiRx4/CMf@sirena.org.uk> (raw)
In-Reply-To: <6YJcC5wyOg6x6Ny4Os8ujFbK2qB4alkU@localhost>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Fri, Jun 10, 2022 at 04:40:20PM +0100, Aidan MacDonald wrote:
> Mark Brown <broonie@kernel.org> writes:
> > On Tue, Jun 07, 2022 at 04:53:09PM +0100, Aidan MacDonald wrote:

> >> -	if (!chip->sub_reg_offsets || !chip->not_fixed_stride) {
> >> +	if (chip->get_irq_reg) {
> >> +		reg = chip->get_irq_reg(base_reg, i);
> >> +	} else if (!chip->sub_reg_offsets || !chip->not_fixed_stride) {

> > It seems like it would be cleaner and clearer to refactor things so that
> > we always have a get_irq_reg() with standard chips getting given a
> > default implementation which implements the current behaviour.

> I don't think that is a good way to clean things up. I only intended
> get_irq_reg() to be a quick hack to solve a problem; in my opinion it
> would be a poor abstraction to base the API around.

I'm not sure why you are proposing this change if you are so convinced
it's a bad idea.  If you want to propose a different rework go ahead,
but adding the new operation without any form of factoring out is an
issue.  At first glance your suggestion looked plausible.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]