All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Davide Caratti <dcaratti@redhat.com>
Cc: stable@vger.kernel.org, echaudro@redhat.com, i.maximets@ovn.org
Subject: Re: net/sched: act_police: more accurate MTU policing
Date: Mon, 13 Jun 2022 11:11:18 +0200	[thread overview]
Message-ID: <Yqb/NsKSyDmQoS+h@kroah.com> (raw)
In-Reply-To: <YqN6oALiUdh7vnCE@dcaratti.users.ipa.redhat.com>

On Fri, Jun 10, 2022 at 07:08:48PM +0200, Davide Caratti wrote:
> hello Greg,
> 
> thanks for looking at this!
> 
> On Fri, Jun 10, 2022 at 05:09:21PM +0200, Greg KH wrote:
> > On Fri, Jun 10, 2022 at 04:58:37PM +0200, Davide Caratti wrote:
> > > hello,
> > > 
> > > Ilya reports bad TCP throughput when GSO packets hit an OVS rule that does
> > > tc MTU policing. According to his observations [1], the problem is fixed
> > > by upstream commit 4ddc844eb81d ("net/sched: act_police: more accurate MTU
> > > policing"). Can we queue this commit for inclusion in stable trees?
> > 
> > Did you test this,
> 
> I tested it on upstream, RHEL8 and RHEL9 kernels. BTW, the kselftest I included
> in the commit only verifies the correct setting for the MTU threshold, not
> the GSO problem (to test GSO, we should use netperf / iperf3 rather than
> mausezahn to generate traffic).
> 
> > and what kernel(s) do you want it applied to?
> 
> the reported bug is in act_police since the very beginning; however, the
> patch should apply cleanly at least on 5.x kernels. On older ones, there
> might be a small conflict due to lack of RCU-ification of struct
> tcf_police_params.
> A conflict that gets fixed easily, but in case we need it I volunteer to
> write a patch for kernels older than 4.20. @Ilya, what is the
> minimum kernel usable for openvswitch with MTU policing?
> 

It does not apply to 5.10 or earlier, so please provide a working
backport for those kernels if you wish it to be applied there.

thanks,

greg k-h

  parent reply	other threads:[~2022-06-13  9:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 14:58 net/sched: act_police: more accurate MTU policing Davide Caratti
2022-06-10 15:09 ` Greg KH
2022-06-10 17:08   ` Davide Caratti
2022-06-10 19:31     ` Ilya Maximets
2022-06-13  9:11     ` Greg KH [this message]
2022-06-13  9:43       ` Davide Caratti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yqb/NsKSyDmQoS+h@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dcaratti@redhat.com \
    --cc=echaudro@redhat.com \
    --cc=i.maximets@ovn.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.