From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
"linux-perf-use." <linux-perf-users@vger.kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Ian Rogers <irogers@google.com>
Subject: Re: [PATCHv4 bpf-next 0/2] perf tools: Fix prologue generation
Date: Mon, 13 Jun 2022 17:15:30 -0300 [thread overview]
Message-ID: <Yqea4oMxjcnKbPdx@kernel.org> (raw)
In-Reply-To: <YqYTZVa44Y6RQ11W@krava>
Em Sun, Jun 12, 2022 at 06:25:09PM +0200, Jiri Olsa escreveu:
> On Fri, Jun 10, 2022 at 10:53:57PM +0200, Jiri Olsa wrote:
> > On Fri, Jun 10, 2022 at 11:45:48AM -0700, Andrii Nakryiko wrote:
> > > On Fri, Jun 10, 2022 at 11:34 AM Arnaldo Carvalho de Melo
> > > > libbpf: map 'flip_table': created successfully, fd=4
> > > > libbpf: prog 'bpf_func__SyS_epoll_pwait': BPF program load failed: Invalid argument
> > > > libbpf: prog 'bpf_func__SyS_epoll_pwait': -- BEGIN PROG LOAD LOG --
> > > > Invalid insn code at line_info[11].insn_off
> > > Mismatched line_info.
> > > Jiri, I think we need to clear func_info and line_info in
> > > bpf_program__set_insns() because at that point func/line info can be
> > > mismatched and won't correspond to the actual set of instructions.
> so the problem is that we prepend init proglogue instructions
> for each program not just for the one that needs it, so it will
> mismatch later on.. the fix below makes it work for me
> Arnaldo,
> I squashed and pushed the change below changes to my bpf/depre
> branch, could you please retest?
I'll check.
- Arnaldo
next prev parent reply other threads:[~2022-06-13 20:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 20:45 [PATCHv4 bpf-next 0/2] perf tools: Fix prologue generation Jiri Olsa
2022-06-03 20:45 ` [PATCHv4 bpf-next 1/2] perf tools: Register fallback libbpf section handler Jiri Olsa
2022-06-03 20:45 ` [PATCHv4 bpf-next 2/2] perf tools: Rework prologue generation code Jiri Olsa
2022-06-09 20:31 ` [PATCHv4 bpf-next 0/2] perf tools: Fix prologue generation Andrii Nakryiko
2022-06-10 18:34 ` Arnaldo Carvalho de Melo
2022-06-10 18:38 ` Arnaldo Carvalho de Melo
2022-06-10 18:45 ` Andrii Nakryiko
2022-06-10 20:53 ` Jiri Olsa
2022-06-12 16:25 ` Jiri Olsa
2022-06-13 20:15 ` Arnaldo Carvalho de Melo [this message]
2022-06-15 15:27 ` Arnaldo Carvalho de Melo
2022-06-15 19:36 ` Jiri Olsa
2022-06-15 22:12 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yqea4oMxjcnKbPdx@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olsajiri@gmail.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.