From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA623C433EF for ; Wed, 15 Jun 2022 16:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dz/O0ikeJjUv0BwJwc3Q4syKLBVKXikJ4Bw6Mfe9+fE=; b=IOxR1OYdICLAQv 8U1KlekPNLM0ZUYF/Y3nwM3/TlnCYPnTLMh+ZHgj571pQbATvegxfLfU3Tz3jgAfaC7o/tOUx4cun cFdLpi2nwqCYea0fwf8DxMs8oIdFByXvPxqBWqJXQtYLGh4Gnl1hPjC+fqy0YLurs4mbjGvaT8Ymu yUEhHuumq1fQTgG5aAsFpp4kj6qIT1nbc1g90qN35zqXq4P0Ai+2/uf8wPq7gdb+A1lc1SeU43bNP jB6hPK9oUJFItLVEGtaIzxtNyN6gdIvJugqNozRIRC3fkT8ZcVJC8vIoJRs2q7BtzTc/Ukhk0DdVE xwfPvOVtYWwGOQtVXhbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1VT2-00FGox-LF; Wed, 15 Jun 2022 16:02:04 +0000 Received: from mail-ve1eur03on062f.outbound.protection.outlook.com ([2a01:111:f400:fe09::62f] helo=EUR03-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1VSz-00FGo2-NM for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 16:02:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H9aG1Xt9Wzq2GuGBo+1GiEyb8yjgIueQznDcH5xyPRHRYvICyMM/8l8nWDJPpc9mD4bcnnVR1zhGi1fvmAlY8ozpoNhlEsXv0GGoiwvIjHcSvBhVU/Uh8W8qK3uI1FE1XM3oF6WU8kI3btMyZPcc4+MYwambfcCU+Qoc1HQsg9yw1Ao3sOiKUTYo4Pf/BdgLqnsbvuG4z7ouUEybxuey3aEhaBaDklKHh9WDNBgsCtok7vzfLT6AvjXRdnxChfMsOhYQE8+lGBuQk4pSWh1HcuMfqxp0E6XFydHWEny11GvvnN76M3dClTLw4VeHYvIfsiTKwd39KEKgfNuqhNbK3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3qlerEl60aJO2XaM3JROiyUSAAB4/ch5og1qCz/4BFI=; b=Niq288b7F5oxBTK3KZ4Z7B8iXyMIqhJh7CPA2RvTDC7lmCHY0Q8NB3fS7DXPPk4+QU2A/pA+6Xf20m19yQXvd4NR78aReRAKy2mFRRmvPPYrJ9CEbBN4la2E+hYYE1idpp+/Ujy7Q0TeG609cH6NHGxPGX9DwUEja8RLRTNRPCpBgAf7i1mWqRXVQpcWV3nxbe7roLSODwR3sfRkV5+hNV4TwehnBqXo2u8fU6z+8SEy/oQm8Q8iZepMKWbL7d9BLBfIYaW8aJGded+QwBni38qT6sfjmj22Pu7v4E+aRgidpcDejYiwOPJw3NKf3ou6EG9L0RQetenKInSsm+kWew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3qlerEl60aJO2XaM3JROiyUSAAB4/ch5og1qCz/4BFI=; b=iV/gSZQNruDt22IJl0PJUWMDiGYqmDhhR5iqLM/scY6G/yfYdvgJnx2UwEnEtAdYde+Q7x5XUKbsZd3ifIL3loZqylI3fyB9dDwtJcsTKKlUl1tBWpDoM4QC0B5zEbG+/cLkPXy+5KID/nb3/QM5PLIwiBAt675ytLa5Iv2xhrw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) by AM6PR04MB4022.eurprd04.prod.outlook.com (2603:10a6:209:42::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.22; Wed, 15 Jun 2022 15:47:04 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::1989:809a:81e1:adf9]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::1989:809a:81e1:adf9%5]) with mapi id 15.20.5353.013; Wed, 15 Jun 2022 15:47:04 +0000 Date: Wed, 15 Jun 2022 18:47:01 +0300 From: Abel Vesa To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Jacky Bai , Laurent Pinchart , Lucas Stach , Michael Turquette , Shawn Guo , Stephen Boyd , linux-imx@nxp.com Subject: Re: [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control Message-ID: References: <20220504204144.442193-1-marex@denx.de> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AS8PR07CA0055.eurprd07.prod.outlook.com (2603:10a6:20b:459::26) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e070099-686c-4c7a-fdd6-08da4ee64b32 X-MS-TrafficTypeDiagnostic: AM6PR04MB4022:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OgXH2dZc8UhaEbY4IZQa74ut1EiuAnV70oWVQK8gy8Nyec2NkNpce8L5L3AZWSifCfqI+cBvQ/zPgKq5egIaNyy7+FtWVQCkIA5IiRDMgihSt0ws3D6h20SYLQX1/FSIbdU0aWTRQDjd/bxFKF4z9kWuuFHTyR2EtUzzIpu0UNAfPSAxIW+JHejOMvlyigc60ygmzgXMaaAyuN9J4Pn8Cr6TTomz3btBg6AT3XFxhSQTIz8aPLDx2l2xzQetNbYphvpEGbYXufnL8QiQqpQz801i3At45EhfxmmTRXSh5bC2VYdKHheMjzv7TbSj2M+6wcCIQh5BsJ8xs3HywMT1JRlFmjY/vq4vGkpdb396MHJEmugoftJN3/qjCyb4611lzDhWXKCzNWod6pT4mpXgzGh5jqU7N9Ske2iwkqtuXRoMQGey/p5uyI8u+fIk6kPtnGzbS1axxpzEWgsLPMboD/x48PPC3D/5BCiORS2WpGEuiPkSzqk6YVACKNascSq1PxN6dV6ewxQSDNVCxs3IC06jwf29fu+irdroaoVMIu3UItl589/FN92js2agVbqhh5CeswFCA5UCPtfLCWQc9+xR69SxJLmQqHPcD+bDoS2pQwTdAnlLv4jiRSD0G+9eHh/AozcwwG3sBnDfuFece4vrc/dABiPFZCrlntDAA+EBiw/KyItkCBEBG1rPczpCHwk0LswnjEJrYCZAv/awwDfRn/7hUsyIFdXfbdp0SOyi808JWEMJp9Ch+L6m0OE9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4688.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(7916004)(366004)(316002)(54906003)(2906002)(6486002)(6916009)(86362001)(26005)(66556008)(8676002)(66476007)(66946007)(186003)(6666004)(6512007)(4326008)(6506007)(44832011)(38100700002)(8936002)(33716001)(508600001)(83380400001)(38350700002)(9686003)(53546011)(5660300002)(52116002)(32563001)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h/KjFWAcPUEE5uX77mbCq3CQuiQxTYz6lrL20ds811f9Z2M1ox+fNNAqxROM?= =?us-ascii?Q?G5AKqV4ki4sGZHVZCwlUKCnyabQRBpcTHrsIEAlcBJ/Tcjvmr3DfyAMQclqD?= =?us-ascii?Q?9ea+QY0iWUsMKZm8VkKHRh5Dl6EupCCCqbWVvWWFuNO9wT9EIEb/y2MQn7sW?= =?us-ascii?Q?oh/mP+BKjRePv9/wbT+xAPV56bQokCETjGV/LAVNKvGO8nnBLxSWGpR5zyWD?= =?us-ascii?Q?9wrguizoUrnHlOmKuliaCe66tFpbfnFHJahmWPsQ0HAP9dYynWWfPi7VFAs7?= =?us-ascii?Q?RuLWU1A6gfUMj85Onnlk0tx56Yg8DUggFQRHI9a/l647eca7eAHv1DhtbPip?= =?us-ascii?Q?h4jfdz9sap0Ff3rCLhLPrFEZN9t4Wt09HrfE71tGQxJwoIw6UINFYdNTxz1X?= =?us-ascii?Q?eu8ScKaFpoaryabV/CkjdIXSKTCYOv72pGSjkJAVPdNRZRIYRFPecIGMe4eO?= =?us-ascii?Q?4IHgGh8Ptfxrhbt7w8WGqbIj98Ph9FEi08aBSvLVDu4hZyXz3srghNj2wFsc?= =?us-ascii?Q?t6scN8r8gECXDHp4Ps5NMYdlohe2Fh3Go89IvTuHTBw+FEENvCqhSrlB3n5b?= =?us-ascii?Q?+8i8CDj8KiBWRPbRl0EsN6qsjWQNMcAGJ+saSGejRRNrsCMt+lUgH+R7eFxm?= =?us-ascii?Q?uR+JnUEUGgjoWL3D5o060Q5+NKQbGyc7MADaGbudMz0w8Eu6aXlnje+pCJDf?= =?us-ascii?Q?eG6tHBEtlYDxg7rycoujW2/gf1zQKd53UDIt0m3EgS/fHGnDxvi5YJyUcPLz?= =?us-ascii?Q?Oxh3VMjUDqCItmStyT5dJuUUw1vfaL8GmZENkIwN3I/pN0f5N7y9PetsI/z2?= =?us-ascii?Q?qEkRLbhzpRijD/lO6FtnOg1u7M9c9d9IPTnhF3rKkf6OH1SOGQU7w/baQIf6?= =?us-ascii?Q?Hit6RerkUd1E1hGEkAqkkhhwntRXNVQBWbUoMwQHaL8OhSFd+BCWVL2UzEM8?= =?us-ascii?Q?JSvWYkVcXDNZ90+87OEqUBhAHP0z4OjHI0aF2fSgvalyF+v8ENuRlHwuSlmZ?= =?us-ascii?Q?H+E7TTHagWbISgCNryZX857WX3k1ayd3cGe4Zgt2uLiaT2QiacIRAj6HJkfI?= =?us-ascii?Q?K5bGY1bRzlwAuZ+Yi8mjgGg3vghSvcbcecPQHUSEshmV1xeGMizJngblhtQS?= =?us-ascii?Q?4cqX3WxJffzbNJp05A5eXtVtZ5k7FCDqDQcjHnfxKEO0KLX/1eWS9z6skWQe?= =?us-ascii?Q?Qs8Omhy9TdsTfE0jPS4GoReqLRVUciwVNE658wApoWi9k7W5BMxJfig4Swhq?= =?us-ascii?Q?UiHCIL08Y6FLlg60XhxwDYQFP50rd6uPidHpgVNQm3Lj1sZJQq4njzKFVW9G?= =?us-ascii?Q?Usj/YnT9jHNGneAZBSA8tPHeAJ9DbvmkWvuv4r9fjvKWybiOsRMaFIzpZzwA?= =?us-ascii?Q?4ExA7/rTREHZv/kDMqKGS4TGoWQnfoO+mdJ7RgrwZKlhDeuhD5UQ3Bm/3tHf?= =?us-ascii?Q?bn3uS+gy0YYGOmXmFiZpG7Z3UgsC0SMEq9Le/AtjAhpFexxdvSfWN3p9BOTB?= =?us-ascii?Q?8lFrnVgavPLeSAwcIjG+mJBM5v2mI9kmbXjxIP5OTBJZRdGh3WMqVaXP/mKx?= =?us-ascii?Q?25JhR2YJpnV1IzkyV1kGMnfq9JGTJ7FCfXfWSzyFzloqywxkL1/7ad/G+OXg?= =?us-ascii?Q?m0vCG32g4S5OMv2KT5aZMt0GHSkxdcVEk4nmkjX0DQDs993H6DcPBdEYUEk1?= =?us-ascii?Q?3qHbDNB4uEFumNa+17LESiZ0oetzysjthJ/1i6S6LPxyVt6ki4j3d7HPOjyM?= =?us-ascii?Q?RsyRcATY0w=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e070099-686c-4c7a-fdd6-08da4ee64b32 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 15:47:03.8986 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Uf/uBulWgeGBcnZAZenkexNhYWbMiT8IaTV437/qeWH4j9EolY238qgT9A2ZlPgMh48D3SbD3QQ0jZUhMOzKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4022 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_090201_795239_178B54A9 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-06-15 17:08:28, Marek Vasut wrote: > On 6/15/22 16:30, Abel Vesa wrote: > > [...] > > > > +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev) > > > +{ > > > + struct clk_imx8mp_audiomix_priv *priv; > > > + struct device *dev = &pdev->dev; > > > + struct resource *res; > > > + void __iomem *base; > > > + struct clk_hw *hw; > > > + int i; > > > + > > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > > + if (!priv) > > > + return -ENOMEM; > > > + > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > + base = devm_ioremap_resource(dev, res); > > > + if (IS_ERR(base)) > > > + return PTR_ERR(base); > > > + > > > > Hmm, the audiomix blk-ctl driver uses the PD for this device. > > That is not going to work. > > What is not going to work. Can you elaborate on your concerns ? Have a look at drivers/soc/imx/imx8m-blk-ctrl.c. As of now, there is no i.MX8MP audio blk ctrl support added there yet, but once that gets added, that driver will disable the PD from under this clock controller. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel