From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5469C43334 for ; Wed, 15 Jun 2022 14:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s+TDYuWLERRt+P0jjj8WW8Z/7Z8cagHcirXCKG71rJ8=; b=VwqQttQ5ZTQAcA Zl7REAfu9KbHrBRE9c2UduxtSqHqus+F9Sz8qs4i6WNlT4lOtUL2ihlvqDYyoaG/wqTeaZqYm7+/G bs0D8Cl8lCYaLSI7tGCbLq88fwOkltRtJLmUHI/pjpRoqlDnCJEn4W8hHObkM0ruyt/FIGsgrW1F1 sSUpJ1HM13P9i52ziwbCwb4FgPeXkH11HSNnrdNqTbfoc1oyO7gcS0w23KzGYcf/w003hQZdqxKt/ 2kI3kRGI/Bz8yiRpzia4KRcdhTn2Cn6d2SXQr09vYyY5Ug9tXCo9yJMQcQZbx8+Z2FRoRxnz+CIbm nr6JuSH/JTCqrgSHQ5zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1U2E-00Exgg-Ax; Wed, 15 Jun 2022 14:30:18 +0000 Received: from mail-eopbgr70081.outbound.protection.outlook.com ([40.107.7.81] helo=EUR04-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1U2A-00Exdd-Od for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 14:30:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Go1zwEi5g0KwD0SDtdLP6Mk/ssp2XzaB1eKI/CXbL00j5fN4LmS1QUjnApzvDIPBG1hFAF5VUT05CjYlYqAE6uOYIaakZq3Npvg3XtlfjVcJaY9ivTNJvICbf4O+dkzQw1XMQfVIRGN8qdt1pFKzbOs4UshqQDzK8LsPURs7I1nNpaDWbPJMb9aXA6kM8C8nuQektsE3xJnHSXvyBDtUxITf978HO3U+HF9j1cfV+wnlJmn9Ucii6g6aDJPC7yQu9UmY6n8J5XSqeBK/tRWRXIWDuUpHdCj5sOAxZZZQbU8lw9X6krJYHo8AsZWErDHhHZ1QeIFRS3axYkum6jMRsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9QI6b/YW/ofvW4LY4qZ5U4KVppKUIBU8lWKPLF5NM8o=; b=i2AOfenLPz3wrGRxN1pbxOjwbNAMnXCNUl3qQBvLpiuvNTg9pWN/JWkIhUgiPR4AW1xEHeDvy0QLIGJwapt/fX5LOdwaW31hr9+Pl91UZ5uL+STIrPElrFYfA+X6PNnzvR2ydq+i5zD1gRuvojtIOF8fRQOuX1JBPjthFst0g9WLFU1Yi63TL8qX7XhhSivijrf0FwnCPgiYJdrykYzPS1fI4Dvl33UCAZB+aaidTOMdAXS8h6psH1ZOpoNjIfhWDoLcpBqNShDBew10+hgVFC5X4Z7pk5DT/QIEmcj0G1ciPwwBRnZYN4f8QKT0VB+jyPYuvvRuc9djzSOSEMbjEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9QI6b/YW/ofvW4LY4qZ5U4KVppKUIBU8lWKPLF5NM8o=; b=hZVnqV+478CMTPdtEFmmotpYbFGeeajHxBMDudDZtpqWo98MPA+feg0l8RuBCHbsypSoUeDEAQmhMNQzZ2hW9SKTIbl/PxT8ybHyCpeNs11tSsxj/c6qRtN2iKRNRr9y7O9ubeptOuzXYppq9fGkrATCBwskq7DJyyS7WOSWjZg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) by AS4PR04MB9290.eurprd04.prod.outlook.com (2603:10a6:20b:4e5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.21; Wed, 15 Jun 2022 14:30:07 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::1989:809a:81e1:adf9]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::1989:809a:81e1:adf9%5]) with mapi id 15.20.5353.013; Wed, 15 Jun 2022 14:30:07 +0000 Date: Wed, 15 Jun 2022 17:30:05 +0300 From: Abel Vesa To: Marek Vasut Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , Jacky Bai , Laurent Pinchart , Lucas Stach , Michael Turquette , Shawn Guo , Stephen Boyd , linux-imx@nxp.com Subject: Re: [PATCH 1/4] clk: imx: imx8mp: Add audiomix block control Message-ID: References: <20220504204144.442193-1-marex@denx.de> Content-Disposition: inline In-Reply-To: <20220504204144.442193-1-marex@denx.de> X-ClientProxiedBy: AM6P191CA0051.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::28) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43172e68-81df-45cf-e06f-08da4edb8b85 X-MS-TrafficTypeDiagnostic: AS4PR04MB9290:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ll/4nNjT5h34Xp0gY8OliMoRWofIV8JqcBtR9dnNIzT2EAuqJLrGLpNin1xUly5MX/vzFPerTKXqGjU0w4fZ0+tJlmFS6vnWQJDR+FlxVRHqJ8E9befotSeuDIpz9AQJl1+iKqAc1Ow7f9ns1r/n6vYTx/JXaIJwIF51NVBP8790gpcWg9/cE3axotBlCG7YYifXArKQa6cZpeczsYfTNxYpT1nFBaCDhXCGRw2ALGmK8WCnQRLepsFVjiJVDWbBRNKnImCkfgGcZHJc25u/hgWv23VxzT236s5FnuLYS1LQzxOq447rEbN6Bh6AGlGw3v9VJHGIa3qU8l1MrE19392naHeZmkvOzxbZnv7TynHY90iBD64hcXYTt5fI8zrkloiqw1nnRrhPQUQPpBmoiu9MQA9Eld6z2zXYzldwqeVsT8d5Ou8RyICODsfnTc8egVFFkZY42bQGaOKI3zh+qS97Myq0qIGRndP47XqoYIIVO2ztLvKXa/qXtocGMiSGtMYnD7rC29wu9WPHSXxwCJMw01t07fhJovw2wNiq+/J15KRnR/eujSXqvXsFtGgObAkYoaK6dM3zWQ9IdvlKZsGILlKzK5o2I2iNdp9cOezPsti/feWr9s7VxLw1AUZrqzbUN0xCOimP2jzPg7vQ2pQeY3QWraQoxg9Jo+BWGM9DpU5B/PF2kxd+5rmCLVDqt8KrtbRpfX8drmcxNscu3nOxniREu89TjNwCXi4zLvE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB4688.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(4636009)(366004)(6512007)(6506007)(53546011)(26005)(86362001)(52116002)(9686003)(186003)(5660300002)(316002)(6486002)(44832011)(54906003)(6916009)(66556008)(66946007)(8676002)(66476007)(38350700002)(83380400001)(4326008)(8936002)(508600001)(33716001)(38100700002)(2906002)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v+Yw/SxErd3W4bgbaM4ntRJe5jRY7b3lZBBPrOG4l68ERelO7eo0D+ay/1yh?= =?us-ascii?Q?2WW4xiIsr1VzSxtCFM7k1CQPgf/blJgRVTeHZrfuKSJjhKtVipPYg+17dlgW?= =?us-ascii?Q?RTcH5eM4/zgvRg8qz0jp0TnsMgItnmpuQwoKzl/Z/IkFWdL2iIq1epFXBEy4?= =?us-ascii?Q?ZtCaMT+Qy26ITkk5XYWUtz9FyDPV0HCVo6yxqvfd2KZIIEDEJW1TZUusOi5c?= =?us-ascii?Q?BBtGIMLSxGJ8Y/tD4X7m2LuZOqNUiZ5j5Qqheph/iZ2O1lt1uk2AshCqejRN?= =?us-ascii?Q?nNBZxN4WzgIqowtL7nh8vHdDAZFFRT4uScu+mYc1ZItdkNPSwyii5OqPk6va?= =?us-ascii?Q?g7bTP3M/xq0/IFx8uh0AV8iN5NsU9Yvb0yoCi+G3n//P8KC4fJ2zYLglGywf?= =?us-ascii?Q?uoSt/kk5kBfsIV4hfkLSHfcd8zSEvxairZM5tRqben01apOzVkBz7HNWfeWc?= =?us-ascii?Q?vHF1hFOdKh8bNapcctptXgvGjGi4nXvjwBwyZ4mFDAtV3dZpDk5RCcf8CqLG?= =?us-ascii?Q?8Ynp2WgYbxMMiL2ggbFCf/YjMZxWJr8X0mMGOzYWxHqzRmj5Vx9z/RjW+ZFM?= =?us-ascii?Q?9U+st6D3py8021tD05587pK6kWNvpOvxb+0c0CXJMX7Z1dA6yj/Qac5HElBr?= =?us-ascii?Q?lLNCP5JVIJR6D0FvTig0PMTjikojTbq1+WOhTtMF65Fx+W1hUWjyJ4o6j3Iw?= =?us-ascii?Q?nw2tRBIqU+J1jInm2KDMskuG5rvz+BrkMOLbHZvBN41pZHY4YxzGT5v7AzHt?= =?us-ascii?Q?Y9vQZ7g5Nyn8ZBUS33791W5tybf8rUUBQNHn+9JZDCCnyb+xEHxZztCR/BAO?= =?us-ascii?Q?ljiQXHQTxfoxnYttvuijQGskXHB+CGknIwOi8TaATgewqtHEHK2+ZN5IYthQ?= =?us-ascii?Q?DRUA2Pae/b7Oj8JrYDkjviCcBfRo8OPRC+VZFAx5B866MnF+02lMXmonS/or?= =?us-ascii?Q?SQkMa4kz3SMi7SYD36ymSIWR1qxDLze5pdh3pfzhA0FlUu8CCdtI0F0mMwou?= =?us-ascii?Q?A0ZOyOqcuZDk+D3atOWbDwZqx5rL/aPA9J0mmxtQquZWRj6XFa664HKeLd51?= =?us-ascii?Q?MbwWDnVjsfI+gyceN2WdWXdik0dl7qovuzMQrPWjD7TOyqFJLwbfeAkuVBFZ?= =?us-ascii?Q?WLaVlsE/tl1WwTytnFQvjdSx7ThzNVUukoyUiHL9SuNxauS69NIdGrXFNZvC?= =?us-ascii?Q?JzR3+EFmH93FqL9ay1YUSw0yQKc+t/qnaE32Nyq1ESCnnh8vDzHyOmXTrn8A?= =?us-ascii?Q?QAF/d51g3svDXI6Vios+MTt7DGpnVKFoTeGV9PFTk7jxmAifkuKBYcNX9r/E?= =?us-ascii?Q?0D3zB9SlpnIL8g5IS9OHw9gAs1gwtdPmC25tc5CfJIB7+n/BIvAHknI7zD+b?= =?us-ascii?Q?I0E+3dys7Z8wPNeiUNjHWUf26JXU0V9jKqCzXnLDuZy/byDML2XzCWCc84pB?= =?us-ascii?Q?2pPhqYu0BpPuRe+HP8+zj4at5+K95eOmzRGflX6emOxb1dhP7IvgDc/17hZv?= =?us-ascii?Q?KwemLaPjQ1alEMrsmmjhUZjkGUT+ss6Enzkb/j6quQxFOvcuxBeUHZpqTxVs?= =?us-ascii?Q?bqTKBtZtD0lFN60cqRTRjCy0rCeU9QDATn4f5/5Udz6VvXylzbq0fZJyZFr0?= =?us-ascii?Q?YsFdu5otcq0nGJaQVMLMIGMJ7jo0xqyW6H2rAOmRLriyrfOvYQMVRl54GElV?= =?us-ascii?Q?z3+aX3IdGO6k+UtMMa112IAl2DVgdttMxgv9Tnk4m3RkGano7Jf/3UGkRUGm?= =?us-ascii?Q?yr2CIL1yig=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43172e68-81df-45cf-e06f-08da4edb8b85 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 14:30:07.4457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CTtZWE/mMOR/wv5bBwU3SFm3US6/qDoqtItYc/u9nwhjfO4NP/eezlW6GMryjyL6sFcJEMZYIio4Fnl4m7iaaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9290 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_073015_002505_1078C2A0 X-CRM114-Status: GOOD ( 26.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22-05-04 22:41:41, Marek Vasut wrote: > Unlike the other block control IPs in i.MX8M, the audiomix is mostly a > series of clock gates and muxes. Model it as a large static table of > gates and muxes with one exception, which is the PLL14xx . The PLL14xx > SAI PLL has to be registered separately. > See below. > Signed-off-by: Marek Vasut > Cc: Abel Vesa > Cc: Fabio Estevam > Cc: Jacky Bai > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Michael Turquette > Cc: Shawn Guo > Cc: Stephen Boyd > Cc: linux-arm-kernel@lists.infradead.org > To: linux-clk@vger.kernel.org > Cc: linux-imx@nxp.com > --- > drivers/clk/imx/Makefile | 2 +- > drivers/clk/imx/clk-imx8mp-audiomix.c | 262 ++++++++++++++++++++++++++ > 2 files changed, 263 insertions(+), 1 deletion(-) > create mode 100644 drivers/clk/imx/clk-imx8mp-audiomix.c > > diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile > index 88b9b9285d22e..c4290937637eb 100644 > --- a/drivers/clk/imx/Makefile > +++ b/drivers/clk/imx/Makefile > @@ -25,7 +25,7 @@ obj-$(CONFIG_MXC_CLK) += mxc-clk.o > > obj-$(CONFIG_CLK_IMX8MM) += clk-imx8mm.o > obj-$(CONFIG_CLK_IMX8MN) += clk-imx8mn.o > -obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o > +obj-$(CONFIG_CLK_IMX8MP) += clk-imx8mp.o clk-imx8mp-audiomix.o > obj-$(CONFIG_CLK_IMX8MQ) += clk-imx8mq.o > > obj-$(CONFIG_CLK_IMX93) += clk-imx93.o > diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c > new file mode 100644 > index 0000000000000..bfa6080f274ff > --- /dev/null > +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c > @@ -0,0 +1,262 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Driver for i.MX8M Plus Audio BLK_CTRL > + * > + * Copyright (C) 2022 Marek Vasut > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include "clk.h" > + > +#define CLKEN0 0x000 > +#define CLKEN1 0x004 > +#define SAI_MCLK_SEL(n) (300 + 4 * (n)) /* n in 0..5 */ > +#define PDM_SEL 0x318 > +#define SAI_PLL_GNRL_CTL 0x400 > + > +#define SAIn_MCLK1_PARENT(n) \ > +static const char *clk_imx8mp_audiomix_sai##n##_mclk1_parents[] = { \ > + "sai"__stringify(n), "sai"__stringify(n)"_mclk" \ > +} > + > +SAIn_MCLK1_PARENT(1); > +SAIn_MCLK1_PARENT(2); > +SAIn_MCLK1_PARENT(3); > +SAIn_MCLK1_PARENT(5); > +SAIn_MCLK1_PARENT(6); > +SAIn_MCLK1_PARENT(7); > + > +static const char *clk_imx8mp_audiomix_sai_mclk2_parents[] = { > + "sai1", "sai2", "sai3", "dummy", > + "sai5", "sai6", "sai7", > + "sai1_mclk", "sai2_mclk", "sai3_mclk", "dummy", > + "sai5_mclk", "sai6_mclk", "sai7_mclk", > + "spdif_extclk", "dummy" > +}; > + > +static const char *clk_imx8mp_audiomix_pdm_parents[] = { > + "ccm_pdm", "sai_pll_out_div2", "sai1_mclk", "dummy" > +}; > + > + > +static const char * const clk_imx8mp_audiomix_pll_parents[] = { > + "osc_24m", "dummy", "dummy", "dummy" > +}; > + > +static const char * const clk_imx8mp_audiomix_pll_bypass_sels[] = { > + "sai_pll", "sai_pll_ref_sel" > +}; > + > +#define CLK_GATE(name, cname) \ > + { \ > + name"_cg", \ > + IMX8MP_CLK_AUDIOMIX_##cname, \ > + "audio_ahb", NULL, 1, \ > + CLKEN0 + 4 * !!(IMX8MP_CLK_AUDIOMIX_##cname / 32), \ > + 1, IMX8MP_CLK_AUDIOMIX_##cname % 32 \ > + } > + > +#define CLK_SAIn(n) \ > + { \ > + "sai"__stringify(n)"_mclk1_sel", \ > + IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK1_SEL, \ > + NULL, \ > + clk_imx8mp_audiomix_sai##n##_mclk1_parents, \ > + ARRAY_SIZE(clk_imx8mp_audiomix_sai##n##_mclk1_parents), \ > + SAI_MCLK_SEL(n), 1, 0 \ > + }, { \ > + "sai"__stringify(n)"_mclk2_sel", \ > + IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK2_SEL, \ > + NULL, \ > + clk_imx8mp_audiomix_sai_mclk2_parents, \ > + ARRAY_SIZE(clk_imx8mp_audiomix_sai_mclk2_parents), \ > + SAI_MCLK_SEL(n), 4, 1 \ > + }, { \ > + "sai"__stringify(n)"_ipg_cg", \ > + IMX8MP_CLK_AUDIOMIX_SAI##n##_IPG, \ > + "audio_ahb", NULL, 1, \ > + CLKEN0, 1, IMX8MP_CLK_AUDIOMIX_SAI##n##_IPG \ > + }, { \ > + "sai"__stringify(n)"_mclk1_cg", \ > + IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK1, \ > + "sai"__stringify(n)"_mclk1_sel", NULL, 1, \ > + CLKEN0, 1, IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK1 \ > + }, { \ > + "sai"__stringify(n)"_mclk2_cg", \ > + IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK2, \ > + "sai"__stringify(n)"_mclk2_sel", NULL, 1, \ > + CLKEN0, 1, IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK2 \ > + }, { \ > + "sai"__stringify(n)"_mclk3_cg", \ > + IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK3, \ > + "sai_pll_out_div2", NULL, 1, \ > + CLKEN0, 1, IMX8MP_CLK_AUDIOMIX_SAI##n##_MCLK3 \ > + } > + > +#define CLK_PDM \ > + { \ > + "pdm_sel", IMX8MP_CLK_AUDIOMIX_PDM_SEL, NULL, \ > + clk_imx8mp_audiomix_pdm_parents, \ > + ARRAY_SIZE(clk_imx8mp_audiomix_pdm_parents), \ > + PDM_SEL, 2, 0 \ > + } > + > +struct clk_imx8mp_audiomix_sel { > + const char *name; > + int clkid; > + const char *parent; /* For gate */ > + const char **parents; /* For mux */ > + int num_parents; > + u16 reg; > + u8 width; > + u8 shift; > +}; > + > +static struct clk_imx8mp_audiomix_sel sels[] = { > + CLK_GATE("asrc", ASRC_IPG), > + CLK_GATE("pdm", PDM_IPG), > + CLK_GATE("earc", EARC_IPG), > + CLK_GATE("ocrama", OCRAMA_IPG), > + CLK_GATE("aud2htx", AUD2HTX_IPG), > + CLK_GATE("earc_phy", EARC_PHY), > + CLK_GATE("sdma2", SDMA2_ROOT), > + CLK_GATE("sdma3", SDMA3_ROOT), > + CLK_GATE("spba2", SPBA2_ROOT), > + CLK_GATE("dsp", DSP_ROOT), > + CLK_GATE("dspdbg", DSPDBG_ROOT), > + CLK_GATE("edma", EDMA_ROOT), > + CLK_GATE("audpll", AUDPLL_ROOT), > + CLK_GATE("mu2", MU2_ROOT), > + CLK_GATE("mu3", MU3_ROOT), > + CLK_PDM, > + CLK_SAIn(1), > + CLK_SAIn(2), > + CLK_SAIn(3), > + CLK_SAIn(5), > + CLK_SAIn(6), > + CLK_SAIn(7) > +}; > + > +struct clk_imx8mp_audiomix_priv { > + struct clk_hw *clk[IMX8MP_CLK_AUDIOMIX_END]; > +}; > + > +static struct clk_hw * > +clk_imx8mp_audiomix_of_clk_get(struct of_phandle_args *clkspec, void *data) > +{ > + struct clk_imx8mp_audiomix_priv *priv = data; > + unsigned int idx = clkspec->args[0]; > + > + return priv->clk[idx]; > +} > + > +static int clk_imx8mp_audiomix_probe(struct platform_device *pdev) > +{ > + struct clk_imx8mp_audiomix_priv *priv; > + struct device *dev = &pdev->dev; > + struct resource *res; > + void __iomem *base; > + struct clk_hw *hw; > + int i; > + > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > + if (!priv) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + base = devm_ioremap_resource(dev, res); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + Hmm, the audiomix blk-ctl driver uses the PD for this device. That is not going to work. Lucas, any suggestions on how we can deal with this? > + for (i = 0; i < ARRAY_SIZE(sels); i++) { > + if (sels[i].num_parents == 1) { > + hw = devm_clk_hw_register_gate(dev, > + sels[i].name, > + sels[i].parent, > + 0, > + base + sels[i].reg, > + sels[i].shift, > + 0, NULL); > + } else { > + hw = devm_clk_hw_register_mux(dev, sels[i].name, > + sels[i].parents, > + sels[i].num_parents, > + 0, > + base + sels[i].reg, > + sels[i].shift, > + sels[i].width, > + 0, NULL); > + } > + > + if (IS_ERR(hw)) > + return PTR_ERR(hw); > + > + priv->clk[sels[i].clkid] = hw; > + } > + > + /* SAI PLL */ > + hw = devm_clk_hw_register_mux(dev, "sai_pll_ref_sel", > + clk_imx8mp_audiomix_pll_parents, > + ARRAY_SIZE(clk_imx8mp_audiomix_pll_parents), > + CLK_SET_RATE_NO_REPARENT, > + base + SAI_PLL_GNRL_CTL, 0, 2, 0, NULL); > + priv->clk[IMX8MP_CLK_AUDIOMIX_SAI_PLL_REF_SEL] = hw; > + > + hw = imx_dev_clk_hw_pll14xx(dev, "sai_pll", "sai_pll_ref_sel", > + base + 0x400, &imx_1443x_pll); > + if (IS_ERR(hw)) > + return PTR_ERR(hw); > + priv->clk[IMX8MP_CLK_AUDIOMIX_SAI_PLL] = hw; > + > + hw = devm_clk_hw_register_mux(dev, "sai_pll_bypass", > + clk_imx8mp_audiomix_pll_bypass_sels, > + ARRAY_SIZE(clk_imx8mp_audiomix_pll_bypass_sels), > + CLK_SET_RATE_NO_REPARENT | CLK_SET_RATE_PARENT, > + base + SAI_PLL_GNRL_CTL, 16, 1, 0, NULL); > + if (IS_ERR(hw)) > + return PTR_ERR(hw); > + priv->clk[IMX8MP_CLK_AUDIOMIX_SAI_PLL_BYPASS] = hw; > + > + hw = devm_clk_hw_register_gate(dev, "sai_pll_out", "sai_pll_bypass", > + 0, base + SAI_PLL_GNRL_CTL, 13, > + 0, NULL); > + if (IS_ERR(hw)) > + return PTR_ERR(hw); > + priv->clk[IMX8MP_CLK_AUDIOMIX_SAI_PLL_OUT] = hw; > + > + hw = devm_clk_hw_register_fixed_factor(dev, "sai_pll_out_div2", > + "sai_pll_out", 0, 1, 2); > + if (IS_ERR(hw)) > + return PTR_ERR(hw); > + > + return devm_of_clk_add_hw_provider(&pdev->dev, > + clk_imx8mp_audiomix_of_clk_get, > + priv); > +} > + > +static const struct of_device_id clk_imx8mp_audiomix_of_match[] = { > + { .compatible = "fsl,imx8mp-audio-blk-ctrl" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, clk_imx8mp_audiomix_of_match); > + > +static struct platform_driver clk_imx8mp_audiomix_driver = { > + .probe = clk_imx8mp_audiomix_probe, > + .driver = { > + .name = "imx8mp-audio-blk-ctrl", > + .of_match_table = clk_imx8mp_audiomix_of_match, > + }, > +}; > + > +module_platform_driver(clk_imx8mp_audiomix_driver); > + > +MODULE_AUTHOR("Marek Vasut "); > +MODULE_DESCRIPTION("Freescale i.MX8MP Audio Block Controller driver"); > +MODULE_LICENSE("GPL"); > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel