From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE8DDCCA473 for ; Wed, 15 Jun 2022 18:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244809AbiFOSsU (ORCPT ); Wed, 15 Jun 2022 14:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350000AbiFOSsT (ORCPT ); Wed, 15 Jun 2022 14:48:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60C7B427E5; Wed, 15 Jun 2022 11:48:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0ADB1B820CE; Wed, 15 Jun 2022 18:48:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26A89C34115; Wed, 15 Jun 2022 18:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655318895; bh=rMfZlPzH3rsFNG1zLEXYrykD4al7iaf+NOh8lw+/v1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mk2j1akEb5Ib5eTZplnO4HfSdqyNUNM4iM2GZU569SAmwb4GFd26OOvuIZMEf+VFh +69B87BdFUNEuzdlMIeXUs5PZl/q8k57YIw4Y4dxHM2CEBwHVbhdaYEVR41e84HAdA CFYduW4GiQBeVonsAKKewqMlPxRdzfbUHLdNnV59wbte78+RIhIAhVB/vuBRcGcOZp npsgWticzkdhX8j6bgK1iCTDWQTxuULIkCcPno2LlDGAjR7TSjw2rJzlQNs/x7rPwv 4I8ajie8cNZlz4gX5v6Qp9p7Rti3OVRLdcqMYvfSZ85pwdM4ZiL0itdvUAf2dl8EYa OIAolRufwRAeQ== Date: Wed, 15 Jun 2022 21:46:07 +0300 From: Jarkko Sakkinen To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, David Howells , =?utf-8?B?TWlja2Hvv73vv73vv71sIFNhbGHvv73vv73vv71u?= , David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] certs/blacklist_hashes.c: fix const confusion in certs blacklist Message-ID: References: <20220611172233.1494073-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220611172233.1494073-1-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org On Sun, Jun 12, 2022 at 02:22:30AM +0900, Masahiro Yamada wrote: > This file fails to compile as follows: > > CC certs/blacklist_hashes.o > certs/blacklist_hashes.c:4:1: error: ignoring attribute ‘section (".init.data")’ because it conflicts with previous ‘section (".init.rodata")’ [-Werror=attributes] > 4 | const char __initdata *const blacklist_hashes[] = { > | ^~~~~ > In file included from certs/blacklist_hashes.c:2: > certs/blacklist.h:5:38: note: previous declaration here > 5 | extern const char __initconst *const blacklist_hashes[]; > | ^~~~~~~~~~~~~~~~ > > Apply the same fix as commit 2be04df5668d ("certs/blacklist_nohashes.c: > fix const confusion in certs blacklist"). > > Fixes: 734114f8782f ("KEYS: Add a system blacklist keyring") > Signed-off-by: Masahiro Yamada > --- > > certs/blacklist_hashes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/certs/blacklist_hashes.c b/certs/blacklist_hashes.c > index 344892337be0..d5961aa3d338 100644 > --- a/certs/blacklist_hashes.c > +++ b/certs/blacklist_hashes.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > #include "blacklist.h" > > -const char __initdata *const blacklist_hashes[] = { > +const char __initconst *const blacklist_hashes[] = { > #include CONFIG_SYSTEM_BLACKLIST_HASH_LIST > , NULL > }; > -- > 2.32.0 > Reviewed-by: Jarkko Sakkinen BR, Jarkko