From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F6BFC43334 for ; Wed, 15 Jun 2022 21:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348444AbiFOVst (ORCPT ); Wed, 15 Jun 2022 17:48:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349199AbiFOVsh (ORCPT ); Wed, 15 Jun 2022 17:48:37 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D36E377C4 for ; Wed, 15 Jun 2022 14:48:35 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id f65so12568194pgc.7 for ; Wed, 15 Jun 2022 14:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FZSDdV6mNRQiDJWSYS9igOAu0wbjoocy2kuoW1xZJug=; b=ZpEJrFA438ZSkfTtEVYExa6cnAWhsvmUfpjsXYhT3+RglSUp+BETn8FrcoVEUH1Xf3 w89oj7m1+dvWYEBxZTzq8TOIK8k7osRT9F74IS6tONgVl/5eeyTXRDi4TNMcOvgrgGyK vtqC3QS4kuPYkPGwcJ41fbjaNm+v47aPMQA70fUDHFmvVcvy3Fq8Id2wO6YPLQhbfk+m ObQQZHAfWJStEW2KMHfeluBeHBzPldcOqfOXoL4LybCKsNNGImxL7J0tQj3XW1OJ/Cs7 RYDFS/eBia5pw8WTh0ft13K/OGlBMrdMbKZ1B0ZXhfp2CZOsjSsA4O/eFJ6WV9w/PsIp 2IyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FZSDdV6mNRQiDJWSYS9igOAu0wbjoocy2kuoW1xZJug=; b=aGK/b6DVUOtfFGpHPlMIwWikjYiFTB18BWpF7o2OeG91KmgTZaedg/S+LrO0xIDVwR YupWRGuq1DWmLGxnbggd+EvQx39a1U3YARx91aL7GRyhCI+DF7uUqMJNxl9/g/ooo4Tj lIoRfo5pcd+ibU3jb/vjDLaMqbxvXRmP1hJvAobUExGFlp5TLj+v5JY59AFvLrADU/Zq UvH+LkTGr0hkPtjFdwmKtFCPt0ddnSCn0ru/zLDLUDpCsCgeKJkv1gWPd4HpZC799dn6 XSwREDoaW5qjaZKcvHm4g3LyTadHsjH63y0w6HU6weyotF5BdplwXNMTgEKTZ9lh9eMo klNA== X-Gm-Message-State: AJIora8zneynAFjmFYzmGV0iwd0Q8eumdO7AFsZ4EPovF77my5uMb7tz kNQZuHbwI+HC3AyOwDZaT4ARwA== X-Google-Smtp-Source: AGRyM1vkhWHhrlIjk/HHd51WfK5Or24gmvhP0SqUbOiKWv1kc7ZmeBlxTK44Ul6iywlD0zO883LPZg== X-Received: by 2002:aa7:94a6:0:b0:51b:ddb8:1fcf with SMTP id a6-20020aa794a6000000b0051bddb81fcfmr1411308pfl.23.1655329714602; Wed, 15 Jun 2022 14:48:34 -0700 (PDT) Received: from google.com ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id u1-20020a170903124100b00163f8ddf160sm97347plh.161.2022.06.15.14.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 14:48:34 -0700 (PDT) Date: Wed, 15 Jun 2022 22:48:31 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys Message-ID: References: <20220520124617.228808-1-angelogioacchino.delregno@collabora.com> <20220520124617.228808-2-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220520124617.228808-2-angelogioacchino.delregno@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote: > MT6331 is a multifunction device, providing RTC, keys and more: add No such thing as an MFD. What does the data-sheet call it? What "more"? > the necessary compatibles to start implementing the basics. > > Signed-off-by: AngeloGioacchino Del Regno > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index d59063503b0d..2a9533c47365 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -30,6 +30,7 @@ Optional subnodes: > - rtc > Required properties: Should be one of follows > - compatible: "mediatek,mt6323-rtc" > + - compatible: "mediatek,mt6331-rtc" > - compatible: "mediatek,mt6358-rtc" > - compatible: "mediatek,mt6397-rtc" > For details, see ../rtc/rtc-mt6397.txt > @@ -55,6 +56,7 @@ Optional subnodes: > - keys > Required properties: > - compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys" > + or "mediatek,mt6331-keys" Please place these in a vertical list. > see ../input/mtk-pmic-keys.txt > > - power-controller -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5601FC433EF for ; Wed, 15 Jun 2022 21:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FEls0T0roqtsBfczgorCnjW/2E8s1VuDf2xvgkMGs14=; b=t6bivZ42rwM2k8 ptM3r+ZJ2gwq/29mE1IcNtwdXfk+6YwuGZYH59yA/MAci2vmbnjGeGpdscjxPt8ExMTM6/sUb9WZL ueNK/hl5jav8K7NNMBZyeD9kv9Rmoe5Tc/bd2AJ1qJpTjfwcARNxjHRWDlm4Ajd//gg9fQK7uRPr3 wf5O6Ydtv8IjhdBAoUfypHnZ/mtpgDAVlTll4Cw6bk4ugd+U+rRUK2esFdh8jFi3Tpq4IJqyQucsy h7jLyTXPnF59IxNoZDDyo2M2dj2fXrW5Gvxd+QmPvCMAOtWttpUOTk71q8xovEPDQP+3PKsw/j9kf 3LrpUdKBWFUla2OMtR3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1asQ-00GWLT-GL; Wed, 15 Jun 2022 21:48:38 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1asN-00GWKM-E0 for linux-arm-kernel@lists.infradead.org; Wed, 15 Jun 2022 21:48:37 +0000 Received: by mail-pf1-x436.google.com with SMTP id 187so12589536pfu.9 for ; Wed, 15 Jun 2022 14:48:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=FZSDdV6mNRQiDJWSYS9igOAu0wbjoocy2kuoW1xZJug=; b=ZpEJrFA438ZSkfTtEVYExa6cnAWhsvmUfpjsXYhT3+RglSUp+BETn8FrcoVEUH1Xf3 w89oj7m1+dvWYEBxZTzq8TOIK8k7osRT9F74IS6tONgVl/5eeyTXRDi4TNMcOvgrgGyK vtqC3QS4kuPYkPGwcJ41fbjaNm+v47aPMQA70fUDHFmvVcvy3Fq8Id2wO6YPLQhbfk+m ObQQZHAfWJStEW2KMHfeluBeHBzPldcOqfOXoL4LybCKsNNGImxL7J0tQj3XW1OJ/Cs7 RYDFS/eBia5pw8WTh0ft13K/OGlBMrdMbKZ1B0ZXhfp2CZOsjSsA4O/eFJ6WV9w/PsIp 2IyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=FZSDdV6mNRQiDJWSYS9igOAu0wbjoocy2kuoW1xZJug=; b=yx/6OjvT7UeiB7cMgNaGs6S3KI4jpq/uozwMK8cp6slDgfKCY4rtiK5LttE6SrSmve DGt/BuJoi+WvbON2yBSuSs5MYr6N56KCf2dCkFqsgmrgwQ+uRn01+uoZwKCoVsLn9QGD +Y748H+vb9ctIjov8KUPchyfVTMtzgH7fOh0f4cg+z7hwamBYvQncPOZ8a0eT784Bavq /0WB3a7yY6w/Zvt49tuKirWE3qGUAUNYcwc9t2LVFZi89C9R2itYYMFg+4UibPSE1ARS WiDZs1FRmGpER6dk6PN31fQnM1+MiXyAJ/yGUadqgLuikdM5Wf+lSflX1QVCDFLrWy7b tgAQ== X-Gm-Message-State: AJIora8G0GeemJTRB7J3xz7J4cdNSx6nsaGn9TymVcmWe+g3Sf7PUuLn rFi4IubNe8Yq9petcVoesdSwdw== X-Google-Smtp-Source: AGRyM1vkhWHhrlIjk/HHd51WfK5Or24gmvhP0SqUbOiKWv1kc7ZmeBlxTK44Ul6iywlD0zO883LPZg== X-Received: by 2002:aa7:94a6:0:b0:51b:ddb8:1fcf with SMTP id a6-20020aa794a6000000b0051bddb81fcfmr1411308pfl.23.1655329714602; Wed, 15 Jun 2022 14:48:34 -0700 (PDT) Received: from google.com ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id u1-20020a170903124100b00163f8ddf160sm97347plh.161.2022.06.15.14.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 14:48:34 -0700 (PDT) Date: Wed, 15 Jun 2022 22:48:31 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys Message-ID: References: <20220520124617.228808-1-angelogioacchino.delregno@collabora.com> <20220520124617.228808-2-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220520124617.228808-2-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220615_144835_538267_BF7CA66C X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMCBNYXkgMjAyMiwgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6Cgo+ IE1UNjMzMSBpcyBhIG11bHRpZnVuY3Rpb24gZGV2aWNlLCBwcm92aWRpbmcgUlRDLCBrZXlzIGFu ZCBtb3JlOiBhZGQKCk5vIHN1Y2ggdGhpbmcgYXMgYW4gTUZELiAgV2hhdCBkb2VzIHRoZSBkYXRh LXNoZWV0IGNhbGwgaXQ/CgpXaGF0ICJtb3JlIj8KCj4gdGhlIG5lY2Vzc2FyeSBjb21wYXRpYmxl cyB0byBzdGFydCBpbXBsZW1lbnRpbmcgdGhlIGJhc2ljcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBB bmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyA8YW5nZWxvZ2lvYWNjaGluby5kZWxyZWdub0Bjb2xs YWJvcmEuY29tPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWZk L210NjM5Ny50eHQgfCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiAK PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9tdDYz OTcudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9tdDYzOTcudHh0 Cj4gaW5kZXggZDU5MDYzNTAzYjBkLi4yYTk1MzNjNDczNjUgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9tdDYzOTcudHh0Cj4gKysrIGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9tdDYzOTcudHh0Cj4gQEAgLTMwLDYgKzMw LDcgQEAgT3B0aW9uYWwgc3Vibm9kZXM6Cj4gIC0gcnRjCj4gIAlSZXF1aXJlZCBwcm9wZXJ0aWVz OiBTaG91bGQgYmUgb25lIG9mIGZvbGxvd3MKPiAgCQktIGNvbXBhdGlibGU6ICJtZWRpYXRlayxt dDYzMjMtcnRjIgo+ICsJCS0gY29tcGF0aWJsZTogIm1lZGlhdGVrLG10NjMzMS1ydGMiCj4gIAkJ LSBjb21wYXRpYmxlOiAibWVkaWF0ZWssbXQ2MzU4LXJ0YyIKPiAgCQktIGNvbXBhdGlibGU6ICJt ZWRpYXRlayxtdDYzOTctcnRjIgo+ICAJRm9yIGRldGFpbHMsIHNlZSAuLi9ydGMvcnRjLW10NjM5 Ny50eHQKPiBAQCAtNTUsNiArNTYsNyBAQCBPcHRpb25hbCBzdWJub2RlczoKPiAgLSBrZXlzCj4g IAlSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICAJCS0gY29tcGF0aWJsZTogIm1lZGlhdGVrLG10NjM5 Ny1rZXlzIiBvciAibWVkaWF0ZWssbXQ2MzIzLWtleXMiCj4gKwkJCSAgICAgIG9yICJtZWRpYXRl ayxtdDYzMzEta2V5cyIKClBsZWFzZSBwbGFjZSB0aGVzZSBpbiBhIHZlcnRpY2FsIGxpc3QuCgo+ ICAJc2VlIC4uL2lucHV0L210ay1wbWljLWtleXMudHh0Cj4gIAo+ICAtIHBvd2VyLWNvbnRyb2xs ZXIKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KUHJpbmNpcGFsIFRlY2huaWNhbCBMZWFkIC0g RGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZv ciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==