All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: xiakaixu1987@gmail.com
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	djwong@kernel.org, hch@infradead.org,
	Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] iomap: set did_zero to true when zeroing successfully
Date: Thu, 16 Jun 2022 00:28:26 -0700	[thread overview]
Message-ID: <YqrbmiZ4HMiuvl17@infradead.org> (raw)
In-Reply-To: <1655198062-13288-1-git-send-email-kaixuxia@tencent.com>

On Tue, Jun 14, 2022 at 05:14:22PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> It is unnecessary to check and set did_zero value in while() loop,
> we can set did_zero to true only when zeroing successfully at last.

Looks good, but this really should be separate patches for dax and
iomap.

  parent reply	other threads:[~2022-06-16  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  9:14 [PATCH] iomap: set did_zero to true when zeroing successfully xiakaixu1987
2022-06-15 22:07 ` Chaitanya Kulkarni
2022-06-16  7:28 ` Christoph Hellwig [this message]
2022-06-16 11:14   ` Kaixu Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqrbmiZ4HMiuvl17@infradead.org \
    --to=hch@infradead.org \
    --cc=djwong@kernel.org \
    --cc=kaixuxia@tencent.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=xiakaixu1987@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.