From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6372C433EF for ; Thu, 16 Jun 2022 18:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378067AbiFPSkf (ORCPT ); Thu, 16 Jun 2022 14:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378041AbiFPSkd (ORCPT ); Thu, 16 Jun 2022 14:40:33 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98D85544CB for ; Thu, 16 Jun 2022 11:40:32 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id y196so2214370pfb.6 for ; Thu, 16 Jun 2022 11:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HU/S2rDRdJXSvF2HJYT5MX/Baf9+5cy35uV5UBnDVAE=; b=UgAioPDwOol1mtX0moiIbUq+7g/dIGZTQMDu5AExU6sV7xVip/EnXbsCYhrh+WNSuv 3h3bc+N4mJWEnpIVGGN5FXzozf+7YN/8zTSAkAwZfnleROINqUyL24D1QrqvXWGRhx+K OCqAZBEhp4X769KOpgSkUT89EKd/ve/Di6LiAM2REFFYHDOxtaTwUFQoTBWzPX71QHsm Yl6jlmv1I6C+WmgoUV0wwSo/7SeDGhP5hOb9SNMtF7Uop4RTkdB7KdgIWoftWnCBY70s /Wkm+ijxr+jah2XQshzjkHeeKoAAOWtzKrVhnik94cYstOcvMlmgSuELVNle2JqCOVUh Hi2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HU/S2rDRdJXSvF2HJYT5MX/Baf9+5cy35uV5UBnDVAE=; b=Pl0Xu7sgVbzAphsC2rVhZSWW8AELqAPFBtAcCFWNbfq/mrye9UfDCf6R9IrhMoqa8k 6fcnbg0obUCz3upSQq5rI7a5sVVPPOx4SjwO8YdP9cL2tkT15IRZzPqz09OIlSRfOvZ4 1vEdZuQ3i0IwseeMFfnvW4NfYapr6DzpZ5scnuopXg+pykhAbltreJwhi+Rskl5fXXta tS1BWY0Qflk7i+PocTMqMvaN4BuTRPSnHnTiDDUr+SXyD/ZH4sz9dnfgbwA2EHIpIUnv naD/qNpdzFCRnFpaRr/jf4lAU3o81TABKJ2ZbF6FiY1utV2HsZc4kPgqSKYKbAXkC6vh 8esA== X-Gm-Message-State: AJIora9oa7wznAyKlfyHfcin7LQ2NXVYawLIq8aMNViQkVS8Jr6LcT4s SpiZGAD0/mlb8ktwhNdUa+BgZg== X-Google-Smtp-Source: AGRyM1uTOQPUU6gJIf2RfGvYLof4xidypQqv0TIVUTH6ipWOrME4pI+sniIJ6KwXyC6IjQxxeU2/2g== X-Received: by 2002:a63:441f:0:b0:3fc:8bd2:f828 with SMTP id r31-20020a63441f000000b003fc8bd2f828mr5506549pga.579.1655404832093; Thu, 16 Jun 2022 11:40:32 -0700 (PDT) Received: from google.com ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id o11-20020a63730b000000b003fadfd7be5asm2148272pgc.18.2022.06.16.11.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 11:40:31 -0700 (PDT) Date: Thu, 16 Jun 2022 19:40:28 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: mt6397: Add basic support for MT6331+MT6332 PMIC Message-ID: References: <20220520124617.228808-1-angelogioacchino.delregno@collabora.com> <20220520124617.228808-3-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220520124617.228808-3-angelogioacchino.delregno@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote: 65;6800;1c > Add support for the MT6331 PMIC with MT6332 Companion PMIC, found > in MT6795 Helio X10 smartphone platforms. > > This combo has support for multiple devices but, for a start, > only the following have been implemented: > - Regulators (two instances, one in MT6331, one in MT6332) > - RTC (MT6331) > - Keys (MT6331) > - Interrupts (MT6331 also dispatches MT6332's interrupts) > > There's more to be implemented, especially for MT6332, which > will come at a later stage. > > Signed-off-by: AngeloGioacchino Del Regno > --- > drivers/mfd/mt6397-core.c | 47 ++ > drivers/mfd/mt6397-irq.c | 9 +- > include/linux/mfd/mt6331/core.h | 53 +++ > include/linux/mfd/mt6331/registers.h | 584 ++++++++++++++++++++++++ > include/linux/mfd/mt6332/core.h | 53 +++ > include/linux/mfd/mt6332/registers.h | 642 +++++++++++++++++++++++++++ > include/linux/mfd/mt6397/core.h | 2 + > 7 files changed, 1389 insertions(+), 1 deletion(-) > create mode 100644 include/linux/mfd/mt6331/core.h > create mode 100644 include/linux/mfd/mt6331/registers.h > create mode 100644 include/linux/mfd/mt6332/core.h > create mode 100644 include/linux/mfd/mt6332/registers.h For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64C5CC433EF for ; Thu, 16 Jun 2022 18:42:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fa4Skilb96b+ySxaKenOJCQU4a1d/PRo00xsoUE+Rvc=; b=RETyIVVX0mcsTm ydc2ek5/LxIZ/o3IJG6tLGdyghhBKC/Fj/2d4QX5HNIBrgCZhe0bVAUY4/TSpWDl0NtPQcIfjwz7H u4AMhgWFPsBDSsAC9LH8bX+XNkXfYn3T+003zHQm6qQAKsVGH7nBQxizdcjMrMFKQG7gQBGCT1gOZ q6LXQZldMAn8w132j1PQPKkgF6rQ4/tHVGRv+nsSldYpPbQBkAqxNIcNF0wrnuhpt/SgXBxylWiR5 42+n+lOk4UGlZbTdaklQPLYR/kw6+fjkRd0TwkLCe3cSVZxjWM4SeDYjyizycSRoteYJOyTpE77qX pZXF9b86CJbQMKWk29eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1uQ8-003ryw-Ty; Thu, 16 Jun 2022 18:40:45 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1uQ4-003rxE-Vx for linux-arm-kernel@lists.infradead.org; Thu, 16 Jun 2022 18:40:42 +0000 Received: by mail-pg1-x531.google.com with SMTP id g186so2020516pgc.1 for ; Thu, 16 Jun 2022 11:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HU/S2rDRdJXSvF2HJYT5MX/Baf9+5cy35uV5UBnDVAE=; b=UgAioPDwOol1mtX0moiIbUq+7g/dIGZTQMDu5AExU6sV7xVip/EnXbsCYhrh+WNSuv 3h3bc+N4mJWEnpIVGGN5FXzozf+7YN/8zTSAkAwZfnleROINqUyL24D1QrqvXWGRhx+K OCqAZBEhp4X769KOpgSkUT89EKd/ve/Di6LiAM2REFFYHDOxtaTwUFQoTBWzPX71QHsm Yl6jlmv1I6C+WmgoUV0wwSo/7SeDGhP5hOb9SNMtF7Uop4RTkdB7KdgIWoftWnCBY70s /Wkm+ijxr+jah2XQshzjkHeeKoAAOWtzKrVhnik94cYstOcvMlmgSuELVNle2JqCOVUh Hi2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HU/S2rDRdJXSvF2HJYT5MX/Baf9+5cy35uV5UBnDVAE=; b=gloVdsA33Ch5dHwE5hTKlQVEcKDTO/0s6sg6g6oUi61w8zqKuC9b8JetE3ycotplmB d0Mzu56AysfCQS0463sk/K+7lO7CHxOejb0mOppaGLZD1fRyi8PR6X/DLSDU/keq0urZ kKdPoQ9pm4aW4CUgJvkaloF8GD/Wt6fHrnJX7b7W1s3AqkhksfjXq20q+LWnD+p8kC6/ uV87P+PfDvWXxvvNVM9fl+bxFuv6ot/hODQxkEhO21K65LOTefB2GugW1Pn4167PIj56 aKWrjRUsqjkOfbPzj7kPgLFQn3DHT04AGSDtlNtM3SyoC8M7jKmaYnl2ReDEQa/854XE l54g== X-Gm-Message-State: AJIora/rbjpp56xO4knNzXKua8NSPCTsPbiuo3w9AewikKhrb9tgBM75 lUodCrVaU9xz7QO230kgvfCn0w== X-Google-Smtp-Source: AGRyM1uTOQPUU6gJIf2RfGvYLof4xidypQqv0TIVUTH6ipWOrME4pI+sniIJ6KwXyC6IjQxxeU2/2g== X-Received: by 2002:a63:441f:0:b0:3fc:8bd2:f828 with SMTP id r31-20020a63441f000000b003fc8bd2f828mr5506549pga.579.1655404832093; Thu, 16 Jun 2022 11:40:32 -0700 (PDT) Received: from google.com ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id o11-20020a63730b000000b003fadfd7be5asm2148272pgc.18.2022.06.16.11.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jun 2022 11:40:31 -0700 (PDT) Date: Thu, 16 Jun 2022 19:40:28 +0100 From: Lee Jones To: AngeloGioacchino Del Regno Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: mt6397: Add basic support for MT6331+MT6332 PMIC Message-ID: References: <20220520124617.228808-1-angelogioacchino.delregno@collabora.com> <20220520124617.228808-3-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220520124617.228808-3-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_114041_090455_1BCBD712 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAyMCBNYXkgMjAyMiwgQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gd3JvdGU6CjY1 OzY4MDA7MWMKPiBBZGQgc3VwcG9ydCBmb3IgdGhlIE1UNjMzMSBQTUlDIHdpdGggTVQ2MzMyIENv bXBhbmlvbiBQTUlDLCBmb3VuZAo+IGluIE1UNjc5NSBIZWxpbyBYMTAgc21hcnRwaG9uZSBwbGF0 Zm9ybXMuCj4gCj4gVGhpcyBjb21ibyBoYXMgc3VwcG9ydCBmb3IgbXVsdGlwbGUgZGV2aWNlcyBi dXQsIGZvciBhIHN0YXJ0LAo+IG9ubHkgdGhlIGZvbGxvd2luZyBoYXZlIGJlZW4gaW1wbGVtZW50 ZWQ6Cj4gLSBSZWd1bGF0b3JzICh0d28gaW5zdGFuY2VzLCBvbmUgaW4gTVQ2MzMxLCBvbmUgaW4g TVQ2MzMyKQo+IC0gUlRDIChNVDYzMzEpCj4gLSBLZXlzIChNVDYzMzEpCj4gLSBJbnRlcnJ1cHRz IChNVDYzMzEgYWxzbyBkaXNwYXRjaGVzIE1UNjMzMidzIGludGVycnVwdHMpCj4gCj4gVGhlcmUn cyBtb3JlIHRvIGJlIGltcGxlbWVudGVkLCBlc3BlY2lhbGx5IGZvciBNVDYzMzIsIHdoaWNoCj4g d2lsbCBjb21lIGF0IGEgbGF0ZXIgc3RhZ2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogQW5nZWxvR2lv YWNjaGlubyBEZWwgUmVnbm8gPGFuZ2Vsb2dpb2FjY2hpbm8uZGVscmVnbm9AY29sbGFib3JhLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9tZmQvbXQ2Mzk3LWNvcmUuYyAgICAgICAgICAgIHwgIDQ3ICsr Cj4gIGRyaXZlcnMvbWZkL210NjM5Ny1pcnEuYyAgICAgICAgICAgICB8ICAgOSArLQo+ICBpbmNs dWRlL2xpbnV4L21mZC9tdDYzMzEvY29yZS5oICAgICAgfCAgNTMgKysrCj4gIGluY2x1ZGUvbGlu dXgvbWZkL210NjMzMS9yZWdpc3RlcnMuaCB8IDU4NCArKysrKysrKysrKysrKysrKysrKysrKysK PiAgaW5jbHVkZS9saW51eC9tZmQvbXQ2MzMyL2NvcmUuaCAgICAgIHwgIDUzICsrKwo+ICBpbmNs dWRlL2xpbnV4L21mZC9tdDYzMzIvcmVnaXN0ZXJzLmggfCA2NDIgKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gIGluY2x1ZGUvbGludXgvbWZkL210NjM5Ny9jb3JlLmggICAgICB8ICAgMiAr Cj4gIDcgZmlsZXMgY2hhbmdlZCwgMTM4OSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4g IGNyZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2xpbnV4L21mZC9tdDYzMzEvY29yZS5oCj4gIGNy ZWF0ZSBtb2RlIDEwMDY0NCBpbmNsdWRlL2xpbnV4L21mZC9tdDYzMzEvcmVnaXN0ZXJzLmgKPiAg Y3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbWZkL210NjMzMi9jb3JlLmgKPiAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbWZkL210NjMzMi9yZWdpc3RlcnMuaAoKRm9y IG15IG93biByZWZlcmVuY2UgKGFwcGx5IHRoaXMgYXMtaXMgdG8geW91ciBzaWduLW9mZiBibG9j ayk6CgogIEFja2VkLWZvci1NRkQtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ CgotLSAKTGVlIEpvbmVzIFvmnY7nkLzmlq9dClByaW5jaXBhbCBUZWNobmljYWwgTGVhZCAtIERl dmVsb3BlciBTZXJ2aWNlcwpMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3Ig QXJtIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=