From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69039CCA47C for ; Fri, 17 Jun 2022 00:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232452AbiFQAKJ (ORCPT ); Thu, 16 Jun 2022 20:10:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiFQAKJ (ORCPT ); Thu, 16 Jun 2022 20:10:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E136212F; Thu, 16 Jun 2022 17:10:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD02EB8268A; Fri, 17 Jun 2022 00:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B08EC34114; Fri, 17 Jun 2022 00:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655424605; bh=cD73xFTYbV7d8FwYS/+LxjiTrj6GgeC/IFBJ0+It07Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsv9SdWuVyJNQeGUF1E0Nr3uDUJB7EeBVN4u0A2d1DNJmaibpJ6rwo//bI+x83hie aqyUD+fTDgnqYB6+kjpDVxuVMQbM5ZhBaucwIzgRmR66O2Y73qfViA6R4DUSDKG8ot 26pywnT/zcUitfw8JYK3Av8QaIknlH0gJhsoG3o3NGo0fh2OsXwG1K5CyBtrn0ZCoa yry1hDGnxYxhmOGfpf/4zKhfGF+GHYrpP9OuvTx18I7hEMr+wGmdQPKsPyZPR+hmdR gO8VzaiAsi/SeYo6HlyAOkvp3lJcdb51Rvn5HBnbqA7Tstf42V8uC4MJQ1rkXllg6a mvXY0iCAi1/Vg== Date: Thu, 16 Jun 2022 17:10:04 -0700 From: Vinod Koul To: Doug Anderson Cc: Abhinav Kumar , linux-phy@lists.infradead.org, Stephen Boyd , dri-devel , freedreno , Kishon Vijay Abraham I , Sankeerth Billakanti , Krzysztof Kozlowski , linux-arm-msm , quic_kalyant , Kuogee Hsieh , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rob Herring , Dmitry Baryshkov , Rob Clark , Bjorn Andersson Subject: Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Message-ID: References: <20220425210643.2420919-1-dianders@chromium.org> <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 16-06-22, 08:35, Doug Anderson wrote: > Hi, > > On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote: > > > > We're supposed to list the supplies in the dt bindings but there are > > none in the eDP PHY bindings. > > > > Looking at the driver in Linux, I can see that there seem to be two > > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > > bindings. > > > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > > immediately clear how to figure out how to fill in these supplies. The > > only two eDP related supplies are simply described as "power for eDP > > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > > from comparing how a similar PHY is hooked up on other similar > > Qualcomm boards, I'll make the educated guess that the 1.2V supply > > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > > that in the example here. > > > > Signed-off-by: Douglas Anderson > > --- > > > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Even though patch #1 in this series should be dropped, this patch > (patch #2) is still valid. Vinod: I assume this would land in your > tree along with the first two patches in Kuogee's series [1], which > are related. Please let me know if you need me to re-send or anything. I have applied this patch, thanks > [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ This needs rebase on phy split which I have picked -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28993C433EF for ; Fri, 17 Jun 2022 00:10:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB12510FA9C; Fri, 17 Jun 2022 00:10:07 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96E2B10FA9C; Fri, 17 Jun 2022 00:10:06 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B84161358; Fri, 17 Jun 2022 00:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B08EC34114; Fri, 17 Jun 2022 00:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655424605; bh=cD73xFTYbV7d8FwYS/+LxjiTrj6GgeC/IFBJ0+It07Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsv9SdWuVyJNQeGUF1E0Nr3uDUJB7EeBVN4u0A2d1DNJmaibpJ6rwo//bI+x83hie aqyUD+fTDgnqYB6+kjpDVxuVMQbM5ZhBaucwIzgRmR66O2Y73qfViA6R4DUSDKG8ot 26pywnT/zcUitfw8JYK3Av8QaIknlH0gJhsoG3o3NGo0fh2OsXwG1K5CyBtrn0ZCoa yry1hDGnxYxhmOGfpf/4zKhfGF+GHYrpP9OuvTx18I7hEMr+wGmdQPKsPyZPR+hmdR gO8VzaiAsi/SeYo6HlyAOkvp3lJcdb51Rvn5HBnbqA7Tstf42V8uC4MJQ1rkXllg6a mvXY0iCAi1/Vg== Date: Thu, 16 Jun 2022 17:10:04 -0700 From: Vinod Koul To: Doug Anderson Subject: Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Message-ID: References: <20220425210643.2420919-1-dianders@chromium.org> <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sankeerth Billakanti , Rob Clark , linux-arm-msm , Kuogee Hsieh , Abhinav Kumar , dri-devel , Kishon Vijay Abraham I , Rob Herring , Andy Gross , Bjorn Andersson , Dmitry Baryshkov , Krzysztof Kozlowski , linux-phy@lists.infradead.org, Stephen Boyd , freedreno , LKML Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 16-06-22, 08:35, Doug Anderson wrote: > Hi, > > On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote: > > > > We're supposed to list the supplies in the dt bindings but there are > > none in the eDP PHY bindings. > > > > Looking at the driver in Linux, I can see that there seem to be two > > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > > bindings. > > > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > > immediately clear how to figure out how to fill in these supplies. The > > only two eDP related supplies are simply described as "power for eDP > > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > > from comparing how a similar PHY is hooked up on other similar > > Qualcomm boards, I'll make the educated guess that the 1.2V supply > > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > > that in the example here. > > > > Signed-off-by: Douglas Anderson > > --- > > > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Even though patch #1 in this series should be dropped, this patch > (patch #2) is still valid. Vinod: I assume this would land in your > tree along with the first two patches in Kuogee's series [1], which > are related. Please let me know if you need me to re-send or anything. I have applied this patch, thanks > [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ This needs rebase on phy split which I have picked -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEFAECCA47A for ; Fri, 17 Jun 2022 00:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dcv1+B3zwUOIuLny5IJuqzNjCqpTZZc23/rjETBU8H0=; b=3gyKVN1/EVdvDv EnQ56xARPDXNfm2ZL/CSpDvaODEO71VWYqUgwRBG8WmM9dWTSi/04FBNSkTF1RNGfkvxXBF6dBBZm F7wGlwd4l317nWvcxG87cVw4Phi0+jLUR0SPAJ4swVF6ADD0p+JwDGHJzeh4OGm4YV7uaqzAO/ksV fTs3lEJr0Aofy0qxLKaMggDhDYflHRMxR3nbg+FZa3AyucAQuyxxX9v5Xmi7yxqn/D+TFGgP7AM5j yXhUiOl9afIgLitSmucEL19sw5WD9QJnrNO0QwPKOf5PbiPxFcXTmxNdlSKoqqSTQ2FF23qudRN1B VwuZqC9aFOrhf0cXmf5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1zYx-004rHo-5N; Fri, 17 Jun 2022 00:10:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o1zYu-004rH6-13 for linux-phy@lists.infradead.org; Fri, 17 Jun 2022 00:10:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B84161358; Fri, 17 Jun 2022 00:10:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B08EC34114; Fri, 17 Jun 2022 00:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655424605; bh=cD73xFTYbV7d8FwYS/+LxjiTrj6GgeC/IFBJ0+It07Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsv9SdWuVyJNQeGUF1E0Nr3uDUJB7EeBVN4u0A2d1DNJmaibpJ6rwo//bI+x83hie aqyUD+fTDgnqYB6+kjpDVxuVMQbM5ZhBaucwIzgRmR66O2Y73qfViA6R4DUSDKG8ot 26pywnT/zcUitfw8JYK3Av8QaIknlH0gJhsoG3o3NGo0fh2OsXwG1K5CyBtrn0ZCoa yry1hDGnxYxhmOGfpf/4zKhfGF+GHYrpP9OuvTx18I7hEMr+wGmdQPKsPyZPR+hmdR gO8VzaiAsi/SeYo6HlyAOkvp3lJcdb51Rvn5HBnbqA7Tstf42V8uC4MJQ1rkXllg6a mvXY0iCAi1/Vg== Date: Thu, 16 Jun 2022 17:10:04 -0700 From: Vinod Koul To: Doug Anderson Cc: Abhinav Kumar , linux-phy@lists.infradead.org, Stephen Boyd , dri-devel , freedreno , Kishon Vijay Abraham I , Sankeerth Billakanti , Krzysztof Kozlowski , linux-arm-msm , quic_kalyant , Kuogee Hsieh , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rob Herring , Dmitry Baryshkov , Rob Clark , Bjorn Andersson Subject: Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Message-ID: References: <20220425210643.2420919-1-dianders@chromium.org> <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220616_171008_149292_28E4F763 X-CRM114-Status: GOOD ( 23.49 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 16-06-22, 08:35, Doug Anderson wrote: > Hi, > > On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson wrote: > > > > We're supposed to list the supplies in the dt bindings but there are > > none in the eDP PHY bindings. > > > > Looking at the driver in Linux, I can see that there seem to be two > > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > > bindings. > > > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > > immediately clear how to figure out how to fill in these supplies. The > > only two eDP related supplies are simply described as "power for eDP > > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > > from comparing how a similar PHY is hooked up on other similar > > Qualcomm boards, I'll make the educated guess that the 1.2V supply > > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > > that in the example here. > > > > Signed-off-by: Douglas Anderson > > --- > > > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Even though patch #1 in this series should be dropped, this patch > (patch #2) is still valid. Vinod: I assume this would land in your > tree along with the first two patches in Kuogee's series [1], which > are related. Please let me know if you need me to re-send or anything. I have applied this patch, thanks > [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ This needs rebase on phy split which I have picked -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy